accel-ppp.git/accel-pppd/ctrl/pppoe/pppoe.c, branch sstp-alloc-invariant

Merge pull request #323 from nuclearcat/stability-fixes

2026-06-23T15:58:26+00:00

Stability fixes

pppoe: handle missing service-name tag

2026-06-23T14:36:34+00:00

Rejecting any PADR lacking a Service-Name tag (RFC 2516 compliance)

2026-05-29T05:58:41+00:00

Signed-off-by: Denys Fedoryshchenko

session: encapsulate statistics counters

2026-05-04T00:09:49+00:00

Group the core session starting, active, and finishing statistics behind the private ap_session_stat storage in session.c instead of exposing writable counters through ap_session.h. This keeps ownership inside the session core while preserving the existing CLI and ACCEL-PPP-MIB counter semantics. Route session counter updates through ap_session_stat_*() helpers. Session start, activation, termination, finish, and shutdown-idle paths no longer open-code individual counter increments/decrements; the update policy now lives beside the session-owned storage and uses relaxed atomic operations for the simple state counters. Make the CLI show-stat path render from a local snapshot and convert the PPP SNMP starting/active/finishing scalars from watched raw pointers to scalar handlers. PPP controllers now read max-session limits through ap_session_stat_starting() and ap_session_stat_active(), removing external direct access to ap_session_stat. Signed-off-by: Denys Fedoryshchenko

pppoe: encapsulate statistics counters

2026-05-04T00:09:49+00:00

Group the PPPoE statistics in struct pppoe_stat_t and keep the storage private to pppoe.c instead of exporting writable counter globals through pppoe.h. The CLI now reads a snapshot with pppoe_stat_get(), while the packet/control paths update the counters through the PPPoE-owned storage using relaxed atomic operations. Convert the PPPoE SNMP starting/active scalars from watched raw pointers to scalar handlers. This removes the old pppoe_get_stat() pointer escape hatch and makes SNMP read the counters through pppoe_stat_starting() and pppoe_stat_active(), so the synchronization policy is applied consistently outside the PPPoE module. This also fixes the long-standing PPPoE starting counter behavior. PPPoE used to expose starting in the CLI and ACCEL-PPP-MIB, but never updated it, so it always reported zero. Track a per-connection ppp_starting state, increment starting when the controller begins channel setup, move the session from starting to active after establish_ppp() succeeds, and decrement starting on setup failure before PPP becomes active. This matches the state accounting used by the other PPP controllers. Signed-off-by: Denys Fedoryshchenko

Remove unused printf.h include

2026-02-22T20:20:20+00:00

Removed conditional inclusion of printf.h.

Merge pull request #277 from nuclearcat/minor-rfc2516-compliance

2025-12-13T15:25:13+00:00

pppoe: Fix RFC2516 non-compilance in PADI tags parsing

2025-12-10T23:01:05+00:00

We currently only break out of the switch, so the for loop keeps parsing tags after TAG_END_OF_LIST (accel-pppd/ctrl/pppoe/pppoe.c: around pppoe_recv_PADI). RFC 2516 (paragraph 5, Tag Types: End-of-List) says an End-of-List tag MAY appear in PADI/PADR and "any TAGs after an End-of-List MUST be ignored." Since we continue processing them, this behavior is technically non-compliant with the RFC. Same in pppoe_recv_PADR. Signed-off-by: Denys Fedoryshchenko

crypto: Removed internal tomcat crypto.

2025-12-10T17:16:42+00:00

Signed-off-by: Andrii Melnychenko

pppoe: add missing break, ignore vendor-specific tags when parsing PADR

2025-11-23T14:13:23+00:00

Added an explicit break after handling TAG_VENDOR_SPECIFIC, so vendor-specific PADR tags (e.g., TR-101) no longer fall through and get misinterpreted as other tags like TAG_PPP_MAX_PAYLOAD. Signed-off-by: Denys Fedoryshchenko