accel-ppp.git/accel-pppd/ipv6, branch sstp-alloc-invariant

ipv6: fix NULL deref and OOB read in dnssl/AFTR-Name config parsing

2026-07-06T22:41:01+00:00

add_dnssl() in nd.c and dhcpv6.c, and its copy add_aftr_gw() in dhcpv6.c, call strlen(val) before the "if (!val)" guard, so a dnssl option without a value crashes on config load before the check is ever reached (also reported by cppcheck: "Either the condition '!val' is redundant or there is possible null pointer dereference"). Moving strlen() after the guard is not enough: an empty value such as a bare "dnssl=" or "aftr-gw=" passes the NULL check with n == 0 and the following "val[n - 1]" reads one byte before the string. Reject both NULL and empty values before taking the length. Note these functions are only reached from the config parser (the [ipv6-dns] section and the ipv6-dhcp "aftr-gw" option) at startup or on config reload; nothing from received packets flows into them. So this is a robustness fix for invalid/malformed configuration files (local DoS at worst), not a remotely triggerable issue. The NULL-check ordering in add_dnssl() was originally fixed by [anp/hsw] in PR #13; this extends it to empty values and to the same pattern in add_aftr_gw(). Co-authored-by: [anp/hsw]

dhcpv6: validate AFTR name formatting

2026-06-23T14:36:34+00:00

netlink: Added VRF support

2026-01-30T03:25:54+00:00

Added VRF support to the iproute routines. Updated iproute* calls in the ipoe, radius, and dhcpv6 code. Signed-off-by: Andrii Melnychenko

ipv6: Add DHCPv6 Confirm processing

2024-12-12T20:42:38+00:00

ipv6_dhcp: Add RFC6334 AFTR-Name option support

2024-05-05T11:52:31+00:00

T72: Fix compilations warnings for unaligned variable access

2022-10-22T12:11:29+00:00

- IPoE/DHCP4: Specify minimal suitable alignment explicitly. We need to guarantee 2 byte alignment for the `hdr` pointer in `ip_csum(uint16_t *buf)` calculation - PPPOE: Suppress false-positive warning for `sockaddr_pppox`. Similiar issue: https://github.com/kernelslacker/trinity/pull/40 - Introduce tmp variables to avoid alignment issues for SSTP/DHCPv6 For additional details: https://phabricator.accel-ppp.org/T72 Signed-off-by: Volodymyr Huti

Merge pull request #54 from telirebarry/fix-ipv6-netns

2022-07-27T09:36:44+00:00

Fix ipv6 inside netns

ipv6_dhcp:change log message with appropriate file name

2022-07-05T08:22:26+00:00

This commit proposes to modify the log message in dhcpv6.c to include the correct file name. It avoids confusion when reading the logs

ipv6_dhcp: fix create ipv6 socket inside netns

2022-06-22T15:12:32+00:00

This fix allow to create the socket inside the netns for ipv6-dhcp module.

ipv6_nd: fix ipv6 auto-configuration in netns

2022-06-22T14:55:48+00:00

ipv6 auto-configuration generate error when link is terminated inside netns. The error message is : "ipv6_nd: setsockopt(SO_BINDTODEVICE): No such device" This error is generated because socket is not created inside the netns but it’s created in the default netns. This fix allow to create the socket in the right place. to propose this fix, i was inspired by : issue : https://phabricator.accel-ppp.org/T68 commit : https://github.com/accel-ppp/accel-ppp/commit/f1d616d91914be493b6a32a96323fa871733f8e0