accel-ppp.git/accel-pppd/libnetlink/iputils.c, branch stable

iputils: fix vlan creation on big-endian platforms

2024-08-26T20:58:31+00:00

libnetlink: fix a crash with a non vlan interface

2023-06-26T13:47:58+00:00

Fix a segmentation fault when starting when accel-ppp is configured with an non vlan interface. Signed-off-by: Philippe Guibert Signed-off-by: Louis Scalbert

Use 64-bit interface statistics rather than doing custom 32-bit overflow handling.

2022-11-01T08:51:34+00:00

When a link has a relatively high throughput, the 32-bit packet and byte counters could overflow multiple times between accounting runs. To accommodate this limitation, directly use 64-bit interface statistics. This also gets rid of the internal giga-word counters.

iputils: remove unnecessary NLM_F_ACK

2018-12-20T03:21:36+00:00

Using NLM_F_ACK in these functions is confusing because they don't parse any netlink response. In fact, NLM_F_ACK is only required internally by rtnl_talk(), which already adds it when its 'answer' parameter is NULL. Therefore it's useless to manually set it in functions that don't set 'answer'. Signed-off-by: Guillaume Nault

iputils: remove NLM_F_CREATE flag from ip6{route,addr}_del()

2018-12-20T03:21:35+00:00

These are deletion requests. NLM_F_CREATE is confusing for readers and ignored by kernel. Signed-off-by: Guillaume Nault

iputils: always set scope to RT_SCOPE_UNIVERSE in ip6route_{add,del}()

2018-12-20T03:21:33+00:00

No need to be clever here. All IPv6 routes have global scope (kernel ignores rtm_scope for IPv6 and always reports RT_SCOPE_UNIVERSE when dumping such routes). Signed-off-by: Guillaume Nault

iputils: set scope depending on gateway in iproute_{add,del}()

2018-12-20T03:21:31+00:00

From a logical point of view, we have link scope if no gateway is present, and global scope otherwise. Therefore it makes more sense to set rtm_scope depending on 'gw' rather than on 'ifindex'. Currently, callers of iproute_add() and iproute_del() either set 'ifindex' or 'gw', but never both. So even if confusing, the current code results in right scope selection. However one can't figure this out without analysing every caller. We should set rtm_scope based on the presence of the gateway instead. Given the current code base, that doesn't change the end result, but that better maches the scope concept. Also, that's the way iproute2 does its selection. Furthermore, it'd be perfectly valid to have both 'iface' and 'gw' set. In that case, scope should be RT_SCOPE_UNIVERSE instead of RT_SCOPE_LINK. Basing scope selection on 'gw' makes this case work correctly. Signed-off-by: Guillaume Nault

iputils: add 'src' and 'gw' parameters to iproute_del()

2018-12-20T03:21:28+00:00

Rework iproute_del() to have the same parameters as iproute_add(). This will allow callers to specify more precisely the route they want to delete. Callers will later be converted to make use of these parameters to ensure that the removed route precisely matches the one that was originaly inserted. Signed-off-by: Guillaume Nault

libnetlink: add gateway and priority parameters to ip6route_*()

2018-12-04T03:26:35+00:00

Let callers set a gateway and a priority to IPv6 routes. This is necessary for implementing the RADIUS Framed-IPv6-Route attribute. Also let ip6route_del() configure .rtm_protocol. This is already implemented in ip6route_add(), so we need to add the ip6route_del() counterpart. Otherwise, we couldn't delete routes that were added using a non-zero protocol. Signed-off-by: Guillaume Nault

ifcfg: assign p-t-p address if mask=32 and regular address in other cases

2018-05-25T09:44:41+00:00