accel-ppp.git/accel-pppd/radius, branch stable

radius: fix stop accounting timeout flow and request cleanup

2026-03-22T22:04:49+00:00

When sending accounting STOP requests, the timer callback was incorrectly set to the START timeout handler. This caused stop retries to follow the wrong termination path. Also clear rpd->acct_req before freeing on stop timeout/shutdown failures to avoid leaving a stale pointer. This bug is very nasty, revealed during stress tests, leading to memory corruption and other bad stuff when there is noticeable loss of radius "Stop" packets. Signed-off-by: Denys Fedoryshchenko

radius: Fix use after free and more

2026-03-22T22:04:34+00:00

Situation is a bit complex. Even one problem we fix easily, such as saving server as variable, rad_req_free might free server in theory, and s will be invalid. This is a bit of rewrite, but proper fix. Fixes problem in 2 functions. Signed-off-by: Denys Fedoryshchenko

radius: Invalid integer and date parsing

2026-03-22T22:04:34+00:00

Actually 3 fixes in same place: INTEGER: size mismatch now breaks instead of falling through - a malformed INTEGER attribute is rejected rather than silently parsed with a wrong size INTEGER/DATE split: each case has its own break, no more fallthrough DATE: strictly requires len == 4 (per RFC 2865), warns and skips otherwise instead of silently accepting 1 or 2-byte dates Signed-off-by: Denys Fedoryshchenko

radius: Fix to same type of allocator and deallocator

2026-03-22T22:04:34+00:00

Signed-off-by: Denys Fedoryshchenko

radius: Fix invalid check after mempool allocation

2026-03-22T22:04:34+00:00

This check left old, relevant to mmap, migrate to proper check. Signed-off-by: Denys Fedoryshchenko

radius: MS-CHAP2-Success unchecked memcpy(40 bytes)

2026-03-22T22:04:34+00:00

Also fix small typo. Signed-off-by: Denys Fedoryshchenko

radius: Vendor attribute parsing over-reads

2026-03-22T22:04:34+00:00

When parsing vendor-specific attributes (type 26), the code reads internal structure without checking that the attribute data is long enough. Signed-off-by: Denys Fedoryshchenko

Update accel-pppd/radius/radius.c

2026-03-22T22:04:21+00:00

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update accel-pppd/radius/radius.c

2026-03-22T22:04:16+00:00

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

radius: Fix buggy Framed-Route parsing

2026-03-22T22:04:12+00:00

Signed-off-by: Denys Fedoryshchenko