diff options
| author | Dmitry Kozlov <xeb@mail.ru> | 2010-12-24 23:19:10 +0300 |
|---|---|---|
| committer | Dmitry Kozlov <xeb@mail.ru> | 2010-12-24 23:19:10 +0300 |
| commit | 0c62497d2a264d6fb3bafbe30e6bd79f0442ea7a (patch) | |
| tree | 8c62f63e00be39ac5c233d7a8549f012d989f3aa | |
| parent | 00b656fa15b7ff7ee0537dc92851d1185e5f5622 (diff) | |
| download | accel-ppp-0c62497d2a264d6fb3bafbe30e6bd79f0442ea7a.tar.gz accel-ppp-0c62497d2a264d6fb3bafbe30e6bd79f0442ea7a.zip | |
cli: use snprintf to prevent potential buffer overflow
| -rw-r--r-- | accel-pptpd/cli/std_cmd.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/accel-pptpd/cli/std_cmd.c b/accel-pptpd/cli/std_cmd.c index 0d168e58..c5ab6894 100644 --- a/accel-pptpd/cli/std_cmd.c +++ b/accel-pptpd/cli/std_cmd.c @@ -182,11 +182,11 @@ static int show_ses_exec(const char *cmd, char * const *fields, int fields_cnt, min = uptime / 60; sec = uptime % 60; if (day) - sprintf(time_str, "%i.%02i:%02i:%02i", day, hour, min, sec); + snprintf(time_str, 12, "%i.%02i:%02i:%02i", day, hour, min, sec); else - sprintf(time_str, "%02i:%02i:%02i", hour, min, sec); + snprintf(time_str, 12, "%02i:%02i:%02i", hour, min, sec); - sprintf(row->buf, "%9s %15s %16s %6s %6s %10s\r\n", ppp->ifname, ppp->username ? ppp->username : "", ip_str, ppp->ctrl->name, state_str, time_str); + snprintf(row->buf, 128, "%9s %15s %16s %6s %6s %10s\r\n", ppp->ifname, ppp->username ? ppp->username : "", ip_str, ppp->ctrl->name, state_str, time_str); if (order || match) list_add_tail(&row->entry, &temp_rows); else |