diff options
| author | Guillaume Nault <g.nault@alphalink.fr> | 2018-03-21 18:09:12 +0100 |
|---|---|---|
| committer | Dmitry Kozlov <xeb@mail.ru> | 2018-03-24 09:41:22 +0300 |
| commit | 29c626683ea1aa6136360a6afcc6a053d0342a3d (patch) | |
| tree | a9f7751cd2963a77e8a8b745fff1b3c038d1facc | |
| parent | 5da833d512870bfb4d39741df2bec7fad2969ebd (diff) | |
| download | accel-ppp-29c626683ea1aa6136360a6afcc6a053d0342a3d.tar.gz accel-ppp-29c626683ea1aa6136360a6afcc6a053d0342a3d.zip | |
auth: avoid sending duplicate CHAP Failure messages in mschap-v1 and mschap-v2
When pwdb returns PWDB_NO_IMPL and chap_recv_response() performs the
authentication itself, it delegates this task to chap_check_response().
This function sends a CHAP Failure message if it can't retrieve the
password, but not in case of password mismatch. Since
chap_recv_response() already sends a CHAP Failure message on error,
the one sent by chap_check_response() is useless.
Signed-off-by: Guillaume Nault <g.nault@alphalink.fr>
| -rw-r--r-- | accel-pppd/auth/auth_mschap_v1.c | 1 | ||||
| -rw-r--r-- | accel-pppd/auth/auth_mschap_v2.c | 1 |
2 files changed, 0 insertions, 2 deletions
diff --git a/accel-pppd/auth/auth_mschap_v1.c b/accel-pppd/auth/auth_mschap_v1.c index f40a8735..10424866 100644 --- a/accel-pppd/auth/auth_mschap_v1.c +++ b/accel-pppd/auth/auth_mschap_v1.c @@ -437,7 +437,6 @@ static int chap_check_response(struct chap_auth_data *ad, struct chap_response * if (!passwd) { if (conf_ppp_verbose) log_ppp_warn("mschap-v1: user not found\n"); - chap_send_failure(ad, conf_msg_failure); return PWDB_DENIED; } diff --git a/accel-pppd/auth/auth_mschap_v2.c b/accel-pppd/auth/auth_mschap_v2.c index 86917cb3..33b95dea 100644 --- a/accel-pppd/auth/auth_mschap_v2.c +++ b/accel-pppd/auth/auth_mschap_v2.c @@ -521,7 +521,6 @@ static int chap_check_response(struct chap_auth_data *ad, struct chap_response * if (!passwd) { if (conf_ppp_verbose) log_ppp_warn("mschap-v2: user not found\n"); - chap_send_failure(ad, conf_msg_failure, conf_msg_failure2); return -1; } |