summaryrefslogtreecommitdiff
path: root/accel-pppd/extra/chap-secrets.c
diff options
context:
space:
mode:
authorVladislav Grishenko <themiron@mail.ru>2018-10-25 05:11:32 +0500
committerVladislav Grishenko <themiron@mail.ru>2018-10-25 05:16:55 +0500
commit603800151415c69ceb3c9d986ef0c3487817cb67 (patch)
tree657aee87964ca4501a416db40ce3c66d9529128f /accel-pppd/extra/chap-secrets.c
parent938bad250baa7bd6f0761e70ce68a2de063c528c (diff)
downloadaccel-ppp-603800151415c69ceb3c9d986ef0c3487817cb67.tar.gz
accel-ppp-603800151415c69ceb3c9d986ef0c3487817cb67.zip
fix gateway address setup fail due memory corruption
log: libnetlink: RTNETLINK answers: Invalid argument ppp0: f7bb00a79ef667d2: failed to set IPv4 address: Invalid argument ipaddr_add_peer() called only with mask equeal 0 or 32, but w/o zero-allocated structs it contans garbage in some cases. so, instead ipaddr_add() was called with wrong mask value. also, init chap-secrets mask for the same reason.
Diffstat (limited to 'accel-pppd/extra/chap-secrets.c')
-rw-r--r--accel-pppd/extra/chap-secrets.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/accel-pppd/extra/chap-secrets.c b/accel-pppd/extra/chap-secrets.c
index becb687c..92cfb42f 100644
--- a/accel-pppd/extra/chap-secrets.c
+++ b/accel-pppd/extra/chap-secrets.c
@@ -24,7 +24,7 @@ static char *def_chap_secrets = "/etc/ppp/chap-secrets";
static char *conf_chap_secrets;
static int conf_encrypted;
static in_addr_t conf_gw_ip_address = 0;
-static int conf_netmask;
+static int conf_netmask = 0;
static void *pd_key;
static struct ipdb_t ipdb;
@@ -762,6 +762,7 @@ static void load_config(void)
parse_gw_ip_address(opt);
else {
conf_gw_ip_address = 0;
+ conf_netmask = 0;
}
opt = conf_get_opt("chap-secrets", "encrypted");