summaryrefslogtreecommitdiff
path: root/accel-pppd/ctrl
AgeCommit message (Collapse)Author
2025-12-13Merge pull request #277 from nuclearcat/minor-rfc2516-complianceDenys Fedoryshchenko
pppoe: Fix RFC2516 non-compilance in PADI tags parsing
2025-12-11pppoe: Fix RFC2516 non-compilance in PADI tags parsingDenys Fedoryshchenko
We currently only break out of the switch, so the for loop keeps parsing tags after TAG_END_OF_LIST (accel-pppd/ctrl/pppoe/pppoe.c: around pppoe_recv_PADI). RFC 2516 (paragraph 5, Tag Types: End-of-List) says an End-of-List tag MAY appear in PADI/PADR and "any TAGs after an End-of-List MUST be ignored." Since we continue processing them, this behavior is technically non-compliant with the RFC. Same in pppoe_recv_PADR. Signed-off-by: Denys Fedoryshchenko <denys.f@collabora.com>
2025-12-10Minor compile fix, we have only OpenSSL version nowDenys Fedoryshchenko
Signed-off-by: Denys Fedoryshchenko <denys.f@collabora.com>
2025-12-10crypto: Removed CRYPTO_OPENSSL definition.Andrii Melnychenko
OpenSSL is now mandatory. Signed-off-by: Andrii Melnychenko <a.melnychenko@vyos.io>
2025-12-10crypto: Removed internal tomcat crypto.Andrii Melnychenko
Signed-off-by: Andrii Melnychenko <a.melnychenko@vyos.io>
2025-12-01sstp: Add config option enum for better code readabilityDenys Fedoryshchenko
Signed-off-by: Denys Fedoryshchenko <denys.f@collabora.com>
2025-11-30Merge pull request #269 from nuclearcat/fix-buffer-overflowDenys Fedoryshchenko
l2tp: fix buffer overflow and type errors in Calling/Called Number handling
2025-11-26l2tp: fix buffer overflow and type errors in Calling/Called Number handlingDenys Fedoryshchenko
Fix issues introduced in 88a2ebdb: - Fix type declaration: uint8_t *calling[254] declared an array of 254 pointers instead of an array of 254 bytes. Remove erroneous asterisks. - Fix buffer overflow vulnerability: L2TP AVP values can be up to 1017 bytes (L2TP_AVP_LEN_MASK - sizeof(avp_header)), but buffers were only 254(*4?) bytes. A malicious packet could cause stack buffer overflow. Use L2TP_AVP_LEN_MASK (1023) for buffer size to handle maximum AVP length. - Remove useless NULL checks: Stack-allocated arrays can never be NULL, causing compiler warnings. The existence check is n > 0 / m > 1. Signed-off-by: Denys Fedoryshchenko <denys.f@collabora.com>
2025-11-26Suppress OpenSSL 3.0 deprecation warnings for legacy crypto APIsDenys Fedoryshchenko
We are using similar approach as in other projects, easiest one, but probably in future it will break as soon as this functions will be removed completely. Signed-off-by: Denys Fedoryshchenko <denys.f@collabora.com>
2025-11-23Merge pull request #238 from socketpair/chainDenys Fedoryshchenko
SSTP: load certificate chain instead of single one
2025-11-23pppoe: add missing break, ignore vendor-specific tags when parsing PADRDenys Fedoryshchenko
Added an explicit break after handling TAG_VENDOR_SPECIFIC, so vendor-specific PADR tags (e.g., TR-101) no longer fall through and get misinterpreted as other tags like TAG_PPP_MAX_PAYLOAD. Signed-off-by: Denys Fedoryshchenko <denys.f@collabora.com>
2025-08-19ci: add tests execution with asan and ubsanSergey V. Lobanov
2025-08-08Merge pull request #252 from nuclearcat/fix-musl-linkingDenys Fedoryshchenko
feat(build): Add MUSL detection and conditional linking
2025-08-07feat(build): Add MUSL detection and conditional linkingDenys Fedoryshchenko
This commit introduces the ability to detect if the project is being built with the MUSL C library. A new variable `MUSL` is set to `ON` if MUSL is detected, and `OFF` otherwise. This is achieved by checking the output of `ldd --version`. The `accel-pppd/ctrl/pppoe/CMakeLists.txt` file is updated to conditionally link the `connlimit` library only when building with MUSL. Signed-off-by: Denys Fedoryshchenko <denys.f@collabora.com>
2025-08-07ipoe: dhcp: Fix username for noauth sessionDmitriy Eshenko
2025-05-02SSTP: load certificate chain instead of single oneКоренберг ☢️ Марк
2025-01-22ipoe: fixed DHCP option 42 (ntp servers)aapostoliuk
Allowed using multiple NTP servers in DHCP option 42
2024-12-05L2TP include calling number to calling station ID RAYaroslav Kholod
2024-11-15Fix post_msg implementation buggrandnew
I think the error handling code of `post_msg` is wrongly implemented due to coding typo. The `EPIPE` should be also considered and then return -1, just like `PPTP_write`: https://github.com/xebd/accel-ppp/blob/1b8711cf75a7c278d99840112bc7a396398e0205/accel-pppd/ctrl/pptp/pptp.c#L539-L570
2024-10-26Merge pull request #185 from svlobanov/pcre2-1Denys Fedoryshchenko
migrate from pcre to pcre2
2024-10-04Merge pull request #183 from svlobanov/gcc14-compile-errorsDenys Fedoryshchenko
build: fix compile errors on GCC 14
2024-09-11Merge pull request #195 from nuclearcat/fix-typo-freeDenys Fedoryshchenko
fix(musl/l2tp_session_free): Fix, likely typo
2024-09-11fix(musl/l2tp_session_free): Fix, likely typoDenys Fedoryshchenko
It is logical, that function should remain same, not changed to free. Signed-off-by: Denys Fedoryshchenko <denys.f@collabora.com>
2024-09-05Revert "Fix #189: Make module pppoe work without module radius"Sergey V. Lobanov
This reverts commit 543700aed1ac045f12dfafd898bbbbae955fee31.
2024-09-04Fix #189: Make module pppoe work without module radiusNazar Androshchuk
The radius library is now linked in pppoe if `-DRADIUS` is true; it wasn't any issue when `-DRADIUS=FALSE`. This patch can't be worked around if the user wants to use pppoe with chap-secrets, because radius conflicts with chap-secrets.
2024-09-02migrate from pcre to pcre2Sergey V. Lobanov
PCRE is not supported anymore and removed from several distros
2024-08-27build: fix compile errors on GCC 14Sergey V. Lobanov
This patch fixes compile errors on GCC 14 like the following /root/accel-ppp/accel-pppd/radius/packet.c: In function 'rad_packet_recv': /root/accel-ppp/accel-pppd/radius/packet.c:142:72: error: passing argument 5 of 'recvfrom' from incompatible pointer type [-Wincompatible-pointer-types] 142 | n = recvfrom(fd, pack->buf, REQ_LENGTH_MAX, 0, addr, &addr_len); | ^~~~ | | | struct sockaddr_in * In file included from /usr/include/netinet/in.h:10, from /usr/include/arpa/inet.h:9, from /root/accel-ppp/accel-pppd/radius/packet.c:10: /usr/include/sys/socket.h:397:55: note: expected 'struct sockaddr * restrict' but argument is of type 'struct sockaddr_in *' Reference: https://gcc.gnu.org/gcc-14/porting_to.html
2024-08-19tests: add pcre negative cases, improve pcre-related code test coverageSergey V. Lobanov
these test cases will help for pcre2 migration (issue #173)
2024-08-18Merge pull request #163 from dpokrovsky/http-error-fixDenys Fedoryshchenko
Fixes the issue #124 "HTTP replay for non SSTP query" and log_debug2 in Triton lib
2024-07-28Fix issue #131, pptp doesnt work without connlimitDenys Fedoryshchenko
Fix issue https://github.com/accel-ppp/accel-ppp/issues/131 Proposed by https://github.com/kugel- Author: Thomas Martitz <kugel@rockbox.org> Signed-off-by: Denys Fedoryshchenko <denys.f@collabora.com>
2024-06-14Fixes the issue #124 "HTTP replay for non SSTP query"Dmitry Pokrovsky
2024-06-14Fixes the issue #124 "HTTP replay for non SSTP query"Dmitry Pokrovsky
2024-06-14Revert "1. Fixes the issue #124 "HTTP replay for non SSTP query""Dmitry Pokrovsky
This reverts commit 635ab1b77b06a8891479a46a0e1ba88315ff3958.
2024-06-121. Fixes the issue #124 "HTTP replay for non SSTP query"Dmitry Pokrovsky
2. Fixes log_debug2 in Triton lib
2024-04-10musl: Add musl compatibilityDenys Fedoryshchenko
Thanks for hints Alpine Linux project and their patches: https://git.alpinelinux.org/aports/tree/community/accel-ppp?h=master We can adjust a bit code and cmake config files to make accel-ppp buildable under musl "as is". Signed-off-by: Denys Fedoryshchenko <denys.f@collabora.com>
2023-12-27Merge pull request #118 from DmitriyEshenko/fix_local_net_checkxebd
ipoe: check localnet only for start=UP (unclassified packets) sessions
2023-12-26ipoe: check localnet only for start=UP (unclassified packets) sessionsDmitriy Eshenko
2023-12-17ipoe: Add per-interface check-mac-change optionDmitriy Eshenko
2023-11-30vlan_mon: ipoe: pppoe: Add disable vlan timeout featureDmitriy Eshenko
Co-authored-by: Peter Adam <p.adam@cygnusnetworks.de>
2023-07-01Merge pull request #95 from DmitriyEshenko/show-sessions-imprDmitriy Eshenko
CLI: PPPoE: Add possibility to display inbound interface and service-…
2023-06-30Merge pull request #91 from louis-6wind/fix-link-selection-mem-violationDmitriy Eshenko
ipoe: fix memory access violation with unset link-selection
2023-06-29CLI: PPPoE: Add possibility to display inbound interface and service-name in ↵Dmitriy Eshenko
show sessions command
2023-06-29CLI: PPPoE: Use global net variable to prevent SEGFAULTDmitriy Eshenko
When accel-ppp has no connected clients, CLI interface add command it try to use net == NULL and crush code.
2023-06-27ipoe: fix memory access violation with unset link-selectionLouis Scalbert
Link-selection pointer is not set to NULL when link-selection IPOE option is not set. It results in a memory access violation in dhcpv4_packet_insert_opt82() Set link-selection pointer to NULL if unset to fix the issue. Fixes: 61e31c591e ("ipoe: add dhcp link selection sub-option") Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
2023-06-05ipoe: add dhcp link selection sub-optionPhilippe Guibert
Add the support of DHCP option 82 "Agent Information" sub-option 5 "link selection". The IPv4 value can be specified in the [ipoe] "link-selection" configuration option. Link: https://www.rfc-editor.org/rfc/rfc3527.html Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com> Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
2023-05-05sstp: fix gcc9/clang address-of-packed-member warningVladislav Grishenko
Patially fixes 6e5f9980a8a71015a228279e07970621d23c7b35, there's no really requirement for packed internal sockaddr_t struct. Also, constantify several struct pointer arguments as well.
2023-05-05sstp: revert 6e5f9980a8a71015a228279e07970621d23c7b35Vladislav Grishenko
There's no alignment reason for making temporary vars on stack assuming unaligned block copy.
2023-05-05sstp: fix termios structure initializationVladislav Grishenko
Fixes ad94c19554d7c6bb18ab2e251e4ee403ee0b7732, tios is sill left partially initialized with sane values. Also, log get/set attr errors with error level as well since it raises pty allocation error and connection drop therefore.
2022-11-01Merge pull request #66 from boomer41/feature/additions-2022-11-01xebd
Use 64-bit interface statistics and some more env parameters for pppd-compat
2022-11-01Merge pull request #64 from volodymyrhuti/masterEshenko Dmitriy
T72: Fix compilations warnings for unaligned variable access
generated by cgit v1.2.3 (git 2.39.1) at 2026-07-14 17:15:31 +0000