| Age | Commit message (Collapse) | Author |
|
Add the missing PPPoSEQ install rules and standalone driver metadata. Supply the running kernel release as the default RPM module destination. Extend the rootless install regression to verify Debian/CentOS packaging names, staged module paths, and exclusion after disabling the build flag.
Validation: CTest passes; generated full and standalone DEBs contain ppposeq.ko and have the expected package names. RPM install rules were staged and checked; an RPM archive was not built because rpmbuild is unavailable.
Signed-off-by: Denys Fedoryshchenko <denys.f@collabora.com>
|
|
drivers/pptp is version 0.8.5 of the PPTP driver, the direct ancestor of mainline drivers/net/ppp/pptp.c. Mainline merged that code in 2.6.37 (2011) from the same author and has maintained it since; this copy received none of the subsequent fixes and is no longer worth carrying:
- It cannot be built. struct flowi's nl_u union, the 3-argument ip_route_output_key(), sock_no_poll, the old ip_select_ident() signature and nf_reset() all disappeared long ago, so nothing past roughly 2.6.36 compiles and -DBUILD_PPTP_DRIVER=TRUE is a build failure everywhere.
- It is not needed. The PPTP bits of accel-pppd/include/if_pppox.h are identical to the mainline UAPI header, so ctrl/pptp's socket(AF_PPPOX, SOCK_STREAM, PX_PROTO_PPTP) reaches the in-kernel module (alias net-pf-24-proto-2) unchanged. The daemon uses no interface the bundled driver added. The deleted drivers/pptp/if_pppox.h was included only by drivers/pptp/pptp.c; all other if_pppox.h includes use either the kernel UAPI header or accel-pppd's userspace copy.
- It is unsafe. Among others: the pskb_may_pull() in pptp_rcv() is commented out, so the GRE header is parsed with no length validation at all; the skb->len - headersize comparison in pptp_rcv_core() underflows and leads to an out-of-bounds read and a negative skb_pull(); pptp_getname() copies uninitialised stack to userspace; and pptp_bind()/pptp_connect() never check sockaddr_len (CVE-2015-8569). Mainline fixed each of these years ago.
Remove the directory along with the BUILD_PPTP_DRIVER option, the accel-pptp-kmod package and the ip_gre conflict warning, which only existed because this module claimed IPPROTO_GRE. accel-pppd/ctrl/pptp and accel-pppd/include/if_pppox.h are unaffected. PPTP now requires the kernel's own pptp module; kernels older than 2.6.37 are no longer supported.
|
|
|
|
|
|
|
|
|
|
* ipoe: fixed mask calculation from ipaddr radius attribute
* ipoe: fixed authentication with chap-secrets
* ipoe: set Calling-Station-Id to client mac address for UP sessions
* ipoe: introduced idle-timeout and session-timeout options
* ipoe: for option password implemented special value csid
* ipoe: change l4-redirect-ipset/l4-redirect-table by CoA
* ipoe: don't block lua script if it raises error
* ipoe: implemented soft session termination
* ipoe: implemneted passing DHCP Option 82 to Radius as two separated attributes
* ipoe: changed behavior of agent-remote-id option
* ipoe: introduced option check-mac-change
* ipoe: disabled udp checksum validation
* ipoe: introduced 'calling-sid' option
* ipoe: send client IP address in Framed-IP-Address for UP sessions
* ipoe: implemented username=ifname for UP sessions
* ipoe: use single socket for arp processing
* ipoe: implemented dhcp option 58
* ipoe: for vlan name pattern implemented %P argument - VID of parent interface
* ipoe: implemented ability to use lua to make vlan name
* ipoe: show sessions: intoduced new field ipoe-type to display type of session (up or dhcp)
* ipoe: implemented interface renaming by NAS-Port-Id
* pppoe: use single discovery socket
* pppoe: check for tag length in print_packet function (fixes sigsegv)
* ppp: fixed send double ConfAck when LCP is started
* ppp: fix mtu/mru set if not negotiated on any end plus cleanup
* ppp: set mtu and mru after unit creation
* ppp: create ppp units after authentication
* ppp: set unit index from NAS_Port attribute if present
* cli: show sesisons: introduced rx-bytes,rx-pkts,tx-bytes,tx-pkts fields
* cli: show sesisons: introduced rx-bytes-raw,tx-bytes-raw fields
* session: implemented idle and timeout timers
* radius: override session's idle and timeout timers values by Idle-Timeout and Session-Timeout attributes
* shaper: fixed parsing ecn/noecn for fq_codel
* replace mktemp with mkstemp
* properly handle Cisco-AVPair
* consider only rx interface counter for idle timeout calculation
* net-snmp: export interface counters in the sessionTable
|
|
|
|
This reverts commit c317ff519717c5c9f0513b85bb7d10ba084c74e9.
|
|
|
|
* major l2tp rewrite
* introduced ipoe (ipv4 only) module
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|