summaryrefslogtreecommitdiff
path: root/drivers/ipoe
AgeCommit message (Collapse)Author
2024-06-02build: add dkms support for ipoe and vlan_mon drivers, ci optimizationsSergey V. Lobanov
Signed-off-by: Sergey V. Lobanov <sergey@lobanov.in>
2024-04-02ipoe/vlan_mon: Add proper accel_ppp_version to vlan_mon and ipoeDenys Fedoryshchenko
Signed-off-by: Denys Fedoryshchenko <denys.f@collabora.com>
2023-09-23ipoe:vlan_mon: add support for kernels 6.4+Dmitriy Eshenko
2023-07-17ipoe: Add kernel 6.3 compatibilityDmitriy Eshenko
2023-01-24ipoe,vlan_mon: add support for kernels 6.1+Dmitriy Eshenko
Co-authored-by: Martin Zaharinov <micron@bngsoft.net>
2022-05-05Use helper function to set device addressPeter Adam p.adam@cygnusnetworks.de
2021-03-20Fixed some errors found by valgrind and pvs-studio (#11)[anp/hsw]
* Fix errors found by valgrind ==12312== Syscall param sendmsg(msg.msg_iov[0]) points to uninitialised byte(s) ==12312== at 0x486CCF0: sendmsg (in /lib/libpthread-2.22.so) ==12312== by 0x12F57F: rtnl_talk (libnetlink.c:316) ==12312== by 0x132DA3: genl_resolve_mcg (genl.c:52) ==12312== by 0x484E1CB: init (vlan_mon.c:528) ==12312== by 0x484CDC0: vlan_mon_register_proto (vlan_mon.c:48) ==12312== by 0x510B763: load_vlan_mon (pppoe.c:1914) ==12312== by 0x510BFF2: load_config (pppoe.c:2064) ==12312== by 0x510C22A: pppoe_init (pppoe.c:2108) ==12312== by 0x483E9EB: triton_load_modules (triton.c:704) ==12312== by 0x1384B2: main (main.c:339) ==12312== Address 0xbedacdd8 is on thread 1's stack ==12312== in frame #2, created by genl_resolve_mcg (genl.c:23) ==12312== 15 bytes in 1 blocks are definitely lost in loss record 352 of 836 ==12312== at 0x482A9A9: malloc (in /usr/lib/valgrind/vgpreload_memcheck-x86-linux.so) ==12312== by 0x4B97524: strdup (in /lib/libc-2.22.so) ==12312== by 0x12C30C: init (telnet.c:769) ==12312== by 0x483E9EB: triton_load_modules (triton.c:704) ==12312== by 0x1384B2: main (main.c:339) ==12312== ==12312== 15 bytes in 1 blocks are definitely lost in loss record 353 of 836 ==12312== at 0x482A9A9: malloc (in /usr/lib/valgrind/vgpreload_memcheck-x86-linux.so) ==12312== by 0x4B97524: strdup (in /lib/libc-2.22.so) ==12312== by 0x12D60A: init (tcp.c:392) ==12312== by 0x483E9EB: triton_load_modules (triton.c:704) ==12312== by 0x1384B2: main (main.c:339) * Fix another warnings by cppcheck [accel-pppd/ctrl/ipoe/arp.c:256]: (error) Uninitialized variable: n [accel-pppd/ctrl/pppoe/mac_filter.c:90]: (warning) %x in format string (no. 1) requires 'unsigned int *' but the argument type is 'signed int *'. [accel-pppd/ctrl/pppoe/mac_filter.c:90]: (warning) %x in format string (no. 2) requires 'unsigned int *' but the argument type is 'signed int *'. [accel-pppd/ctrl/pppoe/mac_filter.c:90]: (warning) %x in format string (no. 3) requires 'unsigned int *' but the argument type is 'signed int *'. [accel-pppd/ctrl/pppoe/mac_filter.c:90]: (warning) %x in format string (no. 4) requires 'unsigned int *' but the argument type is 'signed int *'. [accel-pppd/ctrl/pppoe/mac_filter.c:90]: (warning) %x in format string (no. 5) requires 'unsigned int *' but the argument type is 'signed int *'. [accel-pppd/ctrl/pppoe/mac_filter.c:90]: (warning) %x in format string (no. 6) requires 'unsigned int *' but the argument type is 'signed int *'. [accel-pppd/ctrl/pppoe/mac_filter.c:129]: (warning) %x in format string (no. 1) requires 'unsigned int *' but the argument type is 'signed int *'. [accel-pppd/ctrl/pppoe/mac_filter.c:129]: (warning) %x in format string (no. 2) requires 'unsigned int *' but the argument type is 'signed int *'. [accel-pppd/ctrl/pppoe/mac_filter.c:129]: (warning) %x in format string (no. 3) requires 'unsigned int *' but the argument type is 'signed int *'. [accel-pppd/ctrl/pppoe/mac_filter.c:129]: (warning) %x in format string (no. 4) requires 'unsigned int *' but the argument type is 'signed int *'. [accel-pppd/ctrl/pppoe/mac_filter.c:129]: (warning) %x in format string (no. 5) requires 'unsigned int *' but the argument type is 'signed int *'. [accel-pppd/ctrl/pppoe/mac_filter.c:129]: (warning) %x in format string (no. 6) requires 'unsigned int *' but the argument type is 'signed int *'. [accel-pppd/ctrl/pppoe/mac_filter.c:158]: (warning) %x in format string (no. 1) requires 'unsigned int *' but the argument type is 'signed int *'. [accel-pppd/ctrl/pppoe/mac_filter.c:158]: (warning) %x in format string (no. 2) requires 'unsigned int *' but the argument type is 'signed int *'. [accel-pppd/ctrl/pppoe/mac_filter.c:158]: (warning) %x in format string (no. 3) requires 'unsigned int *' but the argument type is 'signed int *'. [accel-pppd/ctrl/pppoe/mac_filter.c:158]: (warning) %x in format string (no. 4) requires 'unsigned int *' but the argument type is 'signed int *'. [accel-pppd/ctrl/pppoe/mac_filter.c:158]: (warning) %x in format string (no. 5) requires 'unsigned int *' but the argument type is 'signed int *'. [accel-pppd/ctrl/pppoe/mac_filter.c:158]: (warning) %x in format string (no. 6) requires 'unsigned int *' but the argument type is 'signed int *'. [accel-pppd/ctrl/pppoe/pppoe.c:738]: (warning) Possible null pointer dereference [accel-pppd/ipv6/dhcpv6.c:911]: (warning) %x in format string (no. 1) requires 'unsigned int *' but the argument type is 'int *'. [accel-pppd/ipv6/dhcpv6.c:911]: (warning) %x in format string (no. 2) requires 'unsigned int *' but the argument type is 'signed int *'. [accel-pppd/ipv6/dhcpv6.c:911]: (warning) %x in format string (no. 3) requires 'unsigned int *' but the argument type is 'signed int *'. [accel-pppd/ipv6/dhcpv6.c:911]: (warning) %x in format string (no. 4) requires 'unsigned int *' but the argument type is 'signed int *'. [accel-pppd/libnetlink/libnetlink.c:515]: (warning) Possible null pointer dereference [accel-pppd/ppp/ipv6cp_opt_intfid.c:185]: (warning) %x in format string (no. 1) requires 'unsigned int *' but the argument type is 'signed int *'. [accel-pppd/ppp/ipv6cp_opt_intfid.c:298]: (warning) %x in format string (no. 1) requires 'unsigned int *' but the argument type is 'int *'. [accel-pppd/ppp/ipv6cp_opt_intfid.c:298]: (warning) %x in format string (no. 2) requires 'unsigned int *' but the argument type is 'signed int *'. [accel-pppd/ppp/ipv6cp_opt_intfid.c:298]: (warning) %x in format string (no. 3) requires 'unsigned int *' but the argument type is 'signed int *'. [accel-pppd/ppp/ipv6cp_opt_intfid.c:298]: (warning) %x in format string (no. 4) requires 'unsigned int *' but the argument type is 'signed int *'. * Suppress compiler warnings * Fix locking errors /opt/pvs/accel-ppp/accel-pppd/extra/pppd_compat.c 279 warn V1020 The function exited without calling the 'sigchld_unlock' function. Check lines: 279, 249. /opt/pvs/accel-ppp/accel-pppd/extra/pppd_compat.c 333 warn V1020 The function exited without calling the 'sigchld_unlock' function. Check lines: 333, 315. /opt/pvs/accel-ppp/accel-pppd/extra/pppd_compat.c 422 warn V1020 The function exited without calling the 'sigchld_unlock' function. Check lines: 422, 372. /opt/pvs/accel-ppp/accel-pppd/extra/pppd_compat.c 488 warn V1020 The function exited without calling the 'sigchld_unlock' function. Check lines: 488, 468. /opt/pvs/accel-ppp/accel-pppd/triton/mempool.c 119 warn V1020 The function exited without calling the 'pthread_spin_unlock' function. Check lines: 119, 116. * Fix array len errors /opt/pvs/accel-ppp/accel-pppd/triton/conf_file.c 75 warn V557 Array underrun is possible. The value of 'len - 1' index could reach -1. /opt/pvs/accel-ppp/accel-pppd/triton/conf_file.c 76 warn V557 Array underrun is possible. The value of '-- len' index could reach -1. * Fix possible memory leaks /opt/pvs/accel-ppp/accel-pppd/radius/radius.c 936 err V773 The function was exited without releasing the 'str' pointer. A memory leak is possible. /opt/pvs/accel-ppp/accel-pppd/radius/serv.c 622 err V773 The function was exited without releasing the 'str' pointer. A memory leak is possible. /opt/pvs/accel-ppp/accel-pppd/triton/conf_file.c 144 err V773 The function was exited without releasing the 'raw' pointer. A memory leak is possible. * Fix unsafe code /opt/pvs/accel-ppp/accel-pppd/cli/tcp.c 364 warn V1004 The 'host' pointer was used unsafely after it was verified against nullptr. Check lines: 338, 364. /opt/pvs/accel-ppp/accel-pppd/cli/telnet.c 701 warn V1004 The 'host' pointer was used unsafely after it was verified against nullptr. Check lines: 675, 701. /opt/pvs/accel-ppp/accel-pppd/extra/ippool.c 241 err V614 Potentially uninitialized pointer 'pos' used. /opt/pvs/accel-ppp/accel-pppd/radius/dict.c 165 err V614 Uninitialized pointer 'parent_items' used. * Remove duplicate code /opt/pvs/accel-ppp/accel-pppd/radius/serv.c 202 warn V547 Expression 'ts.tv_sec < req->serv->fail_time' is always false. * Fix treating signed bool variables as unsigned * Add nullptr checking /opt/pvs/accel-ppp/accel-pppd/ipv6/dhcpv6.c 886 err V595 The 'opt->val' pointer was utilized before it was verified against nullptr. Check lines: 886, 890. /opt/pvs/accel-ppp/accel-pppd/ipv6/nd.c 479 err V595 The 'opt->val' pointer was utilized before it was verified against nullptr. Check lines: 479, 483. /opt/pvs/accel-ppp/accel-pppd/radius/auth.c 152 err V595 The 'rpd->auth_ctx' pointer was utilized before it was verified against nullptr. Check lines: 152, 154. /opt/pvs/accel-ppp/accel-pppd/triton/conf_file.c 114 err V595 The 'cur_sect' pointer was utilized before it was verified against nullptr. Check lines: 114, 117. * Add logging of exit conditions * Clarify calculation [accel-pppd/ppp/ccp_mppe.c:281]: (style) Clarify calculation precedence for '&' and '?'. [accel-pppd/ppp/ccp_mppe.c:282]: (style) Clarify calculation precedence for '&' and '?'. [accel-pppd/ppp/ccp_mppe.c:283]: (style) Clarify calculation precedence for '&' and '?'. [accel-pppd/ppp/ccp_mppe.c:284]: (style) Clarify calculation precedence for '&' and '?'. [accel-pppd/ppp/ccp_mppe.c:285]: (style) Clarify calculation precedence for '&' and '?'. [accel-pppd/ppp/ccp_mppe.c:286]: (style) Clarify calculation precedence for '&' and '?'. [drivers/ipoe/ipoe.c:307]: (style) Clarify calculation precedence for '&' and '?'. * Fix void calculations [accel-pppd/ctrl/pppoe/disc.c:211]: (portability) 'pkt' is of type 'void *'. When using void pointers in calculations, the behaviour is undefined. [accel-pppd/ctrl/pptp/pptp.c:150]: (portability) 'buf' is of type 'void *'. When using void pointers in calculations, the behaviour is undefined. [accel-pppd/radius/acct.c:37]: (portability) 'req.pack.buf' is of type 'void *'. When using void pointers in calculations, the behaviour is undefined. [accel-pppd/radius/auth.c:35]: (portability) 'req.pack.buf' is of type 'void *'. When using void pointers in calculations, the behaviour is undefined. [accel-pppd/radius/auth.c:79]: (portability) 'req.pack.buf' is of type 'void *'. When using void pointers in calculations, the behaviour is undefined. [accel-pppd/radius/dm_coa.c:43]: (portability) 'pack.buf' is of type 'void *'. When using void pointers in calculations, the behaviour is undefined. [accel-pppd/radius/dm_coa.c:47]: (portability) 'pack.buf' is of type 'void *'. When using void pointers in calculations, the behaviour is undefined. [accel-pppd/radius/dm_coa.c:57]: (portability) 'pack.buf' is of type 'void *'. When using void pointers in calculations, the behaviour is undefined. [accel-pppd/radius/dm_coa.c:65]: (portability) 'req.buf' is of type 'void *'. When using void pointers in calculations, the behaviour is undefined. [accel-pppd/radius/dm_coa.c:97]: (portability) 'req.buf' is of type 'void *'. When using void pointers in calculations, the behaviour is undefined. [accel-pppd/radius/serv.c:364]: (portability) 'req.pack.buf' is of type 'void *'. When using void pointers in calculations, the behaviour is undefined. [accel-pppd/triton/mempool.c:115]: (portability) 'mmap_ptr' is of type 'void *'. When using void pointers in calculations, the behaviour is undefined. [accel-pppd/triton/mempool.c:122]: (portability) 'mmap_ptr' is of type 'void *'. When using void pointers in calculations, the behaviour is undefined. [accel-pppd/triton/mempool.c:276]: (portability) 'ptr' is of type 'void *'. When using void pointers in calculations, the behaviour is undefined. * Fix void part 2 [accel-pppd/ipv6/dhcpv6.c:844]: (portability) 'conf_dnssl' is of type 'void *'. When using void pointers in calculations, the behaviour is undefined. [accel-pppd/ipv6/nd.c:199]: (portability) '(void*)dnsslinfo' is of type 'void *'. When using void pointers in calculations, the behaviour is undefined. [accel-pppd/ipv6/nd.c:432]: (portability) 'conf_dnssl' is of type 'void *'. When using void pointers in calculations, the behaviour is undefined. * Fix null pointer dereference [accel-pppd/ctrl/ipoe/ipoe.c:2048]: (warning) Possible null pointer dereference: eth [accel-pppd/ctrl/ipoe/ipoe.c:2049]: (warning) Possible null pointer dereference: iph * Remove redundant check /opt/pvs/accel-ppp/accel-pppd/ctrl/l2tp/packet.c 656 warn V547 Expression 'attr->length <= 16' is always false. * PR fixes * PR fixes 2
2020-01-28ipoe_mod: set type of IPOE_ATTR_HWADDR to NLA_BINARYDmitry Kozlov
2019-12-24ipoe,vlan_mon: add support for kernels 5.2+Dmitry Kozlov
2018-03-20ipoe_mod: fixed ipv6 from non-shared mode (v2)Dmitry Kozlov
2018-03-20Merge branch 'master' of https://github.com/xebd/accel-pppDmitry Kozlov
2018-03-20Compiling fix for 4.15+ kernelsDenys Fedoryshchenko
2018-03-19ipoe_mod: fixed ipv6 from non-shared modeDmitry Kozlov
2018-03-14ipoe_mod: accept ipv6 packets from link-local address if session does not existsDmitry Kozlov
2018-01-06ipoe_mod: use least byte of hwaddr as hash keyDmitry Kozlov
2018-01-05ipoe: implemented ipv6 in shared modeDmitry Kozlov
2017-12-27ipoe,vlan_mon: updated up to kernel 4.14Dmitry Kozlov
2017-12-15ipoe: rename HASH_BITS -> IPOE_HASH_BITSDmitry Kozlov
2017-12-15ipoe,vlan_mon: define RHEL_MAJOR=0 if not setDmitry Kozlov
2017-12-15ipoe, vlan_mon: implemented support for centos 3.10 kernelDmitry Kozlov
2016-12-08ipoe: fixed nat supportDmitry Kozlov
2016-11-29ipoe: apply offer-delay rules to arp initiated sessionsDmitry Kozlov
2016-04-05ipoe_mod: code simplificationDmitry Kozlov
2016-04-04ipoe_mod: restored ip-mac binding functionDmitry Kozlov
2016-04-02ipoe_mod: ignore 0.0.0.0 and 255.255.255.255 addressesDmitry Kozlov
2016-03-29ipoe_mod: do not redirect arp requests to virtual ipoe interfacesDmitry Kozlov
2016-03-19ipoe: send arp reply for sessions started by arp requestDmitry Kozlov
2016-03-19ipoe: bug fixDmitry Kozlov
2016-03-18ipoe: implemented starting UP session by arp requestDmitry Kozlov
2016-03-18ipoe: restored local-net functionDmitry Kozlov
local-net is used to filter incomming packets which may start UP session
2016-03-17ipoe_mod: fix possible panicDmitry Kozlov
2016-03-14ipoe: bug fixesDmitry Kozlov
2016-03-14ipoe_mod: do not set skb->tc_verdDmitry Kozlov
2016-03-13ipoe: many many changesDmitry Kozlov
2016-03-10ipoe_mod: support for 4.4 kernelDmitry Kozlov
2016-03-10ipoe_mod: partially revert 14780ff57d994a324de6e7de888381358ec7238fDmitry Kozlov
Virtual ipoe interfaces can not be used to attach wide routes, only routes behind client ip (gateway)
2016-03-09ipoe_mod: improved session lookup procudureDmitry Kozlov
Makes possible to attach routes to virtual ipoe interfaces
2015-12-04Merge branch 'vlanmon'Dmitry Kozlov
2015-12-041.10.0 releaseDmitry Kozlov
* ipoe: fixed mask calculation from ipaddr radius attribute * ipoe: fixed authentication with chap-secrets * ipoe: set Calling-Station-Id to client mac address for UP sessions * ipoe: introduced idle-timeout and session-timeout options * ipoe: for option password implemented special value csid * ipoe: change l4-redirect-ipset/l4-redirect-table by CoA * ipoe: don't block lua script if it raises error * ipoe: implemented soft session termination * ipoe: implemneted passing DHCP Option 82 to Radius as two separated attributes * ipoe: changed behavior of agent-remote-id option * ipoe: introduced option check-mac-change * ipoe: disabled udp checksum validation * ipoe: introduced 'calling-sid' option * ipoe: send client IP address in Framed-IP-Address for UP sessions * ipoe: implemented username=ifname for UP sessions * ipoe: use single socket for arp processing * ipoe: implemented dhcp option 58 * ipoe: for vlan name pattern implemented %P argument - VID of parent interface * ipoe: implemented ability to use lua to make vlan name * ipoe: show sessions: intoduced new field ipoe-type to display type of session (up or dhcp) * ipoe: implemented interface renaming by NAS-Port-Id * pppoe: use single discovery socket * pppoe: check for tag length in print_packet function (fixes sigsegv) * ppp: fixed send double ConfAck when LCP is started * ppp: fix mtu/mru set if not negotiated on any end plus cleanup * ppp: set mtu and mru after unit creation * ppp: create ppp units after authentication * ppp: set unit index from NAS_Port attribute if present * cli: show sesisons: introduced rx-bytes,rx-pkts,tx-bytes,tx-pkts fields * cli: show sesisons: introduced rx-bytes-raw,tx-bytes-raw fields * session: implemented idle and timeout timers * radius: override session's idle and timeout timers values by Idle-Timeout and Session-Timeout attributes * shaper: fixed parsing ecn/noecn for fq_codel * replace mktemp with mkstemp * properly handle Cisco-AVPair * consider only rx interface counter for idle timeout calculation * net-snmp: export interface counters in the sessionTable
2015-11-21split ipoe driver to ipoe and vlan_monDmitry Kozlov
introduced new module "vlan-mon"
2015-07-08ipoe: fixed compilation for < 4.1 kernelsDmitry Kozlov
2015-07-08ipoe: support for kernels up to 4.1Dmitry Kozlov
2015-04-19ipoe: remove NETIF_F_HW_VLAN_CTAG_FILTER from virtual device features (fixed ↵Dmitry Kozlov
warn in register_netdevice) (v2)
2015-04-18ipoe: remove NETIF_F_HW_VLAN_CTAG_FILTER from virtual device features (fixed ↵Dmitry Kozlov
warn in register_netdevice)
2015-04-18ipoe: fixed compiling driver for 3.10 kernelDmitry Kozlov
2015-03-14ipoe: fix compiling module for ubuntu kernelsDmitry Kozlov
2015-02-27ipoe: driver: wrap vla_add_vid by rtnl_lock/rtnl_unlockDmitry Kozlov
2014-12-091.9.0 release1.9Dmitry Kozlov
* radius: major improvments * radius: use NAS-Port-Id in Access-Accept for interface renaming * radius: introduced "weight" and "backup" per-server options * radius: introduced "attr-tunnel-type" option * radius: introduced "max-fail" option * ipoe: introduced "ip-unnumbered" option * ipoe: improved vlan monitor * ipoe: introduced "attr-dhcp-lease-time" option * ipoe: send option 82 from DHCP request to radius * ipoe: fixed passing packets in 'redirect on reject' mode * ipoe: implemented handling relayed DHCP clients * ipoe: implemented "L4 redirect on reject" for DHCP sessions * ipoe: implemneted ability to send L4 redirect table/L4 redirect ipset via radius attributes * pppoe: introduced "called-sid" option * pppoe: improved AC-Cookie mechanism * ippool: introduced "shuffle" option * core: improved "single-session=replace" handling * shaper: apply rate multiplier to integer values * shaper: implemented fq_codel leaf qdisc * shaper: fixed passing quantum parameter to kernel * shaper: introduced "moderate-quantum" option * shaper: introduced "fwmark" option * ipv6: add support for prefixes greater than 64 * ppp: make LCP magic number negotiation not mandatory * ppp: implement address/control and protocol field compression * ppp: implemented delayed unit close via unit cache * pppd_compat: pass IPV6_PREFIX and IPV6_DELEGATED_PREFIX to ip-up/ip-down scripts * cli: introduced verbose option
2014-12-09ipoe: support for kernels 3.16-3.18Dmitry Kozlov
2014-11-22remove trailing whitespacesDmitry Kozlov
generated by cgit v1.2.3 (git 2.39.1) at 2025-02-25 04:28:24 +0000