From 9015abafb60f950a6b1a800f84cbf569b07828a1 Mon Sep 17 00:00:00 2001
From: Denys Fedoryshchenko <denys.f@collabora.com>
Date: Sat, 8 Aug 2026 19:12:49 +0300
Subject: ipoe: include net/rtnetlink.h, insert modules in ci even after a
 failure

rtnl_link_register() and struct rtnl_link_ops were reaching the driver
through some other header rather than through net/rtnetlink.h, which is
the kind of thing that only shows up when building against a different
kernel. Include it directly.

The workflows insert the kernel modules between two pytest runs, and the
runs that follow are marked 'if: always()' while the insmod steps are
not. A failure in an earlier, unrelated test therefore skips the insmod
but still runs the tests that need the module, which then report a
missing driver instead of the original problem. Mark the insmod steps
'if: always()' as well, so that the later runs test what they are
supposed to.
---
 .github/workflows/run-tests.yml | 6 ++++++
 1 file changed, 6 insertions(+)

(limited to '.github')

diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml
index 9cd47a00..10f238cc 100644
--- a/.github/workflows/run-tests.yml
+++ b/.github/workflows/run-tests.yml
@@ -145,6 +145,7 @@ jobs:
           sudo dmesg"
 
       - name: Insert ipoe kernel module
+        if: ${{ always() }}
         run: >
           ssh -i ssh-key -p2222 user@localhost "cd accel-ppp &&
           sudo insmod build/drivers/ipoe/driver/ipoe.ko &&
@@ -163,12 +164,14 @@ jobs:
           sudo dmesg"
 
       - name: Insert vlan_mon kernel module
+        if: ${{ always() }}
         run: >
           ssh -i ssh-key -p2222 user@localhost "cd accel-ppp &&
           sudo insmod build/drivers/vlan_mon/driver/vlan_mon.ko &&
           lsmod | grep vlan_mon"
 
       - name: Insert ppposeq kernel module
+        if: ${{ always() }}
         run: >
           ssh -i ssh-key -p2222 user@localhost "cd accel-ppp &&
           sudo modprobe pppox && sudo insmod build/drivers/ppposeq/driver/ppposeq.ko &&
@@ -290,6 +293,7 @@ jobs:
           doas dmesg"
 
       - name: Insert ipoe kernel module
+        if: ${{ always() }}
         run: >
           ssh -i ssh-key -p2222 alpine@localhost "cd accel-ppp &&
           doas insmod build/drivers/ipoe/driver/ipoe.ko &&
@@ -308,12 +312,14 @@ jobs:
           doas dmesg"
 
       - name: Insert vlan_mon kernel module
+        if: ${{ always() }}
         run: >
           ssh -i ssh-key -p2222 alpine@localhost "cd accel-ppp &&
           doas insmod build/drivers/vlan_mon/driver/vlan_mon.ko &&
           lsmod | grep vlan_mon"
 
       - name: Insert ppposeq kernel module
+        if: ${{ always() }}
         run: >
           ssh -i ssh-key -p2222 alpine@localhost "cd accel-ppp &&
           doas modprobe pppox && doas insmod build/drivers/ppposeq/driver/ppposeq.ko &&
-- 
cgit v1.2.3