From 2e1caa1445b51000bc3695b0f55753f533468839 Mon Sep 17 00:00:00 2001 From: Guillaume Nault Date: Wed, 13 Feb 2013 13:48:42 +0100 Subject: l2tp: Fix challenge response with no secret Don't call strlen() if conf_secret is NULL. Signed-off-by: Guillaume Nault --- accel-pppd/ctrl/l2tp/l2tp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/accel-pppd/ctrl/l2tp/l2tp.c b/accel-pppd/ctrl/l2tp/l2tp.c index 4b3e7425..7e990d02 100644 --- a/accel-pppd/ctrl/l2tp/l2tp.c +++ b/accel-pppd/ctrl/l2tp/l2tp.c @@ -326,7 +326,7 @@ static int l2tp_tunnel_genchallresp(uint8_t msgident, uint8_t challresp[MD5_DIGEST_LENGTH]; if (conn->challenge == NULL) { - if (conf_secret || strlen(conf_secret) > 0) { + if (conf_secret && strlen(conf_secret) > 0) { l2tp_conn_log(log_warn, conn); log_warn("l2tp: No Challenge sent by peer\n"); } -- cgit v1.2.3