From f8dfbeca348d9f4eb794cdf3756a94f2d0acc730 Mon Sep 17 00:00:00 2001 From: Denys Fedoryshchenko Date: Fri, 29 May 2026 08:58:41 +0300 Subject: Rejecting any PADR lacking a Service-Name tag (RFC 2516 compliance) Signed-off-by: Denys Fedoryshchenko --- accel-pppd/ctrl/pppoe/pppoe.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/accel-pppd/ctrl/pppoe/pppoe.c b/accel-pppd/ctrl/pppoe/pppoe.c index 93824af5..d543a129 100644 --- a/accel-pppd/ctrl/pppoe/pppoe.c +++ b/accel-pppd/ctrl/pppoe/pppoe.c @@ -1234,6 +1234,12 @@ padr_tags_done: return; } + if (!service_name_tag) { + if (conf_verbose) + log_warn("pppoe: discard PADR packet (no Service-Name tag present)\n"); + return; + } + if (ntohs(ac_cookie_tag->tag_len) != COOKIE_LENGTH) { if (conf_verbose) log_warn("pppoe: discard PADR packet (incorrect AC-Cookie tag length)\n"); -- cgit v1.2.3