From cc796b92272d5ce9c90da2021d877e2e4d7e6a4b Mon Sep 17 00:00:00 2001 From: François Cachereul Date: Wed, 29 Oct 2014 09:30:36 +0100 Subject: ppp: improve establish_ppp() exit on error MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: François Cachereul Signed-off-by: Guillaume Nault Signed-off-by: Dmitry Kozlov --- accel-pppd/ppp/ppp.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'accel-pppd/ppp/ppp.c') diff --git a/accel-pppd/ppp/ppp.c b/accel-pppd/ppp/ppp.c index 7113673..9772b84 100644 --- a/accel-pppd/ppp/ppp.c +++ b/accel-pppd/ppp/ppp.c @@ -166,7 +166,7 @@ int __export establish_ppp(struct ppp_t *ppp) log_ppp_debug("ppp established\n"); if (ap_session_starting(&ppp->ses)) - goto exit_close_unit; + goto exit_free_buf; triton_md_register_handler(ppp->ses.ctrl->ctx, &ppp->chan_hnd); triton_md_register_handler(ppp->ses.ctrl->ctx, &ppp->unit_hnd); @@ -178,14 +178,14 @@ int __export establish_ppp(struct ppp_t *ppp) return 0; +exit_free_buf: + mempool_free(ppp->buf); + ppp->buf = NULL; exit_close_unit: close(ppp->unit_fd); exit_close_chan: close(ppp->chan_fd); - if (ppp->buf) - mempool_free(ppp->buf); - return -1; } -- cgit v1.2.3