accel-ppp.git/accel-pppd/cli, branch 1.11

cli: introduced ip6 and ip6-dp fields in "show sessions" command

2017-09-26T08:58:41+00:00

accel-ppp Debian x32 fix minor -Wformat warnings

2016-05-31T09:38:21+00:00

Hello, small patch to avoid gcc -Wformat warnings on Debian x32 where time_t is "long long" (64-bit signed, to be 2038 safe), not "unsigned long" (32-bit unsigned) corresponding to "%lu" format strings. Regards, Marek

cli: flush pending data before disconnecting

2016-04-28T08:17:16+00:00

The telnet and tcp servers disconnect as soon as they receive the 'exit' command or see a disconnection from the client. In this case, all data queued for transmission are lost. This can lead to truncated output when big amount of data is being sent. For example, on a moderately loaded server with a few thouthands connections, the output of the 'accel-cmd show sessions' command can be truncated. The problem is that accel-cmd sends the 'show sessions' command, followed by 'exit'. It does so because it has to stop running once all data has been received from the server. But it never knows whether more data are going to arrive. Disconnection must then come from the server, hence the use of 'exit' (although the same effect could be achieved with shutdown(SHUT_WR)). The telnet and tcp modules behave very similarly and are modified in the same way: * For a soft disconnection, cln_read() doesn't call disconnect() anymore if there are data queued for transmission. Instead it sets the 'disconnect' flag and stops listening to its peer (no need to process further messages). * cln_write() checks the 'disconnect' flag once it has sent all pending data and actually performs the disconnection if necessary. Signed-off-by: Guillaume Nault

cli: fix data output miss-ordering

2016-04-28T08:16:47+00:00

In tcp and telnet backends, the first buffer been queued is directly pointed to by cln->xmit_buf. It's not added to cln->xmit_queue. Therefore testing if ->xmit_queue is empty doesn't reliably tells if data has already been queued. We should test if ->xmit_buf is non-NULL instead. This is reliable because ->xmit_buf is re-filled with the first buffer from ->xmit_queue after every successful write(). Failure to properly check if data has already been queued can lead to message miss-ordering because cli_client_send() or telnet_send() will try to directly write() their input buffer, effectively bypassing the one previously queued up in ->xmit_buf. Signed-off-by: Guillaume Nault

cli: fix partial line duplication and truncation

2016-04-28T08:16:05+00:00

When queueing output data for later write(), the 'n' first bytes of the buffer have already been sent (we have n > 0 if EAGAIN was returned after some other write() calls succeeded). Therefore, we need to skip these bytes when initialising the buffer to be queued. The size passed to memcpy() did already take that space into account. Signed-off-by: Guillaume Nault

improved restart and termination procedure

2016-03-18T16:37:19+00:00

make termination caused by SIGTERM soft

2016-03-18T10:40:07+00:00

cli: show sesisons: introduced rx-bytes-raw,tx-bytes-raw fields

2015-11-30T11:06:07+00:00

cli: show sesisons: introduced rx-bytes,rx-pkts,tx-bytes,tx-pkts fields

2015-11-30T10:14:24+00:00

remove trailing whitespaces

2014-11-22T05:56:40+00:00