Age | Commit message (Collapse) | Author |
|
|
|
CLI: PPPoE: Add possibility to display inbound interface and service-…
|
|
ipoe: fix memory access violation with unset link-selection
|
|
show sessions command
|
|
libnetlink: fix a crash with a non vlan interface
|
|
When accel-ppp has no connected clients, CLI interface add command it try to use net == NULL and crush code.
|
|
Link-selection pointer is not set to NULL when link-selection IPOE
option is not set. It results in a memory access violation in
dhcpv4_packet_insert_opt82()
Set link-selection pointer to NULL if unset to fix the issue.
Fixes: 61e31c591e ("ipoe: add dhcp link selection sub-option")
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
|
|
Fix a segmentation fault when starting when accel-ppp is configured with
an non vlan interface.
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
|
|
Add support of Link Selection DHCP sub-option RFC3527
|
|
Use real version instad of "gitgitgit"
|
|
We set fake variables so recipe doesn't fail.
It is a bit of hack for such situation, but makes development easier.
Signed-off-by: Denys Fedoryshchenko <denys.f@collabora.com>
|
|
Add information about link-selection ipoe option in accel-ppp.conf man.
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
|
|
DHCP "agent remote id" sub-option 2 of option 82 can already be
configured with [ipoe] / "agent-remote-id". However, it is not
documented.
Add information about agent-remote-id in accel-ppp.conf man.
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
|
|
Add the support of DHCP option 82 "Agent Information" sub-option 5
"link selection". The IPv4 value can be specified in the [ipoe]
"link-selection" configuration option.
Link: https://www.rfc-editor.org/rfc/rfc3527.html
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
|
|
Patially fixes 6e5f9980a8a71015a228279e07970621d23c7b35, there's
no really requirement for packed internal sockaddr_t struct.
Also, constantify several struct pointer arguments as well.
|
|
There's no alignment reason for making temporary vars on
stack assuming unaligned block copy.
|
|
Fixes ad94c19554d7c6bb18ab2e251e4ee403ee0b7732, tios is sill left
partially initialized with sane values. Also, log get/set attr errors
with error level as well since it raises pty allocation error and
connection drop therefore.
|
|
ci: remove Ubuntu 18.04 from CI pipelines, fix python issue for Debian12
|
|
Signed-off-by: Sergey V. Lobanov <sergey@lobanov.in>
|
|
Ubuntu 18.04 is EOL so CI support is not necessary anymore
Signed-off-by: Sergey V. Lobanov <sergey@lobanov.in>
|
|
|
|
Co-authored-by: Martin Zaharinov <micron@bngsoft.net>
|
|
Add support for building RPMs on RHEL 9 clones
|
|
|
|
|
|
Use 64-bit interface statistics and some more env parameters for pppd-compat
|
|
T72: Fix compilations warnings for unaligned variable access
|
|
As per the docs:
The openpty() function finds an available pseudoterminal and
returns file descriptors for the master and slave in amaster and
aslave. [...] If termp is not NULL, the terminal parameters
of the slave will be set to the values in termp. [...]
So openpty() would set the pty parameters to something undefined.
This undefinedness will be fixed by the later tcsetattr() call.
As a result, we don't need that parameter in the first place.
Additionally, fixes a -Wmaybe-uninitialized warning.
|
|
|
|
|
|
handling.
When a link has a relatively high throughput, the 32-bit packet and byte counters could overflow multiple times between accounting runs.
To accommodate this limitation, directly use 64-bit interface statistics.
This also gets rid of the internal giga-word counters.
|
|
This includes CentOS Stream, AlmaLinux, and RockyLinux.
|
|
Add missing dhcp end option on dhcp notify packet
|
|
- IPoE/DHCP4: Specify minimal suitable alignment explicitly.
We need to guarantee 2 byte alignment for the `hdr` pointer in
`ip_csum(uint16_t *buf)` calculation
- PPPOE: Suppress false-positive warning for `sockaddr_pppox`.
Similiar issue: https://github.com/kernelslacker/trinity/pull/40
- Introduce tmp variables to avoid alignment issues for SSTP/DHCPv6
For additional details:
https://phabricator.accel-ppp.org/T72
Signed-off-by: Volodymyr Huti <v.huti@vyos.io>
|
|
Add liblua dependency for DEB packages
|
|
|
|
add tests and ci workflow for running tests
|
|
ci: add build jobs (Github CI)
|
|
|
|
This commit adds tests (using python3 pytest framework):
1. Test basic accel-cmd commands (show version, show stat, etc)
2. Test ipoe shared session up (dhcpv4) without radius
3. Test pppoe discovery (without PADO delay)
4. Test pppoe discovery (without PADO delay)
5. Test pppoe session up (ipv4) without radius
6. Test vlan creation using vlan-mon (pppoe)
These tests require external utils. Please read tests/README.md how to setup
environment, how to run the tests and how to generate coverage report
Also, run-tests.yml contains step-by-step instruction how to run the tests
Signed-off-by: Sergey V. Lobanov <sergey@lobanov.in>
|
|
Added build on:
1. Ubuntu 20.04, 22.04 (github runners)
2. Ubuntu 18.04, 20.04, 22.04 (in official containers from dockerhub)
3. Debian 10, 11, 12 (in official containers from dockerub)
Build jobs do:
1. Build (cmake, make)
2. Packaging (cpack)
3. Install
4. Run
5. Check using 'show stat' command
6. Upload built .deb package as artifact
Signed-off-by: Sergey V. Lobanov <sergey@lobanov.in>
|
|
Signed-off-by: Sergey V. Lobanov <sergey@lobanov.in>
|
|
accel-cmd: add macos compatibility
|
|
MacOS socket does not support SOCK_CLOEXEC. This patch uses fcntl
with FD_CLOEXEC instead of using SOCK_CLOEXEC in socket() call
Signed-off-by: Sergey V. Lobanov <sergey@lobanov.in>
|
|
sstp: T69: Add timer befor context wakeup to preevent segfault
|
|
|
|
Fix ipv6 inside netns
|
|
This commit proposes to modify the log message in dhcpv6.c to include
the correct file name. It avoids confusion when reading the logs
|
|
T60: Implement configurable session-timeout param for all connection …
|
|
This fix allow to create the socket inside the netns for ipv6-dhcp module.
|