VyOS command definitions, scripts, and utilities (mirror of https://github.com/marekm72/vyos-1x.git) https://git.amelek.net/marekm72/vyos-1x.git/atom?h=1.4.0-epa3 2024-05-02T15:05:57+00:00 2024-05-02T15:05:57+00:00 khramshinr khramshinr@gmail.com 2024-05-02T11:45:57+00:00 urn:sha1:abc465f8ad894fda29d32b053798676e0294e20f Fix default values for random-detect Remove dsmakr qdisc from gred cofig because dsmark was deleted from kernel (cherry picked from commit 0b54c1bc411a21833ec573031cf5ad98fe709a2f) 2024-04-25T15:32:51+00:00 khramshinr khramshinr@gmail.com 2024-04-16T07:49:19+00:00 urn:sha1:8c5c3bc48f76a5bb0c819c6f549d7fbcacf964de (cherry picked from commit da40bd2b2a826986de128354ea1bfc041ada0016) 2024-04-13T11:11:07+00:00 khramshinr khramshinr@gmail.com 2024-04-12T05:32:52+00:00 urn:sha1:92f236989bc8fee0cc0170999204dc5ffc5cc1f8 Added params for configuration red on the shaper policy (cherry picked from commit 31cd75aec6d035b36537046ae0d034c03009a3fc) 2024-04-03T19:02:47+00:00 Christian Breunig christian@breunig.cc 2024-04-02T22:15:43+00:00 urn:sha1:3ea68d648581a20797b9e1b4438299a057a1820d found using "git ls-files *.py | xargs pylint | grep W0611" (cherry picked from commit 274b2da242acd1f1f64ff1dee471e34295137c5f) 2024-03-20T06:12:54+00:00 khramshinr khramshinr@gmail.com 2024-03-14T06:38:16+00:00 urn:sha1:f37cc9e15fe0ef4e3e88f5839b0fb23bb72dc7e5 add mtu to default and specified class update smoke test (cherry picked from commit 84bbcdf5b7980f701aba6e158a2be4a05e7076d9) 2024-03-04T17:27:51+00:00 Nataliia Solomko natalirs1985@gmail.com 2024-03-01T10:47:08+00:00 urn:sha1:b0a4e646b4179ac51f937f40cf865b933afb6370 (cherry picked from commit 2104424c1a43dc027567e051262e1eed6506491f) 2024-03-01T21:28:30+00:00 Nataliia Solomko natalirs1985@gmail.com 2024-03-01T15:51:31+00:00 urn:sha1:21f9892d0840974b6d54e5746feb3c572dd907bf (cherry picked from commit c7f5b510cfd117e57f2d22e259c843600ef4cc76) 2024-02-09T11:44:35+00:00 Viacheslav Hletenko v.gletenko@vyos.io 2024-02-09T10:51:00+00:00 urn:sha1:a6781cd008998200d491fbf86f6976d81323a7bd The `class_id_max` is wrong due to `tmp.sort` of Strings If we have class 5 and class 10 we get sorted max value 5, expected 10 ``` >>> tmp = ['5', '10'] >>> tmp.sort() >>> tmp ['10', '5'] >>> >>> hex(5+1) '0x6' >>> >>> hex(10+1) '0xb' >>> ``` This way we get wrong default maximum class value: ``` tc qdisc replace dev eth1 root handle 1: htb r2q 444 default 6 ``` Expect: ``` tc qdisc replace dev eth1 root handle 1: htb r2q 444 default b ``` Fix this converting Strings to Integers and get max value. (cherry picked from commit 2e8fa45c7f0663549edd118622b3381e7c428b2e) 2024-02-07T17:02:13+00:00 Viacheslav Hletenko v.gletenko@vyos.io 2024-02-07T16:34:27+00:00 urn:sha1:6c3c5389bdd3f6b9d40e53596f9f22a2a36bfee9 The current calculation `r2q` is wrong as it uses `Floor division` but expecting `division` This way `math.ceil` calculate wrong value as we expect round a number upward to its nearest integer For example for speed 710 mbits expected value `444` but we get `443` ``` from math import ceil MAXQUANTUM = 200000 speed = 710000000 speed_bps = int(speed) // 8 >>> speed_bps // MAXQUANTUM 443 >>> speed_bps / MAXQUANTUM 443.75 >>> >>> >>> ceil(speed_bps // MAXQUANTUM) 443 >>> ceil(speed_bps / MAXQUANTUM) 444 >>> ``` (cherry picked from commit ce1035e1e8642bf740e2a21693a72fe2127b8f72) 2024-02-02T12:12:02+00:00 Matthew Kobayashi matthew@kobayashi.au 2023-12-22T01:50:29+00:00 urn:sha1:628877a46a049142cffd5d98de74f652d4a9dde7 (cherry picked from commit 61342083d7db8c30d015474fae5cb71f480487d8)