vyos-1x.git/scripts, branch equuleus

scripts: T4269: node.def generator should automatically add default values

2023-10-08T08:27:27+00:00

Since introducing the XML node it was common, but redundant, practice to also add a help string indicating which value would be used as default if the node is unset. This makes no sense b/c it's duplicated code/value/characters and prone to error. The node.def scripts should be extended to automatically render the appropriate default value into the CLI help string. For e.g. SSH the current PoC renders: $ cat templates-cfg/service/ssh/port/node.def multi: type: txt help: Port for SSH service (default: 22) val_help: u32:1-65535; Numeric IP port ... Not all subsystems are already migrated to get_config_dict() and make use of the defaults() call - those subsystems need to be migrated, first before the new default is added to the CLI help. (cherry picked from commit a68c9238111c6caee78bb28f8054b8f0cfa0e374)

scripts: op-mode: T3807: bugfix node.def generator

2021-09-07T09:48:28+00:00

process_node() processes the XML tree in a fixed order, "node" before "tagNode" before "leafNode". If the generator created a "node.def" file, it can no longer be overwritten - else we would have some stale "node.def" files with an empty help string (T2555). Without the fixed order this would resulted in a case where we get a node and a tagNode with the same name, e.g. "show interfaces ethernet" and "show interfaces ethernet eth0" that the node implementation was not callable from the CLI, rendering this command useless (T3807). This can be fixed by forcing the "node", "tagNode", "leafNode" order by sorting the input XML file automatically (sorting from https://stackoverflow.com/a/46128043) thus adding no additional overhead to the user. (cherry picked from commit 7623e37c918c65418d8dfc521f976bb91f0594c0)

T3165: op-mode: prevent override of populated node.def file with empty content

2021-08-23T07:03:19+00:00

This is an extension to commit b4fdcebe ("T3165: prevent override of populated node.def file with empty content") which implemented the same thing for the configuration mode commands. (cherry picked from commit 17b5ac143c9128ac3e187d8d8167dd8fe6cbca7d)

scripts: op-mode: use Python 'f'ormat strings on debug messages

2021-08-23T07:03:13+00:00

(cherry picked from commit 252bc820b0d130d8d81b5711586eca41287abdca)

T3768: Revert "xml: T1962: Add syntaxVersion to schema"

2021-08-19T20:00:22+00:00

This reverts commit 5849ba88a1a20e4d3584843e0be46e456c5f7980.

T3768: Revert "xml: T1962: Add script to process syntaxVersion tags during build"

2021-08-19T19:59:04+00:00

This reverts commit 0ecc2c26f7ac939e4e23c14f5027ac7592c25761.

T3574: add constraintGroup for combining validators with logical AND

2021-08-12T16:09:58+00:00

(cherry picked from commit 591b8bcadd8b6bbd46c61484193d2bf7e16bd1ae commit 31553283aaa929da63147082e85513e8d4dacf0e commit 59a4aadfe419eca16e6288b37d6c51acd9789903)

xml: T3732: merge leafNode with defaultValue with leafNode(s) of same path

2021-08-12T15:19:39+00:00

(cherry picked from commit e7c69ead85af485b2b881f24b929a4bcc779a4ce and commit ec6dc94a5144ea4ac75ba6fac4d85b4f66337ae2)

T3165: prevent override of populated node.def file with empty content

2021-06-08T05:54:32+00:00

(cherry picked from commit b4fdcebebecd8d8952211b78bce26d53fd29edb3)

xml: T3445: avoid false positive on element references; use path name

2021-03-31T17:03:05+00:00

(cherry picked from commit f22fa8e6454b1cd2539ddb7c354ac9eeeac725c5)