Merge branch 'equuleus' of https://github.com/vyos/vyos-1x into equuleus

13 files changed, 608 insertions, 39 deletions

diff --git a/data/templates/router-advert/radvd.conf.tmpl b/data/templates/router-advert/radvd.conf.tmpl
index 9cc237512..88d066491 100644
--- a/data/templates/router-advert/radvd.conf.tmpl
+++ b/data/templates/router-advert/radvd.conf.tmpl
@@ -1,58 +1,64 @@
 ### Autogenerated by service_router-advert.py ###
 
 {% if interface is defined and interface is not none %}
-{%   for iface in interface %}
+{%   for iface, iface_config in interface.items() %}
 interface {{ iface }} {
     IgnoreIfMissing on;
-{%     if interface[iface].default_preference is defined and interface[iface].default_preference is not none %}
-    AdvDefaultPreference {{ interface[iface].default_preference }};
+{%     if iface_config.default_preference is defined and iface_config.default_preference is not none %}
+    AdvDefaultPreference {{ iface_config.default_preference }};
 {%     endif %}
-{%     if interface[iface].managed_flag is defined and interface[iface].managed_flag is not none %}
-    AdvManagedFlag {{ 'on' if interface[iface].managed_flag is defined else 'off' }};
+{%     if iface_config.managed_flag is defined and iface_config.managed_flag is not none %}
+    AdvManagedFlag {{ 'on' if iface_config.managed_flag is defined else 'off' }};
 {%     endif %}
-{%     if interface[iface].interval.max is defined and interface[iface].interval.max is not none %}
-    MaxRtrAdvInterval {{ interface[iface].interval.max }};
+{%     if iface_config.interval.max is defined and iface_config.interval.max is not none %}
+    MaxRtrAdvInterval {{ iface_config.interval.max }};
 {%     endif %}
-{%     if interface[iface].interval.min is defined and interface[iface].interval.min is not none %}
-    MinRtrAdvInterval {{ interface[iface].interval.min }};
+{%     if iface_config.interval.min is defined and iface_config.interval.min is not none %}
+    MinRtrAdvInterval {{ iface_config.interval.min }};
 {%   endif %}
-{%     if interface[iface].reachable_time is defined and interface[iface].reachable_time is not none %}
-    AdvReachableTime {{ interface[iface].reachable_time }};
+{%     if iface_config.reachable_time is defined and iface_config.reachable_time is not none %}
+    AdvReachableTime {{ iface_config.reachable_time }};
 {%   endif %}
-    AdvIntervalOpt {{ 'off' if interface[iface].no_send_advert is defined else 'on' }};
-    AdvSendAdvert {{ 'off' if interface[iface].no_send_advert is defined else 'on' }};
-{%     if interface[iface].default_lifetime is defined %}
-    AdvDefaultLifetime {{ interface[iface].default_lifetime }};
-{%     endif %}
-{%     if interface[iface].link_mtu is defined %}
-    AdvLinkMTU {{ interface[iface].link_mtu }};
-{%     endif %}
-    AdvOtherConfigFlag {{ 'on' if interface[iface].other_config_flag is defined else 'off' }};
-    AdvRetransTimer {{ interface[iface].retrans_timer }};
-    AdvCurHopLimit {{ interface[iface].hop_limit }};
-{%     if interface[iface].route is defined %}
-{%       for route in interface[iface].route %}
+    AdvIntervalOpt {{ 'off' if iface_config.no_send_advert is defined else 'on' }};
+    AdvSendAdvert {{ 'off' if iface_config.no_send_advert is defined else 'on' }};
+{%     if iface_config.default_lifetime is defined %}
+    AdvDefaultLifetime {{ iface_config.default_lifetime }};
+{%     endif %}
+{%     if iface_config.link_mtu is defined %}
+    AdvLinkMTU {{ iface_config.link_mtu }};
+{%     endif %}
+    AdvOtherConfigFlag {{ 'on' if iface_config.other_config_flag is defined else 'off' }};
+    AdvRetransTimer {{ iface_config.retrans_timer }};
+    AdvCurHopLimit {{ iface_config.hop_limit }};
+{%     if iface_config.route is defined %}
+{%       for route, route_options in iface_config.route.items() %}
     route {{ route }} {
-{%         if interface[iface].route[route].valid_lifetime is defined %}
-        AdvRouteLifetime {{ interface[iface].route[route].valid_lifetime }};
+{%         if route_options.valid_lifetime is defined %}
+        AdvRouteLifetime {{ route_options.valid_lifetime }};
 {%         endif %}
-{%         if interface[iface].route[route].route_preference is defined %}
-        AdvRoutePreference {{ interface[iface].route[route].route_preference }};
+{%         if route_options.route_preference is defined %}
+        AdvRoutePreference {{ route_options.route_preference }};
 {%         endif %}
-        RemoveRoute {{ 'off' if interface[iface].route[route].no_remove_route is defined else 'on' }};
+        RemoveRoute {{ 'off' if route_options.no_remove_route is defined else 'on' }};
     };
 {%       endfor %}
 {%     endif %}
-{%     for prefix in interface[iface].prefix %}
+{%     if iface_config.prefix is defined and iface_config.prefix is not none %}
+{%       for prefix, prefix_options in iface_config.prefix.items() %}
     prefix {{ prefix }} {
-        AdvAutonomous {{ 'off' if interface[iface].prefix[prefix].no_autonomous_flag is defined else 'on' }};
-        AdvValidLifetime {{ interface[iface].prefix[prefix].valid_lifetime }};
-        AdvOnLink {{ 'off' if interface[iface].prefix[prefix].no_on_link_flag is defined else 'on' }};
-        AdvPreferredLifetime {{ interface[iface].prefix[prefix].preferred_lifetime }};
+        AdvAutonomous {{ 'off' if prefix_options.no_autonomous_flag is defined else 'on' }};
+        AdvValidLifetime {{ prefix_options.valid_lifetime }};
+        AdvOnLink {{ 'off' if prefix_options.no_on_link_flag is defined else 'on' }};
+        AdvPreferredLifetime {{ prefix_options.preferred_lifetime }};
+    };
+{%       endfor %}
+{%     endif %}
+{%     if iface_config.name_server is defined %}
+    RDNSS {{ iface_config.name_server | join(" ") }} {
     };
-{%     endfor %}
-{%     if interface[iface].name_server is defined %}
-    RDNSS {{ interface[iface].name_server | join(" ") }} {
+{%     endif %}
+{%     if iface_config.dnssl is defined %}
+    DNSSL {{ iface_config.dnssl | join(" ") }} {
     };
 {%     endif %}
 };
diff --git a/op-mode-definitions/include/bgp/afi-common.xml.i b/op-mode-definitions/include/bgp/afi-common.xml.i
new file mode 100644
index 000000000..7fc59f3b0
--- /dev/null
+++ b/op-mode-definitions/include/bgp/afi-common.xml.i
@@ -0,0 +1,55 @@
+<!-- included start from bgp/afi-common.xml.i -->
+<tagNode name="community">
+  <properties>
+    <help>Community number where AA and NN are (0-65535)</help>
+    <completionHelp>
+      <list>AA:NN</list>
+    </completionHelp>
+  </properties>
+  <children>
+    <leafNode name="exact-match">
+      <properties>
+        <help>Exact match of the communities</help>
+      </properties>
+      <command>${vyos_op_scripts_dir}/vtysh_wrapper.sh $@</command>
+    </leafNode>
+  </children>
+  <command>${vyos_op_scripts_dir}/vtysh_wrapper.sh $@</command>
+</tagNode>
+<tagNode name="large-community">
+  <properties>
+    <help>List of large-community numbers</help>
+    <completionHelp>
+      <list>AA:BB:CC</list>
+    </completionHelp>
+  </properties>
+  <command>${vyos_op_scripts_dir}/vtysh_wrapper.sh $@</command>
+</tagNode>
+<leafNode name="statistics">
+  <properties>
+    <help>RIB advertisement statistics</help>
+  </properties>
+  <command>${vyos_op_scripts_dir}/vtysh_wrapper.sh $@</command>
+</leafNode>
+<node name="summary">
+  <properties>
+    <help>Summary of BGP neighbor status</help>
+  </properties>
+  <command>${vyos_op_scripts_dir}/vtysh_wrapper.sh $@</command>
+  <children>
+    <leafNode name="established">
+      <properties>
+        <help>Show only sessions in Established state</help>
+      </properties>
+      <command>${vyos_op_scripts_dir}/vtysh_wrapper.sh $@</command>
+    </leafNode>
+    <leafNode name="failed">
+      <properties>
+        <help>Show only sessions not in Established state</help>
+      </properties>
+      <command>${vyos_op_scripts_dir}/vtysh_wrapper.sh $@</command>
+    </leafNode>
+  </children>
+</node>
+#include <include/vtysh-generic-wide.xml.i>
+<!-- included end -->
diff --git a/op-mode-definitions/include/bgp/afi-ipv4-ipv6-common.xml.i b/op-mode-definitions/include/bgp/afi-ipv4-ipv6-common.xml.i
new file mode 100644
index 000000000..f1b699347
--- /dev/null
+++ b/op-mode-definitions/include/bgp/afi-ipv4-ipv6-common.xml.i
@@ -0,0 +1,243 @@
+<!-- included start from bgp/afi-ipv4-ipv6-common.xml.i -->
+<node name="community">
+  <properties>
+    <help>Display routes matching the community</help>
+  </properties>
+  <children>
+    <leafNode name="accept-own">
+      <properties>
+        <help>Should accept local VPN route if exported and imported into different VRF (well-known community)</help>
+      </properties>
+      <command>${vyos_op_scripts_dir}/vtysh_wrapper.sh $@</command>
+    </leafNode>
+    <leafNode name="accept-own-nexthop">
+      <properties>
+        <help>Should accept VPN route with local nexthop (well-known community)</help>
+      </properties>
+      <command>${vyos_op_scripts_dir}/vtysh_wrapper.sh $@</command>
+    </leafNode>
+    <leafNode name="blackhole">
+      <properties>
+        <help>Inform EBGP peers to blackhole traffic to prefix (well-known community)</help>
+      </properties>
+      <command>${vyos_op_scripts_dir}/vtysh_wrapper.sh $@</command>
+    </leafNode>
+    <leafNode name="exact-match">
+      <properties>
+        <help>Exact match of the communities</help>
+      </properties>
+      <command>${vyos_op_scripts_dir}/vtysh_wrapper.sh $@</command>
+    </leafNode>
+    <leafNode name="graceful-shutdown">
+      <properties>
+        <help>Graceful shutdown (well-known community)</help>
+      </properties>
+      <command>${vyos_op_scripts_dir}/vtysh_wrapper.sh $@</command>
+    </leafNode>
+    <leafNode name="llgr-stale">
+      <properties>
+        <help>Staled Long-lived Graceful Restart VPN route (well-known community)</help>
+      </properties>
+      <command>${vyos_op_scripts_dir}/vtysh_wrapper.sh $@</command>
+    </leafNode>
+    <leafNode name="local-AS">
+      <properties>
+        <help>Do not send outside local AS (well-known community)</help>
+      </properties>
+      <command>${vyos_op_scripts_dir}/vtysh_wrapper.sh $@</command>
+    </leafNode>
+    <leafNode name="no-advertise">
+      <properties>
+        <help>Do not advertise to any peer (well-known community)</help>
+      </properties>
+      <command>${vyos_op_scripts_dir}/vtysh_wrapper.sh $@</command>
+    </leafNode>
+    <leafNode name="no-export">
+      <properties>
+        <help>Do not export to next AS (well-known community)</help>
+      </properties>
+      <command>${vyos_op_scripts_dir}/vtysh_wrapper.sh $@</command>
+    </leafNode>
+    <leafNode name="no-llgr">
+      <properties>
+        <help>Removed because Long-lived Graceful Restart was not enabled for VPN route (well-known community)</help>
+      </properties>
+      <command>${vyos_op_scripts_dir}/vtysh_wrapper.sh $@</command>
+    </leafNode>
+    <leafNode name="no-peer">
+      <properties>
+        <help>Do not export to any peer (well-known community)</help>
+      </properties>
+      <command>${vyos_op_scripts_dir}/vtysh_wrapper.sh $@</command>
+    </leafNode>
+    <leafNode name="route-filter-translated-v4">
+      <properties>
+        <help>RT translated VPNv4 route filtering (well-known community)</help>
+      </properties>
+      <command>${vyos_op_scripts_dir}/vtysh_wrapper.sh $@</command>
+    </leafNode>
+    <leafNode name="route-filter-translated-v6">
+      <properties>
+        <help>RT translated VPNv6 route filtering (well-known community)</help>
+      </properties>
+      <command>${vyos_op_scripts_dir}/vtysh_wrapper.sh $@</command>
+    </leafNode>
+    <leafNode name="route-filter-v4">
+      <properties>
+        <help>RT VPNv4 route filtering (well-known community)</help>
+      </properties>
+      <command>${vyos_op_scripts_dir}/vtysh_wrapper.sh $@</command>
+    </leafNode>
+    <leafNode name="route-filter-v6">
+      <properties>
+        <help>RT VPNv6 route filtering (well-known community)</help>
+      </properties>
+      <command>${vyos_op_scripts_dir}/vtysh_wrapper.sh $@</command>
+    </leafNode>
+  </children>
+  <command>${vyos_op_scripts_dir}/vtysh_wrapper.sh $@</command>
+</node>
+<tagNode name="community-list">
+  <properties>
+    <help>Display routes matching the community-list</help>
+    <completionHelp>
+      <list>1-500 name</list>
+    </completionHelp>
+  </properties>
+  <children>
+    <leafNode name="exact-match">
+      <properties>
+        <help>Show BGP routes exactly matching specified community list</help>
+      </properties>
+      <command>${vyos_op_scripts_dir}/vtysh_wrapper.sh $@</command>
+    </leafNode>
+  </children>
+  <command>${vyos_op_scripts_dir}/vtysh_wrapper.sh $@</command>
+</tagNode>
+<node name="dampening">
+  <properties>
+    <help>Display detailed information about dampening</help>
+  </properties>
+  <children>
+    <leafNode name="dampened-paths">
+      <properties>
+        <help>Display paths suppressed due to dampening</help>
+      </properties>
+      <command>${vyos_op_scripts_dir}/vtysh_wrapper.sh $@</command>
+    </leafNode>
+    <leafNode name="flap-statistics">
+      <properties>
+        <help>Display flap statistics of routes</help>
+      </properties>
+      <command>${vyos_op_scripts_dir}/vtysh_wrapper.sh $@</command>
+    </leafNode>
+    <leafNode name="parameters">
+      <properties>
+        <help>Display detail of configured dampening parameters</help>
+      </properties>
+      <command>${vyos_op_scripts_dir}/vtysh_wrapper.sh $@</command>
+    </leafNode>
+  </children>
+</node>
+<tagNode name="filter-list">
+  <properties>
+    <help>Display routes conforming to the filter-list</help>
+    <completionHelp>
+      <script>vtysh -c 'show bgp as-path-access-list' | grep 'AS path access list' | awk '{print $NF}'</script>
+    </completionHelp>
+  </properties>
+</tagNode>
+<node name="large-community">
+  <properties>
+    <help>Show BGP routes matching the specified large-communities</help>
+  </properties>
+  <command>${vyos_op_scripts_dir}/vtysh_wrapper.sh $@</command>
+</node>
+<leafNode name="neighbors">
+  <properties>
+    <help>Detailed information on TCP and BGP neighbor connections</help>
+  </properties>
+  <command>${vyos_op_scripts_dir}/vtysh_wrapper.sh $@</command>
+</leafNode>
+<tagNode name="neighbors">
+  <properties>
+    <help>Show detailed BGP IPv4 unicast neighbor information</help>
+    <completionHelp>
+      <script>vtysh -c 'show bgp summary' | awk '{print $1'} | grep -e '^[0-9a-f]'</script>
+    </completionHelp>
+  </properties>
+  <command>${vyos_op_scripts_dir}/vtysh_wrapper.sh $@</command>
+  <children>
+    <leafNode name="advertised-routes">
+      <properties>
+        <help>Show routes advertised to a BGP neighbor</help>
+      </properties>
+      <command>${vyos_op_scripts_dir}/vtysh_wrapper.sh $@</command>
+    </leafNode>
+    <leafNode name="dampened-routes">
+      <properties>
+        <help>Show dampened routes received from BGP neighbor</help>
+      </properties>
+      <command>${vyos_op_scripts_dir}/vtysh_wrapper.sh $@</command>
+    </leafNode>
+    <leafNode name="flap-statistics">
+      <properties>
+        <help>Show flap statistics of the routes learned from BGP neighbor</help>
+      </properties>
+      <command>${vyos_op_scripts_dir}/vtysh_wrapper.sh $@</command>
+    </leafNode>
+    <leafNode name="prefix-counts">
+      <properties>
+        <help>Show detailed prefix count information for BGP neighbor</help>
+      </properties>
+      <command>${vyos_op_scripts_dir}/vtysh_wrapper.sh $@</command>
+    </leafNode>
+    <node name="received">
+      <properties>
+        <help>Show information received from BGP neighbor</help>
+      </properties>
+      <children>
+        <leafNode name="prefix-filter">
+          <properties>
+            <help>Show prefixlist filter</help>
+          </properties>
+          <command>${vyos_op_scripts_dir}/vtysh_wrapper.sh $@</command>
+        </leafNode>
+      </children>
+    </node>
+    <leafNode name="received-routes">
+      <properties>
+        <help>Show received routes from BGP neighbor</help>
+      </properties>
+      <command>${vyos_op_scripts_dir}/vtysh_wrapper.sh $@</command>
+    </leafNode>
+    <leafNode name="routes">
+      <properties>
+        <help>Show routes learned from BGP neighbor</help>
+      </properties>
+      <command>${vyos_op_scripts_dir}/vtysh_wrapper.sh $@</command>
+    </leafNode>
+  </children>
+</tagNode>
+<tagNode name="prefix-list">
+  <properties>
+    <help>Display routes conforming to the prefix-list</help>
+  </properties>
+  <command>${vyos_op_scripts_dir}/vtysh_wrapper.sh $@</command>
+</tagNode>
+<tagNode name="regexp">
+  <properties>
+    <help>Display routes matching the AS path regular expression</help>
+  </properties>
+  <command>${vyos_op_scripts_dir}/vtysh_wrapper.sh $@</command>
+</tagNode>
+<tagNode name="route-map">
+  <properties>
+    <help>Show BGP routes matching the specified route map</help>
+    <completionHelp>
+      <path>policy route-map</path>
+    </completionHelp>
+  </properties>
+  <command>${vyos_op_scripts_dir}/vtysh_wrapper.sh $@</command>
+</tagNode>
+<!-- included end -->
diff --git a/op-mode-definitions/include/bgp/prefix-bestpath-multipath.xml.i b/op-mode-definitions/include/bgp/prefix-bestpath-multipath.xml.i
new file mode 100644
index 000000000..2d91a8253
--- /dev/null
+++ b/op-mode-definitions/include/bgp/prefix-bestpath-multipath.xml.i
@@ -0,0 +1,20 @@
+<!-- included start from bgp/prefix-bestpath-multipath.xml.i -->
+<leafNode name="bestpath">
+  <properties>
+    <help>Display only the bestpath</help>
+  </properties>
+  <command>${vyos_op_scripts_dir}/vtysh_wrapper.sh $@</command>
+</leafNode>
+<leafNode name="multipath">
+  <properties>
+    <help>Display only multipaths</help>
+  </properties>
+  <command>${vyos_op_scripts_dir}/vtysh_wrapper.sh $@</command>
+</leafNode>
+<leafNode name="longer-prefixes">
+  <properties>
+    <help>Display route and more specific routes</help>
+  </properties>
+  <command>${vyos_op_scripts_dir}/vtysh_wrapper.sh $@</command>
+</leafNode>
+<!-- included end -->
diff --git a/op-mode-definitions/include/bgp/show-bgp-common.xml.i b/op-mode-definitions/include/bgp/show-bgp-common.xml.i
new file mode 100644
index 000000000..785b85963
--- /dev/null
+++ b/op-mode-definitions/include/bgp/show-bgp-common.xml.i
@@ -0,0 +1,46 @@
+<!-- included start from bgp/show-bgp-common.xml.i -->
+#include <include/bgp/afi-common.xml.i>
+#include <include/bgp/afi-ipv4-ipv6-common.xml.i>
+<tagNode name="ipv4">
+  <properties>
+    <help>Network in the BGP routing table to display</help>
+    <completionHelp>
+      <list>&lt;x.x.x.x&gt; &lt;x.x.x.x/x&gt; &lt;h:h:h:h:h:h:h:h&gt; &lt;h:h:h:h:h:h:h:h/x&gt;</list>
+    </completionHelp>
+  </properties>
+  <children>
+    #include <include/bgp/prefix-bestpath-multipath.xml.i>
+  </children>
+  <command>${vyos_op_scripts_dir}/vtysh_wrapper.sh $@</command>
+</tagNode>
+<node name="ipv4">
+  <properties>
+    <help>IPv4 Address Family</help>
+  </properties>
+  <children>
+    #include <include/bgp/afi-common.xml.i>
+    #include <include/bgp/afi-ipv4-ipv6-common.xml.i>
+  </children>
+</node>
+<tagNode name="ipv6">
+  <properties>
+    <help>Network in the BGP routing table to display</help>
+    <completionHelp>
+      <list>&lt;x.x.x.x&gt; &lt;x.x.x.x/x&gt; &lt;h:h:h:h:h:h:h:h&gt; &lt;h:h:h:h:h:h:h:h/x&gt;</list>
+    </completionHelp>
+  </properties>
+  <children>
+    #include <include/bgp/prefix-bestpath-multipath.xml.i>
+  </children>
+  <command>${vyos_op_scripts_dir}/vtysh_wrapper.sh $@</command>
+</tagNode>
+<node name="ipv6">
+  <properties>
+    <help>IPv6 Address Family</help>
+  </properties>
+  <children>
+    #include <include/bgp/afi-common.xml.i>
+    #include <include/bgp/afi-ipv4-ipv6-common.xml.i>
+  </children>
+</node>
+<!-- included end -->
diff --git a/op-mode-definitions/include/vtysh-generic-detail.xml.i b/op-mode-definitions/include/vtysh-generic-detail.xml.i
new file mode 100644
index 000000000..d469f70c7
--- /dev/null
+++ b/op-mode-definitions/include/vtysh-generic-detail.xml.i
@@ -0,0 +1,8 @@
+<!-- included start from vtysh-generic-detail.xml.i -->
+<leafNode name="detail">
+  <properties>
+    <help>Detailed information</help>
+  </properties>
+  <command>${vyos_op_scripts_dir}/vtysh_wrapper.sh $@</command>
+</leafNode>
+<!-- included end -->
diff --git a/op-mode-definitions/include/vtysh-generic-wide.xml.i b/op-mode-definitions/include/vtysh-generic-wide.xml.i
new file mode 100644
index 000000000..acc68b4c0
--- /dev/null
+++ b/op-mode-definitions/include/vtysh-generic-wide.xml.i
@@ -0,0 +1,8 @@
+<!-- included start from vtysh-generic-wide.xml.i -->
+<leafNode name="wide">
+  <properties>
+    <help>Increase table width for longer prefixes</help>
+  </properties>
+  <command>${vyos_op_scripts_dir}/vtysh_wrapper.sh $@</command>
+</leafNode>
+<!-- included end -->
diff --git a/op-mode-definitions/show-bgp.xml.in b/op-mode-definitions/show-bgp.xml.in
new file mode 100644
index 000000000..07369ddcb
--- /dev/null
+++ b/op-mode-definitions/show-bgp.xml.in
@@ -0,0 +1,91 @@
+<?xml version="1.0"?>
+<interfaceDefinition>
+  <node name="show">
+    <children>
+      <node name="bgp">
+        <properties>
+          <help>BGP information</help>
+        </properties>
+        <command>${vyos_op_scripts_dir}/vtysh_wrapper.sh $@</command>
+        <children>
+          <node name="cidr-only">
+            <properties>
+              <help>Display only routes with non-natural netmasks</help>
+            </properties>
+            <command>${vyos_op_scripts_dir}/vtysh_wrapper.sh $@</command>
+            <children>
+              #include <include/vtysh-generic-wide.xml.i>
+            </children>
+          </node>
+          #include <include/bgp/show-bgp-common.xml.i>
+          <node name="mac">
+            <properties>
+              <help>MAC address</help>
+            </properties>
+            <children>
+              <leafNode name="hash">
+                <properties>
+                  <help>MAC address database</help>
+                </properties>
+                <command>${vyos_op_scripts_dir}/vtysh_wrapper.sh $@</command>
+              </leafNode>
+            </children>
+          </node>
+          <node name="martian">
+            <properties>
+              <help>martian next-hops</help>
+            </properties>
+            <children>
+              <leafNode name="next-hop">
+                <properties>
+                  <help>martian next-hop database</help>
+                </properties>
+                <command>${vyos_op_scripts_dir}/vtysh_wrapper.sh $@</command>
+              </leafNode>
+            </children>
+          </node>
+          <leafNode name="memory">
+            <properties>
+              <help>Global BGP memory statistics</help>
+            </properties>
+            <command>${vyos_op_scripts_dir}/vtysh_wrapper.sh $@</command>
+          </leafNode>
+          <node name="nexthop">
+            <properties>
+              <help>Show BGP nexthop table</help>
+            </properties>
+            <command>${vyos_op_scripts_dir}/vtysh_wrapper.sh $@</command>
+            <children>
+              #include <include/vtysh-generic-detail.xml.i>
+            </children>
+          </node>
+          <tagNode name="nexthop">
+            <properties>
+              <help>IPv4/IPv6 nexthop address</help>
+              <completionHelp>
+                <list>&lt;x.x.x.x&gt; &lt;h:h:h:h:h:h:h:h&gt;</list>
+              </completionHelp>
+            </properties>
+            <command>${vyos_op_scripts_dir}/vtysh_wrapper.sh $@</command>
+            <children>
+              #include <include/vtysh-generic-detail.xml.i>
+            </children>
+          </tagNode>
+          <leafNode name="statistics">
+            <properties>
+              <help>BGP RIB advertisement statistics</help>
+            </properties>
+            <command>${vyos_op_scripts_dir}/vtysh_wrapper.sh $@</command>
+          </leafNode>
+          <leafNode name="statistics-all">
+            <properties>
+              <help>Display number of prefixes for all afi/safi</help>
+            </properties>
+            <command>${vyos_op_scripts_dir}/vtysh_wrapper.sh $@</command>
+          </leafNode>
+          #include <include/vtysh-generic-wide.xml.i>
+        </children>
+      </node>
+    </children>
+  </node>
+</interfaceDefinition>
diff --git a/python/vyos/ifconfig/__init__.py b/python/vyos/ifconfig/__init__.py
index cbde93c97..d4d8c02a9 100644
--- a/python/vyos/ifconfig/__init__.py
+++ b/python/vyos/ifconfig/__init__.py
@@ -30,6 +30,8 @@ from vyos.ifconfig.vxlan import VXLANIf
 from vyos.ifconfig.wireguard import WireGuardIf
 from vyos.ifconfig.vtun import VTunIf
 from vyos.ifconfig.tunnel import TunnelIf
+from vyos.ifconfig.vti import VTIIf
+from vyos.ifconfig.pppoe import PPPoEIf
 from vyos.ifconfig.wireless import WiFiIf
 from vyos.ifconfig.l2tpv3 import L2TPv3If
 from vyos.ifconfig.macsec import MACsecIf
diff --git a/python/vyos/ifconfig/pppoe.py b/python/vyos/ifconfig/pppoe.py
new file mode 100644
index 000000000..6f14c0fd4
--- /dev/null
+++ b/python/vyos/ifconfig/pppoe.py
@@ -0,0 +1,39 @@
+# Copyright 2020 VyOS maintainers and contributors <maintainers@vyos.io>
+#
+# This library is free software; you can redistribute it and/or
+# modify it under the terms of the GNU Lesser General Public
+# License as published by the Free Software Foundation; either
+# version 2.1 of the License, or (at your option) any later version.
+#
+# This library is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+# Lesser General Public License for more details.
+#
+# You should have received a copy of the GNU Lesser General Public
+# License along with this library.  If not, see <http://www.gnu.org/licenses/>.
+
+
+from vyos.ifconfig.interface import Interface
+
+
+@Interface.register
+class PPPoEIf(Interface):
+    iftype = 'pppoe'
+    definition = {
+        **Interface.definition,
+        **{
+            'section': 'pppoe',
+            'prefixes': ['pppoe', ],
+        },
+    }
+
+    # stub this interface is created in the configure script
+
+    def _create(self):
+        # we can not create this interface as it is managed outside
+        pass
+
+    def _delete(self):
+        # we can not create this interface as it is managed outside
+        pass
diff --git a/python/vyos/ifconfig/vti.py b/python/vyos/ifconfig/vti.py
new file mode 100644
index 000000000..f575323af
--- /dev/null
+++ b/python/vyos/ifconfig/vti.py
@@ -0,0 +1,27 @@
+# Copyright 2020 VyOS maintainers and contributors <maintainers@vyos.io>
+#
+# This library is free software; you can redistribute it and/or
+# modify it under the terms of the GNU Lesser General Public
+# License as published by the Free Software Foundation; either
+# version 2.1 of the License, or (at your option) any later version.
+#
+# This library is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+# Lesser General Public License for more details.
+#
+# You should have received a copy of the GNU Lesser General Public
+# License along with this library.  If not, see <http://www.gnu.org/licenses/>.
+
+from vyos.ifconfig.interface import Interface
+
+@Interface.register
+class VTIIf(Interface):
+    iftype = 'vti'
+    definition = {
+        **Interface.definition,
+        **{
+            'section': 'vti',
+            'prefixes': ['vti', ],
+        },
+    }
diff --git a/smoketest/scripts/cli/test_service_router-advert.py b/smoketest/scripts/cli/test_service_router-advert.py
index b19c49c6e..26b4626c2 100755
--- a/smoketest/scripts/cli/test_service_router-advert.py
+++ b/smoketest/scripts/cli/test_service_router-advert.py
@@ -43,11 +43,10 @@ class TestServiceRADVD(VyOSUnitTestSHIM.TestCase):
         self.cli_delete(base_path)
         self.cli_commit()
 
-    def test_single(self):
+    def test_common(self):
         self.cli_set(base_path + ['prefix', '::/64', 'no-on-link-flag'])
         self.cli_set(base_path + ['prefix', '::/64', 'no-autonomous-flag'])
         self.cli_set(base_path + ['prefix', '::/64', 'valid-lifetime', 'infinity'])
-        self.cli_set(base_path + ['dnssl', '2001:db8::1234'])
         self.cli_set(base_path + ['other-config-flag'])
 
         # commit changes
@@ -92,5 +91,28 @@ class TestServiceRADVD(VyOSUnitTestSHIM.TestCase):
         # Check for running process
         self.assertTrue(process_named_running('radvd'))
 
+    def test_dns(self):
+        nameserver = ['2001:db8::1', '2001:db8::2']
+        dnssl = ['vyos.net', 'vyos.io']
+
+        self.cli_set(base_path + ['prefix', '::/64', 'valid-lifetime', 'infinity'])
+        self.cli_set(base_path + ['other-config-flag'])
+
+        for ns in nameserver:
+            self.cli_set(base_path + ['name-server', ns])
+        for sl in dnssl:
+            self.cli_set(base_path + ['dnssl', sl])
+
+        # commit changes
+        self.cli_commit()
+
+        config = read_file(RADVD_CONF)
+
+        tmp = 'RDNSS ' + ' '.join(nameserver) + ' {'
+        self.assertIn(tmp, config)
+
+        tmp = 'DNSSL ' + ' '.join(dnssl) + ' {'
+        self.assertIn(tmp, config)
+
 if __name__ == '__main__':
     unittest.main(verbosity=2)
diff --git a/src/op_mode/ping.py b/src/op_mode/ping.py
index 924a889db..610f6a05d 100755
--- a/src/op_mode/ping.py
+++ b/src/op_mode/ping.py
@@ -220,6 +220,8 @@ if __name__ == '__main__':
 
     try:
         ip = socket.gethostbyname(host)
+    except UnicodeError:
+        sys.exit(f'ping: Unknown host: {host}')
     except socket.gaierror:
         ip = host