summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChristian Breunig <christian@breunig.cc>2024-09-13 20:32:01 +0200
committerGitHub <noreply@github.com>2024-09-13 20:32:01 +0200
commita6290e4a43627de5b1935fc2796ec2d381d83c49 (patch)
treea123338ea3afb29ee20ac373038c595a3c392170
parentf25f0c1d09cbb3d43685d5630686d143810281b4 (diff)
parent8d4ed1124fbf93a194dbdc5df5d1592137934ac9 (diff)
downloadvyos-1x-a6290e4a43627de5b1935fc2796ec2d381d83c49.tar.gz
vyos-1x-a6290e4a43627de5b1935fc2796ec2d381d83c49.zip
Merge pull request #4060 from vyos/mergify/bp/sagitta/pr-4047
policy: T6676: Invalid route-map caused bgpd to crash (backport #4047)
-rwxr-xr-xsrc/conf_mode/policy.py8
1 files changed, 4 insertions, 4 deletions
diff --git a/src/conf_mode/policy.py b/src/conf_mode/policy.py
index 4df893ebf..a5963e72c 100755
--- a/src/conf_mode/policy.py
+++ b/src/conf_mode/policy.py
@@ -167,10 +167,10 @@ def verify(policy):
continue
for rule, rule_config in route_map_config['rule'].items():
- # Action 'deny' cannot be used with "continue"
- # FRR does not validate it T4827
- if rule_config['action'] == 'deny' and 'continue' in rule_config:
- raise ConfigError(f'rule {rule} "continue" cannot be used with action deny!')
+ # Action 'deny' cannot be used with "continue" or "on-match"
+ # FRR does not validate it T4827, T6676
+ if rule_config['action'] == 'deny' and ('continue' in rule_config or 'on_match' in rule_config):
+ raise ConfigError(f'rule {rule} "continue" or "on-match" cannot be used with action deny!')
# Specified community-list must exist
tmp = dict_search('match.community.community_list',