ifconfig: T2653: implement update() in derived classes for admin up/down

Every derived class must implement update() to set the interfaces admin
up/down state. This is required to prevend extensive link flaps when e.g.
reconfiguring bond interfaces.

1 files changed, 11 insertions, 1 deletions

diff --git a/python/vyos/ifconfig/ethernet.py b/python/vyos/ifconfig/ethernet.py
index 7641e82fd..77128633d 100644
--- a/python/vyos/ifconfig/ethernet.py
+++ b/python/vyos/ifconfig/ethernet.py
@@ -261,7 +261,7 @@ class EthernetIf(Interface):
         interface setup code and provide a single point of entry when workin
         on any interface. """
 
-        # now call the regular function from within our base class
+        # call base class first
         super().update(config)
 
         # disable ethernet flow control (pause frames)
@@ -326,3 +326,13 @@ class EthernetIf(Interface):
         for vif_id, vif in config.get('vif', {}).items():
             vlan = self.add_vlan(vif_id)
             vlan.update(vif)
+
+        # Enable/Disable of an interface must always be done at the end of the
+        # derived class to make use of the ref-counting set_admin_state()
+        # function. We will only enable the interface if 'up' was called as
+        # often as 'down'. This is required by some interface implementations
+        # as certain parameters can only be changed when the interface is
+        # in admin-down state. This ensures the link does not flap during
+        # reconfiguration.
+        state = 'down' if 'disable' in config else 'up'
+        self.set_admin_state(state)