summaryrefslogtreecommitdiff
path: root/python/vyos/ifconfig/loopback.py
diff options
context:
space:
mode:
authorDaniil Baturin <daniil@vyos.io>2020-07-26 14:06:31 +0300
committerDaniil Baturin <daniil@vyos.io>2020-07-26 14:06:31 +0300
commit5f78e67c746e9357cbb59fe066c2b32f34bc92ae (patch)
tree7a392c617c7a008f134a676436eb29eda24c98a4 /python/vyos/ifconfig/loopback.py
parent9578890e1e4dc31da7387a6ad810d2efb22391e7 (diff)
parent675942ce3e2329a0122da189cd5944df08d7fcab (diff)
downloadvyos-1x-5f78e67c746e9357cbb59fe066c2b32f34bc92ae.tar.gz
vyos-1x-5f78e67c746e9357cbb59fe066c2b32f34bc92ae.zip
Merge branch 'current' of https://github.com/vyos/vyos-1x into current
Diffstat (limited to 'python/vyos/ifconfig/loopback.py')
-rw-r--r--python/vyos/ifconfig/loopback.py12
1 files changed, 11 insertions, 1 deletions
diff --git a/python/vyos/ifconfig/loopback.py b/python/vyos/ifconfig/loopback.py
index 7ebd13b54..2b4ebfdcc 100644
--- a/python/vyos/ifconfig/loopback.py
+++ b/python/vyos/ifconfig/loopback.py
@@ -75,5 +75,15 @@ class LoopbackIf(Interface):
# Update IP address entry in our dictionary
config.update({'address' : addr})
- # now call the regular function from within our base class
+ # call base class
super().update(config)
+
+ # Enable/Disable of an interface must always be done at the end of the
+ # derived class to make use of the ref-counting set_admin_state()
+ # function. We will only enable the interface if 'up' was called as
+ # often as 'down'. This is required by some interface implementations
+ # as certain parameters can only be changed when the interface is
+ # in admin-down state. This ensures the link does not flap during
+ # reconfiguration.
+ state = 'down' if 'disable' in config else 'up'
+ self.set_admin_state(state)