ifconfig: T2985: support on demand bridge creation

The current implementation for bridge based interfaces has an issue which is
caused by priority inheritance. We always assumed that the bridge interface will
be created last, but this may not be true in all cases, where some interfaces
will be created "on demand" - e.g. OpenVPN or late (VXLAN, GENEVE).

As we already have a bunch of verify steps in place we should not see a bridge
interface leak to the underlaying infrastructure code. This means, whenever an
interface will be member of a bridge, and the bridge does yet not exist, we will
create it in advance in the interface context, as the bridge code will be run
in the same commit but maybe sooner or later.

This will also be the solution for T2924.

1 files changed, 0 insertions, 70 deletions

diff --git a/python/vyos/ifconfig/stp.py b/python/vyos/ifconfig/stp.py
deleted file mode 100644
index 5e83206c2..000000000
--- a/python/vyos/ifconfig/stp.py
+++ /dev/null
@@ -1,70 +0,0 @@
-# Copyright 2019 VyOS maintainers and contributors <maintainers@vyos.io>
-#
-# This library is free software; you can redistribute it and/or
-# modify it under the terms of the GNU Lesser General Public
-# License as published by the Free Software Foundation; either
-# version 2.1 of the License, or (at your option) any later version.
-#
-# This library is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
-# Lesser General Public License for more details.
-#
-# You should have received a copy of the GNU Lesser General Public
-# License along with this library.  If not, see <http://www.gnu.org/licenses/>.
-
-
-from vyos.ifconfig.interface import Interface
-
-from vyos.validate import assert_positive
-
-
-class STP:
-    """
-    A spanning-tree capable interface. This applies only to bridge port member
-    interfaces!
-    """
-
-    @classmethod
-    def enable (cls, adaptee):
-        adaptee._sysfs_set = {**adaptee._sysfs_set, **cls._sysfs_set}
-        adaptee.set_path_cost = cls.set_path_cost
-        adaptee.set_path_priority = cls.set_path_priority
-        return adaptee
-
-    _sysfs_set = {
-        'path_cost': {
-            # XXX: we should set a maximum
-            'validate': assert_positive,
-            'location': '/sys/class/net/{ifname}/brport/path_cost',
-            'errormsg': '{ifname} is not a bridge port member'
-        },
-        'path_priority': {
-            # XXX: we should set a maximum
-            'validate': assert_positive,
-            'location': '/sys/class/net/{ifname}/brport/priority',
-            'errormsg': '{ifname} is not a bridge port member'
-        },
-    }
-
-    def set_path_cost(self, cost):
-        """
-        Set interface path cost, only relevant for STP enabled interfaces
-
-        Example:
-
-        >>> from vyos.ifconfig import Interface
-        >>> Interface('eth0').set_path_cost(4)
-        """
-        self.set_interface('path_cost', cost)
-
-    def set_path_priority(self, priority):
-        """
-        Set interface path priority, only relevant for STP enabled interfaces
-
-        Example:
-
-        >>> from vyos.ifconfig import Interface
-        >>> Interface('eth0').set_path_priority(4)
-        """
-        self.set_interface('path_priority', priority)