summaryrefslogtreecommitdiff
path: root/python/vyos
diff options
context:
space:
mode:
authorChristian Poessinger <christian@poessinger.com>2020-08-31 19:57:06 +0200
committerChristian Poessinger <christian@poessinger.com>2020-08-31 19:59:25 +0200
commit9c63731d6683f59ea784c08852ed38e3ac22794b (patch)
treecebb83f73174ca647fdb59bccb3a584d3b3670e5 /python/vyos
parent621fcb078abb53888e995a007fb9ea31e95e34ab (diff)
downloadvyos-1x-9c63731d6683f59ea784c08852ed38e3ac22794b.tar.gz
vyos-1x-9c63731d6683f59ea784c08852ed38e3ac22794b.zip
T2636: remove workarounds for get_config_dict()
Now that b40c52682a256 ("config: T2636: get_config_dict() returns a list on multi node by default") is implemented the workarounds can be removed.
Diffstat (limited to 'python/vyos')
-rw-r--r--python/vyos/configdict.py3
-rw-r--r--python/vyos/ifconfig/interface.py7
-rw-r--r--python/vyos/ifconfig/loopback.py5
3 files changed, 0 insertions, 15 deletions
diff --git a/python/vyos/configdict.py b/python/vyos/configdict.py
index bd8624ced..e8c0aa5b3 100644
--- a/python/vyos/configdict.py
+++ b/python/vyos/configdict.py
@@ -270,9 +270,6 @@ def get_interface_dict(config, base, ifname=''):
eui64 = leaf_node_changed(config, ['ipv6', 'address', 'eui64'])
if eui64:
- # XXX: T2636 workaround: convert string to a list with one element
- if isinstance(eui64, str):
- eui64 = [eui64]
tmp = vyos_dict_search('ipv6.address', dict)
if not tmp:
dict.update({'ipv6': {'address': {'eui64_old': eui64}}})
diff --git a/python/vyos/ifconfig/interface.py b/python/vyos/ifconfig/interface.py
index 67ba973c4..ef2336c17 100644
--- a/python/vyos/ifconfig/interface.py
+++ b/python/vyos/ifconfig/interface.py
@@ -898,10 +898,6 @@ class Interface(Control):
# configured addresses will be removed first
new_addr = config.get('address', [])
- # XXX: T2636 workaround: convert string to a list with one element
- if isinstance(new_addr, str):
- new_addr = [new_addr]
-
# always ensure DHCP client is stopped (when not configured explicitly)
if 'dhcp' not in new_addr:
self.del_addr('dhcp')
@@ -1023,9 +1019,6 @@ class Interface(Control):
# Add IPv6 EUI-based addresses
tmp = vyos_dict_search('ipv6.address.eui64', config)
if tmp:
- # XXX: T2636 workaround: convert string to a list with one element
- if isinstance(tmp, str):
- tmp = [tmp]
for addr in tmp:
self.add_ipv6_eui64_address(addr)
diff --git a/python/vyos/ifconfig/loopback.py b/python/vyos/ifconfig/loopback.py
index 2b4ebfdcc..c70e1773f 100644
--- a/python/vyos/ifconfig/loopback.py
+++ b/python/vyos/ifconfig/loopback.py
@@ -64,11 +64,6 @@ class LoopbackIf(Interface):
on any interface. """
addr = config.get('address', [])
- # XXX workaround for T2636, convert IP address string to a list
- # with one element
- if isinstance(addr, str):
- addr = [addr]
-
# We must ensure that the loopback addresses are never deleted from the system
addr += self._persistent_addresses