smoketest: refactor setUp() for all interface based testcases

It does not make sense (at all!) to re-initialize the entire class with every
call to setUp(). We neither change the enabled/disabled tastcases dynamically,
not do we adjust the testinterfaces during a run.

Remove the runtime overhead and place one-time init calls into setUpClass()
instead.

(cherry picked from commit b48890396dcff074d1e9336ca1db9d3eafe2a12f)

1 files changed, 10 insertions, 10 deletions

diff --git a/smoketest/scripts/cli/test_interfaces_macsec.py b/smoketest/scripts/cli/test_interfaces_macsec.py
index 89743e5fd..3a3e7bff3 100755
--- a/smoketest/scripts/cli/test_interfaces_macsec.py
+++ b/smoketest/scripts/cli/test_interfaces_macsec.py
@@ -1,6 +1,6 @@
 #!/usr/bin/env python3
 #
-# Copyright (C) 2020 VyOS maintainers and contributors
+# Copyright (C) 2020-2021 VyOS maintainers and contributors
 #
 # This program is free software; you can redistribute it and/or modify
 # it under the terms of the GNU General Public License version 2 or later as
@@ -31,19 +31,19 @@ def get_config_value(interface, key):
     return tmp[0]
 
 class MACsecInterfaceTest(BasicInterfaceTest.BaseTest):
-    def setUp(self):
-         super().setUp()
-         self._test_ip = True
-         self._test_ipv6 = True
-         self._base_path = ['interfaces', 'macsec']
-         self._options = { 'macsec0': ['source-interface eth0', 'security cipher gcm-aes-128'] }
+    @classmethod
+    def setUpClass(cls):
+         cls._test_ip = True
+         cls._test_ipv6 = True
+         cls._base_path = ['interfaces', 'macsec']
+         cls._options = { 'macsec0': ['source-interface eth0', 'security cipher gcm-aes-128'] }
 
          # if we have a physical eth1 interface, add a second macsec instance
-         if 'eth1' in Section.interfaces("ethernet"):
+         if 'eth1' in Section.interfaces('ethernet'):
              macsec = { 'macsec1': [f'source-interface eth1', 'security cipher gcm-aes-128'] }
-             self._options.update(macsec)
+             cls._options.update(macsec)
 
-         self._interfaces = list(self._options)
+         cls._interfaces = list(cls._options)
 
     def test_macsec_encryption(self):
         # MACsec can be operating in authentication and encryption mode - both