summaryrefslogtreecommitdiff
path: root/src/migration-scripts/pppoe-server/3-to-4
diff options
context:
space:
mode:
authorChristian Poessinger <christian@poessinger.com>2021-09-07 11:41:12 +0200
committerChristian Poessinger <christian@poessinger.com>2021-09-07 11:48:28 +0200
commitadca504a2c5cd60be46a741ab3aef83fa4dfe4cf (patch)
tree566eafcdc74aa6b853b9961b746400bb975a83d4 /src/migration-scripts/pppoe-server/3-to-4
parentff25cb35c93e464acb7c18d329323ba841311abe (diff)
downloadvyos-1x-adca504a2c5cd60be46a741ab3aef83fa4dfe4cf.tar.gz
vyos-1x-adca504a2c5cd60be46a741ab3aef83fa4dfe4cf.zip
scripts: op-mode: T3807: bugfix node.def generator
process_node() processes the XML tree in a fixed order, "node" before "tagNode" before "leafNode". If the generator created a "node.def" file, it can no longer be overwritten - else we would have some stale "node.def" files with an empty help string (T2555). Without the fixed order this would resulted in a case where we get a node and a tagNode with the same name, e.g. "show interfaces ethernet" and "show interfaces ethernet eth0" that the node implementation was not callable from the CLI, rendering this command useless (T3807). This can be fixed by forcing the "node", "tagNode", "leafNode" order by sorting the input XML file automatically (sorting from https://stackoverflow.com/a/46128043) thus adding no additional overhead to the user. (cherry picked from commit 7623e37c918c65418d8dfc521f976bb91f0594c0)
Diffstat (limited to 'src/migration-scripts/pppoe-server/3-to-4')
0 files changed, 0 insertions, 0 deletions