summaryrefslogtreecommitdiff
path: root/python/vyos/configtree.py
diff options
context:
space:
mode:
Diffstat (limited to 'python/vyos/configtree.py')
-rw-r--r--python/vyos/configtree.py37
1 files changed, 26 insertions, 11 deletions
diff --git a/python/vyos/configtree.py b/python/vyos/configtree.py
index 4b46a1fb3..39fe41669 100644
--- a/python/vyos/configtree.py
+++ b/python/vyos/configtree.py
@@ -24,6 +24,7 @@ def strip_comments(s):
IN_COMMENT = 1
i = len(s) - 1
+
state = INITIAL
config_end = 0
@@ -42,14 +43,11 @@ def strip_comments(s):
break
elif (state == INITIAL) and (c == '/'):
# A comment begins, or it's a stray slash
- try:
- if (s[i-1] == '*'):
- state = IN_COMMENT
- i -= 2
- else:
- raise ValueError("Invalid syntax")
- except:
- raise ValueError("Invalid syntax")
+ if (s[i-1] == '*'):
+ state = IN_COMMENT
+ i -= 2
+ else:
+ raise ValueError("Invalid syntax: stray slash at character {0}".format(i + 1))
elif (state == INITIAL) and (c == '}'):
# We are not inside a comment, that's the end of the last node
config_end = i + 1
@@ -61,12 +59,12 @@ def strip_comments(s):
state = INITIAL
i -= 2
except:
- raise ValueError("Invalid syntax")
+ raise ValueError("Invalid syntax: malformed commend end at character {0}".format(i + 1))
elif (state == IN_COMMENT) and (c != '*'):
# Ignore everything inside comments, including braces
i -= 1
else:
- raise ValueError("Invalid syntax")
+ raise ValueError("Invalid syntax at character {0}: invalid character {1}".format(i + 1, c))
return (s[0:config_end], s[config_end+1:])
@@ -92,6 +90,10 @@ class ConfigTree(object):
self.__from_string.argtypes = [c_char_p]
self.__from_string.restype = c_void_p
+ self.__get_error = self.__lib.get_error
+ self.__get_error.argtypes = []
+ self.__get_error.restype = c_char_p
+
self.__to_string = self.__lib.to_string
self.__to_string.argtypes = [c_void_p]
self.__to_string.restype = c_char_p
@@ -112,6 +114,10 @@ class ConfigTree(object):
self.__delete.argtypes = [c_void_p, c_char_p]
self.__delete.restype = c_int
+ self.__rename = self.__lib.rename_node
+ self.__rename.argtypes = [c_void_p, c_char_p, c_char_p]
+ self.__rename.restype = c_int
+
self.__set_replace_value = self.__lib.set_replace_value
self.__set_replace_value.argtypes = [c_void_p, c_char_p, c_char_p]
self.__set_replace_value.restype = c_int
@@ -150,10 +156,12 @@ class ConfigTree(object):
config_section, comments_section = strip_comments(config_string)
config = self.__from_string(config_section.encode())
if config is None:
- raise ValueError("Parse error")
+ msg = self.__get_error().decode()
+ raise ValueError("Failed to parse config: {0}".format(msg))
else:
self.__config = config
self.__comments = comments_section
+
def __del__(self):
if self.__config is not None:
self.__destroy(self.__config)
@@ -193,6 +201,13 @@ class ConfigTree(object):
self.__delete_value(self.__config, path_str, value.encode())
+ def rename(self, path, newname):
+ check_path(path)
+ path_str = " ".join(map(str, path)).encode()
+ newname_str = newname.encode()
+
+ self.__rename(self.__config, path_str, newname_str)
+
def exists(self, path):
check_path(path)
path_str = " ".join(map(str, path)).encode()