summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2024-07-25vrf: T6602: verify supplied VRF name on all interface types (#3870)mergify[bot]
Only some (e.g. ethernet or wireguard) interfaces validate if the supplied VRF actually exists. If this is not validated, one can pass an invalid VRF to the system which generates an OSError exception. To reproduce set interfaces vxlan vxlan1 vni 1000 set interfaces vxlan vxlan1 remote 1.2.3.4 set interfaces vxlan vxlan1 vrf smoketest results in OSError: [Errno 255] failed to run command: ip link set dev vxlan1 master smoketest_mgmt This commit adds the missing verify_vrf() call to the missing interface types and an appropriate smoketest for all interfaces supporting VRF assignment. (cherry picked from commit dd0ebffa33728e452ac6e11737c2283f0e390359) Co-authored-by: Christian Breunig <christian@breunig.cc>
2024-07-24Merge pull request #3867 from vyos/mergify/bp/circinus/pr-3861Christian Breunig
op_mode: T6593: Release DHCP interface does not work (backport #3861)
2024-07-24Merge pull request #3865 from vyos/mergify/bp/circinus/pr-3860Christian Breunig
op_mode: T6596: pppoe operation command failed (backport #3860)
2024-07-24op_mode: T6593: Release DHCP interface does not workNataliia Solomko
(cherry picked from commit 92461c35c7ef131940c885aca894a2d8b3c89592)
2024-07-24op_mode: T6596: pppoe operation command failedNataliia Solomko
(cherry picked from commit 79407cd5bbec3194a9b6542418229b33eab05121)
2024-07-24Merge pull request #3859 from vyos/mergify/bp/circinus/pr-3838Christian Breunig
smoketest: T6600: ospf: enable MPLS LDP on dummy interfaces (backport #3838)
2024-07-24smoketest: T6600: ospf: enable MPLS LDP on dummy interfacesChristian Breunig
(cherry picked from commit 71926f64385d7ab66431c60afa1fc8554ad7e2dc)
2024-07-23Merge pull request #3854 from vyos/mergify/bp/circinus/pr-3832Christian Breunig
T6594: Add missed pppd_compat module (backport #3832)
2024-07-23SSTP-server: add missed pppd_compat moduleViacheslav Hletenko
(cherry picked from commit 8c8054ad5410e8aedf6ab7a0702b317872d4fd41)
2024-07-23PPTP-server: add missed pppd_compat moduleViacheslav Hletenko
(cherry picked from commit 440a3e6b89748bfd861f580fc8c4f41b58c6cec2)
2024-07-23L2TP-server: add missed pppd_compat moduleViacheslav Hletenko
(cherry picked from commit ef50cd9954a2d6eb2a041c26a0bb8ea0758b1f17)
2024-07-23IPoE-server: add missed pppd_compat moduleViacheslav Hletenko
(cherry picked from commit b92bc209cc1d6ed54a5fa052e0c27c54488ae955)
2024-07-23Merge pull request #3844 from vyos/mergify/bp/circinus/pr-3833Christian Breunig
wireless: T6597: improve hostapd startup and corresponding smoketests (backport #3833)
2024-07-22wireless: T6597: improve hostapd startup and corresponding smoketestsChristian Breunig
This was found during smoketesting as thoase started to repeadingly fail in the last weeks File "/usr/libexec/vyos/tests/smoke/cli/test_interfaces_wireless.py", line 534, in test_wireless_security_station_address self.assertTrue(process_named_running('hostapd')) AssertionError: None is not true Digging into this revealed that this is NOT related to the smoketest coding but to hostapd/systemd instead. With a configured WIFI interface and calling: "sudo systemctl reload-or-restart hostapd@wlan1" multiple times in a short period caused systemd to report: "Jul 18 16:15:32 systemd[1]: hostapd@wlan1.service: Deactivated successfully." According to the internal systemd logic used in our version this is explained by: /* If there's a stop job queued before we enter the DEAD state, we shouldn't act on Restart=, in order to not * undo what has already been enqueued. */ if (unit_stop_pending(UNIT(s))) allow_restart = false; if (s->result == SERVICE_SUCCESS) s->result = f; if (s->result == SERVICE_SUCCESS) { unit_log_success(UNIT(s)); end_state = SERVICE_DEAD;` Where unit_log_success() generates the log message in question. Improve the restart login in the wireless interface script and an upgrade to hostapd solved the issue. (cherry picked from commit a67f49d99eda00998c425f9a663e138dbd0f7755)
2024-07-22smoketest: T6406: use check_kmod() helper over native call()Christian Breunig
(cherry picked from commit 8bf6687b5276589e64988c3c54dbf61a628ee2a0)
2024-07-22smoketest: T6597: add "commit" debug informationChristian Breunig
(cherry picked from commit f6485f7df8713298d81ec0d45c548417db111523)
2024-07-22utils: T5195: fix timeout commentChristian Breunig
(cherry picked from commit 11b273108d78ab1588be3c077f40b2ac876369a4)
2024-07-22Merge pull request #3846 from vyos/mergify/bp/circinus/pr-3524Christian Breunig
wireless: T6320: Add 802.11ax at 6GHz to VyOS (backport #3524)
2024-07-22wireless: T6320: add 802.11ax at 6GHzAlain Lamar
Authored-By: Alain Lamar <alain_lamar@yahoo.de> (cherry picked from commit d5e988ba2d0fa0189feff22374c9b46eb49e2e79)
2024-07-22Merge pull request #3852 from vyos/mergify/bp/circinus/pr-3850Daniil Baturin
openvpn: T3834: verify() is not allowed to change anything on the system (backport #3850)
2024-07-22Merge pull request #3848 from vyos/mergify/bp/circinus/pr-3576Christian Breunig
wireless: T6425: Fixing VHT beamforming for 802.11ac (backport #3576)
2024-07-22openvpn: T3834: verify() is not allowed to change anything on the systemChristian Breunig
Commit e3c71af1466 ("remove secrets file if the tunnel is deleted and fix opmode commands") added a code path into verify() which removed files on the system if TOTP was not defined. This commit moves the code path to the appropriate generate() function. (cherry picked from commit 40c835992db9217f48e54dbbf15a7fbf1dcba482)
2024-07-22wireless: T6425: adjust to latest country-code changesChristian Breunig
Commit 9e22ab6b2a ("wireless: T6318: move country-code to a system wide configuration") removed the per wifi interface setting for a country-code. This commit adjust the smoketests to the new design. (cherry picked from commit 312273c9569d973c510d871adb941709804d8868)
2024-07-22wireless: T6425: Add smoketests for VHT beamformingAlain Lamar
(cherry picked from commit 578fbe0eb436697132e5a738fec5a4ac61ced8da)
2024-07-22wireless: T6425: Fix broken VHT beamformingAlain Lamar
(cherry picked from commit f75f0f9c94472f46e056808c3ac6aba809c090f0)
2024-07-22Merge pull request #3842 from vyos/mergify/bp/circinus/pr-3841Christian Breunig
T6599: ipsec: support disabling rekey of CHILD_SA, converge and fix defaults (backport #3841)
2024-07-22T6599: ipsec: fix incorect default behavior for dead-peer-detectionLucas Christian
(cherry picked from commit 23a3419d512139650cfe3dc76759b370b0c0c3d6)
2024-07-22T6599: ipsec: support disabling rekey of CHILD_SA.Lucas Christian
Also adds support for life_bytes, life_packets, and DPD for remote-access connections. Changes behavior of remote-access esp-group lifetime setting to have parity with site-to-site connections. (cherry picked from commit fd5d7ff0b4fd69b248ecb29c6ec1f3cf844c41cf)
2024-07-22Merge pull request #3836 from vyos/mergify/bp/circinus/pr-3834Christian Breunig
interfaces: T6592: moving an interface between VRF instances failed (backport #3834)
2024-07-21vrf: T6592: remove unused import get_interface_configChristian Breunig
Remove unused import (left over) from commit 36f3791e0 ("utils: migrate to new get_vrf_tableid() helper") (cherry picked from commit b551f542c5c906c901e3be37ad3fd68c8248473d)
2024-07-20utils: migrate to new get_vrf_tableid() helperChristian Breunig
Commit 452068ce7 ("interfaces: T6592: moving an interface between VRF instances failed") introduced a new helper to retrieve the VRF table ID from the Kernel. This commit migrates the old code path where the individual fields got queried to the new helper vyos.utils.network.get_vrf_tableid(). (cherry picked from commit 36f3791e0c15267483d59a3bb74465811d08df88)
2024-07-20interfaces: T6592: moving an interface between VRF instances failedChristian Breunig
To reproduce: set vrf name mgmt table '150' set vrf name no-mgmt table '151' set interfaces ethernet eth2 vrf 'mgmt' commit set interfaces ethernet eth2 vrf no-mgmt commit This resulted in an error while interacting with nftables: [Errno 1] failed to run command: nft add element inet vrf_zones ct_iface_map { "eth2" : 151 } The reason is that the old mapping entry still exists and was not removed. This commit adds a new utility function get_vrf_tableid() and compares the current and new VRF table IDs assigned to an interface. If the IDs do not match, the nftables ct_iface_map entry is removed before the new entry is added. (cherry picked from commit 452068ce78581bb6fba2df4dba197e95b9aeb33d)
2024-07-19T6578: Fix unhandled exception in "show openconnect-server sessions" (#3830)mergify[bot]
(cherry picked from commit e858d96a3fbc1ae4719a50ee67df02b2f256b40f) Co-authored-by: khramshinr <khramshinr@gmail.com>
2024-07-19Merge pull request #3829 from vyos/mergify/bp/circinus/pr-3825Christian Breunig
openvpn: T6591: deprecate OpenVPN server net30 topology (backport #3825)
2024-07-18openvpn: T6591: deprecate OpenVPN server net30 topology (#3825)Daniil Baturin
(cherry picked from commit e2b05343b30d2f989968532106e792cbaf75ecf6)
2024-07-18Merge pull request #3822 from vyos/mergify/bp/circinus/pr-3813Daniil Baturin
configdep: T6559: fix regression in dependent script error under configd (backport #3813)
2024-07-18Merge pull request #3819 from vyos/mergify/bp/circinus/pr-3817Christian Breunig
op-mode: T6577: create generic service restart helper to work with the API (backport #3817)
2024-07-17op-mode: T6577: create generic service restart helper to work with the APIChristian Breunig
Right now we have multiple restart helpers (e.g. dhcp server, ssh, ntp) that all do the same (more or less): * Check if service is configured on CLI * Restart if configured * Error out if unconfigured This is not available via the op-mode API. Create a new restart.py op-mode helper that takes the service name and possible VRF as argument so it's also exposed via API. (cherry picked from commit c74ae852152b0c3c3f00a1847d081d28f500e178)
2024-07-17configdep: T6559: add smoketest of dependency script errorJohn Estabrook
(cherry picked from commit ad43aa885a8ef689da212088d6ebb37c32d72883)
2024-07-17configdep: T6559: use single dependency list with reset under configdJohn Estabrook
(cherry picked from commit 52d08b1ec5b2943744daac7123e35fd415f85db2)
2024-07-17configdep: T6559: drop global redundancy removal to fix error reportingJohn Estabrook
(cherry picked from commit 7249d10f1fbb3f90a4bdbcd0223926d0380ddd3a)
2024-07-15Merge pull request #3815 from vyos/mergify/bp/circinus/pr-3810Christian Breunig
op-mode: T6575: add support for NTP service restart via CLI (backport #3810)
2024-07-15op-mode: T6575: add support for NTP service restart via CLIChristian Breunig
This seemed to be arround in the early days, but is not available since at least VyOS 1.3.3. Add CLI helper to restart the NTP process (chrony). (cherry picked from commit ca4f4343999bdbd8450ef952f42062877d6f3bab)
2024-07-12Merge pull request #3808 from vyos/mergify/bp/circinus/pr-3805Christian Breunig
op-mode: T6566: add support for listing all interfaces in "monitor bandwidth" (backport #3805)
2024-07-11op-mode: T6566: add support for listing all interfaces in "monitor bandwidth"Christian Breunig
Right now we can only monitor the bandwidth for one individual interface, but not all at once. This adds support to monitor all interfaces. (cherry picked from commit 7704af0c4454725e8c67138e5cabab3328bde0f8)
2024-07-09T6564: workflow trigger restrictions for circinus (#3802)Vijayakumar A
2024-07-06Merge pull request #3797 from vyos/mergify/bp/circinus/pr-3791Christian Breunig
op-mode: T6537: remove unused cmd imported from vyos.utils.process (backport #3791)
2024-07-05op-mode: T6537: remove unused cmd imported from vyos.utils.processChristian Breunig
Commit dc60fe99350 ("op-mode: T6537: include hostname in the reboot/shutdown warning message") added a more local import of vyos.utils.process.cmd() that made the fglobal import obsolete and trigger a linter warning. $ make unused-imports -------------------------------------------------------------------- Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00) (cherry picked from commit 6b2e45c073eeef62bbb5905e1bff98e20199b6b0)
2024-07-05Merge pull request #3795 from vyos/T6556-unused-import-permission-circinusChristian Breunig
T6556: pull_request_target update in unused import - circinus
2024-07-05T6556: pull_request_target update in unused import - circinusVijayakumar A
generated by cgit v1.2.3 (git 2.39.1) at 2024-11-26 23:42:18 +0000