From 313dfa6b8a12c4eb6d72275b34b2e43b029caf90 Mon Sep 17 00:00:00 2001
From: Yuxiang Zhu <vfreex@gmail.com>
Date: Wed, 29 Jun 2022 16:48:58 +0800
Subject: bridge: add option to enable/disable IGMP/MLD snooping

This PR adds an config option to enable/disable IGMP/MLD snooping.

```
set interfaces bridge brN igmp snooping
```
---
 interface-definitions/interfaces-bridge.xml.in | 10 ++++++++--
 python/vyos/ifconfig/bridge.py                 | 21 +++++++++++++++++++++
 2 files changed, 29 insertions(+), 2 deletions(-)

diff --git a/interface-definitions/interfaces-bridge.xml.in b/interface-definitions/interfaces-bridge.xml.in
index 60edf3ce2..48ee1efbc 100644
--- a/interface-definitions/interfaces-bridge.xml.in
+++ b/interface-definitions/interfaces-bridge.xml.in
@@ -73,12 +73,18 @@
           </leafNode>
           <node name="igmp">
             <properties>
-              <help>Internet Group Management Protocol (IGMP) settings</help>
+              <help>Internet Group Management Protocol (IGMP) and Multicast Listener Discovery (MLD) settings</help>
             </properties>
             <children>
               <leafNode name="querier">
                 <properties>
-                  <help>Enable IGMP querier</help>
+                  <help>Enable IGMP/MLD querier</help>
+                  <valueless/>
+                </properties>
+              </leafNode>
+              <leafNode name="snooping">
+                <properties>
+                  <help>Enable IGMP/MLD snooping</help>
                   <valueless/>
                 </properties>
               </leafNode>
diff --git a/python/vyos/ifconfig/bridge.py b/python/vyos/ifconfig/bridge.py
index ffd9c590f..e4db69c1f 100644
--- a/python/vyos/ifconfig/bridge.py
+++ b/python/vyos/ifconfig/bridge.py
@@ -90,6 +90,10 @@ class BridgeIf(Interface):
             'validate': assert_boolean,
             'location': '/sys/class/net/{ifname}/bridge/multicast_querier',
         },
+        'multicast_snooping': {
+            'validate': assert_boolean,
+            'location': '/sys/class/net/{ifname}/bridge/multicast_snooping',
+        },
     }}
 
     _command_set = {**Interface._command_set, **{
@@ -198,6 +202,18 @@ class BridgeIf(Interface):
         """
         self.set_interface('multicast_querier', enable)
 
+    def set_multicast_snooping(self, enable):
+        """
+        Enable or disable multicast snooping on the bridge.
+
+        Use enable=1 to enable or enable=0 to disable
+
+        Example:
+        >>> from vyos.ifconfig import Interface
+        >>> BridgeIf('br0').set_multicast_snooping(1)
+        """
+        self.set_interface('multicast_snooping', enable)
+
     def add_port(self, interface):
         """
         Add physical interface to bridge (member port)
@@ -257,6 +273,11 @@ class BridgeIf(Interface):
         value = '1' if 'stp' in config else '0'
         self.set_stp(value)
 
+        # enable or disable multicast snooping
+        tmp = dict_search('igmp.snooping', config)
+        value = '1' if (tmp != None) else '0'
+        self.set_multicast_snooping(value)
+
         # enable or disable IGMP querier
         tmp = dict_search('igmp.querier', config)
         value = '1' if (tmp != None) else '0'
-- 
cgit v1.2.3