From b9c2ce3e3589fe3c94d6d8d258e1bbc43571e690 Mon Sep 17 00:00:00 2001
From: Christian Poessinger <christian@poessinger.com>
Date: Fri, 7 Jan 2022 22:04:41 +0100
Subject: xml: firewall: T4130: add protocol completion helper all and tcp_udp

---
 interface-definitions/include/firewall/common-rule.xml.i | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/interface-definitions/include/firewall/common-rule.xml.i b/interface-definitions/include/firewall/common-rule.xml.i
index 727200ed7..92950cc68 100644
--- a/interface-definitions/include/firewall/common-rule.xml.i
+++ b/interface-definitions/include/firewall/common-rule.xml.i
@@ -100,6 +100,7 @@
     <help>Protocol to match (protocol name, number, or "all")</help>
     <completionHelp>
       <script>${vyos_completion_dir}/list_protocols.sh</script>
+      <list>all tcp_udp</list>
     </completionHelp>
     <valueHelp>
       <format>all</format>
@@ -113,9 +114,13 @@
       <format>u32:0-255</format>
       <description>IP protocol number</description>
     </valueHelp>
+    <valueHelp>
+      <format>&lt;protocol&gt;</format>
+      <description>IP protocol name</description>
+    </valueHelp>
     <valueHelp>
       <format>!&lt;protocol&gt;</format>
-      <description>IP protocol number</description>
+      <description>IP protocol name</description>
     </valueHelp>
     <constraint>
       <validator name="ip-protocol"/>
-- 
cgit v1.2.3