From cd6d5c3d407355d2eca586407b14014f4c2043cd Mon Sep 17 00:00:00 2001
From: Christian Poessinger <christian@poessinger.com>
Date: Thu, 8 Apr 2021 17:13:55 +0200
Subject: static: T3280: re-use common route-map XML building block

---
 interface-definitions/include/static/static-route-map.xml.i | 10 ----------
 1 file changed, 10 deletions(-)
 delete mode 100644 interface-definitions/include/static/static-route-map.xml.i

(limited to 'interface-definitions/include')

diff --git a/interface-definitions/include/static/static-route-map.xml.i b/interface-definitions/include/static/static-route-map.xml.i
deleted file mode 100644
index af825e043..000000000
--- a/interface-definitions/include/static/static-route-map.xml.i
+++ /dev/null
@@ -1,10 +0,0 @@
-<!-- include start from static/static-route-map.xml.i -->
-<leafNode name="route-map">
-  <properties>
-    <help>Filter routes installed in local route map</help>
-    <completionHelp>
-      <path>policy route-map</path>
-    </completionHelp>
-  </properties>
-</leafNode>
-<!-- include end -->
-- 
cgit v1.2.3


From ee44b9ba6ed7b28f0ae05e65d193ccd95a3a3fe5 Mon Sep 17 00:00:00 2001
From: Christian Poessinger <christian@poessinger.com>
Date: Thu, 8 Apr 2021 17:14:44 +0200
Subject: isis: T1316: re-use common route-map XML building block

---
 .../include/isis/isis-redistribute-ipv4.xml.i          | 18 ++----------------
 1 file changed, 2 insertions(+), 16 deletions(-)

(limited to 'interface-definitions/include')

diff --git a/interface-definitions/include/isis/isis-redistribute-ipv4.xml.i b/interface-definitions/include/isis/isis-redistribute-ipv4.xml.i
index df48b4d28..15c8c0b0b 100644
--- a/interface-definitions/include/isis/isis-redistribute-ipv4.xml.i
+++ b/interface-definitions/include/isis/isis-redistribute-ipv4.xml.i
@@ -16,14 +16,7 @@
         </constraint>
       </properties>
     </leafNode>
-    <leafNode name="route-map">
-      <properties>
-        <help>Route map reference</help>
-        <completionHelp>
-          <path>policy route-map</path>
-        </completionHelp>
-      </properties>
-    </leafNode>
+    #include <include/route-map.xml.i>
   </children>
 </node>
 <node name="level-2">
@@ -43,14 +36,7 @@
         </constraint>
       </properties>
     </leafNode>
-    <leafNode name="route-map">
-      <properties>
-        <help>Route map reference</help>
-        <completionHelp>
-          <path>policy route-map</path>
-        </completionHelp>
-      </properties>
-    </leafNode>
+    #include <include/route-map.xml.i>
   </children>
 </node>
 <!-- include end -->
-- 
cgit v1.2.3


From 9560d26a8fb726ab100e7978a64942291e53a731 Mon Sep 17 00:00:00 2001
From: Christian Poessinger <christian@poessinger.com>
Date: Thu, 8 Apr 2021 17:16:22 +0200
Subject: xml: route-map: add missing constraints

Port over the regex used in the old node.def code-base and make this limitation
also live on the new CLI interface.
---
 interface-definitions/include/route-map.xml.i | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

(limited to 'interface-definitions/include')

diff --git a/interface-definitions/include/route-map.xml.i b/interface-definitions/include/route-map.xml.i
index 5a1c137b9..edbe76892 100644
--- a/interface-definitions/include/route-map.xml.i
+++ b/interface-definitions/include/route-map.xml.i
@@ -1,14 +1,18 @@
 <!-- include start from route-map.xml.i -->
 <leafNode name="route-map">
   <properties>
-    <help>Route map reference</help>
-    <valueHelp>
-      <format>txt</format>
-      <description>Route map reference</description>
-    </valueHelp>
+    <help>Specify route-map name to use</help>
     <completionHelp>
       <path>policy route-map</path>
     </completionHelp>
+    <valueHelp>
+      <format>txt</format>
+      <description>Route map name</description>
+    </valueHelp>
+    <constraint>
+      <regex>^[-a-zA-Z0-9.]+$</regex>
+    </constraint>
+    <constraintErrorMessage>Route-map name can only contain alpha-numeric letters and a hyphen</constraintErrorMessage>
   </properties>
 </leafNode>
 <!-- include end -->
-- 
cgit v1.2.3


From 4c3e1b1390e363e34b7e44e07b26e9bea355c659 Mon Sep 17 00:00:00 2001
From: Christian Poessinger <christian@poessinger.com>
Date: Thu, 8 Apr 2021 17:32:11 +0200
Subject: bgp: T2271: zebra route-map can only be set for default VRF

---
 interface-definitions/include/bgp/bgp-common-config.xml.i | 1 -
 interface-definitions/protocols-bgp.xml.in                | 1 +
 2 files changed, 1 insertion(+), 1 deletion(-)

(limited to 'interface-definitions/include')

diff --git a/interface-definitions/include/bgp/bgp-common-config.xml.i b/interface-definitions/include/bgp/bgp-common-config.xml.i
index c89e2288e..14070e006 100644
--- a/interface-definitions/include/bgp/bgp-common-config.xml.i
+++ b/interface-definitions/include/bgp/bgp-common-config.xml.i
@@ -824,7 +824,6 @@
     #include <include/bgp/bgp-update-source.xml.i>
   </children>
 </tagNode>
-#include <include/route-map.xml.i>
 <node name="timers">
   <properties>
     <help>BGP protocol timers</help>
diff --git a/interface-definitions/protocols-bgp.xml.in b/interface-definitions/protocols-bgp.xml.in
index d610f8dff..f4ebddb42 100644
--- a/interface-definitions/protocols-bgp.xml.in
+++ b/interface-definitions/protocols-bgp.xml.in
@@ -9,6 +9,7 @@
         </properties>
         <children>
           #include <include/bgp/bgp-common-config.xml.i>
+          #include <include/route-map.xml.i>
         </children>
       </node>
     </children>
-- 
cgit v1.2.3


From 32ac0dcf88f2b451d713b6eff7ab58d45565f8c8 Mon Sep 17 00:00:00 2001
From: Christian Poessinger <christian@poessinger.com>
Date: Thu, 8 Apr 2021 17:33:04 +0200
Subject: ospf: T2271: zebra route-map can only be set for default VRF

---
 interface-definitions/include/ospf/ospf-common-config.xml.i | 1 -
 interface-definitions/protocols-ospf.xml.in                 | 1 +
 2 files changed, 1 insertion(+), 1 deletion(-)

(limited to 'interface-definitions/include')

diff --git a/interface-definitions/include/ospf/ospf-common-config.xml.i b/interface-definitions/include/ospf/ospf-common-config.xml.i
index 7316af670..a01d1c890 100644
--- a/interface-definitions/include/ospf/ospf-common-config.xml.i
+++ b/interface-definitions/include/ospf/ospf-common-config.xml.i
@@ -697,7 +697,6 @@
     </leafNode>
   </children>
 </node>
-#include <include/route-map.xml.i>
 <node name="timers">
   <properties>
     <help>Adjust routing timers</help>
diff --git a/interface-definitions/protocols-ospf.xml.in b/interface-definitions/protocols-ospf.xml.in
index d9c3325ec..4431a1772 100644
--- a/interface-definitions/protocols-ospf.xml.in
+++ b/interface-definitions/protocols-ospf.xml.in
@@ -9,6 +9,7 @@
         </properties>
         <children>
           #include <include/ospf/ospf-common-config.xml.i>
+          #include <include/route-map.xml.i>
         </children>
       </node>
     </children>
-- 
cgit v1.2.3