From ba8630da96396f09c638fccdc9cfe6a3ee70fd58 Mon Sep 17 00:00:00 2001
From: Kim Hagen <kim@sentrium.io>
Date: Thu, 7 Oct 2021 08:44:00 -0500
Subject: pull request fixes

---
 interface-definitions/interfaces-openvpn.xml.in | 23 ++++++++++++++---------
 1 file changed, 14 insertions(+), 9 deletions(-)

(limited to 'interface-definitions/interfaces-openvpn.xml.in')

diff --git a/interface-definitions/interfaces-openvpn.xml.in b/interface-definitions/interfaces-openvpn.xml.in
index 62fac9be0..023f9f55d 100644
--- a/interface-definitions/interfaces-openvpn.xml.in
+++ b/interface-definitions/interfaces-openvpn.xml.in
@@ -635,14 +635,14 @@
                 </properties>
                 <defaultValue>net30</defaultValue>
               </leafNode>
-              <node name="2fa">
+              <node name="mfa">
                 <properties>
-                  <help>2-factor authentication</help>
+                  <help>multi-factor authentication</help>
                 </properties>
                 <children>
                   <node name="totp">
                     <properties>
-                      <help>Time-based One-Time Passwords</help>
+                      <help>Time-based one-time passwords</help>
                     </properties>
                     <children>
                       <leafNode name="slop">
@@ -656,10 +656,11 @@
                             <validator name="numeric" argument="--range 1-65535"/>
                           </constraint>
                         </properties>
+                        <defaultValue>180</defaultValue>
                       </leafNode>
                       <leafNode name="drift">
                         <properties>
-                          <help>time drift in seconds (default: 0)</help>
+                          <help>Time drift in seconds (default: 0)</help>
                           <valueHelp>
                             <format>1-65535</format>
                             <description>Seconds</description>
@@ -668,10 +669,11 @@
                             <validator name="numeric" argument="--range 1-65535"/>
                           </constraint>
                         </properties>
+                        <defaultValue>0</defaultValue>
                       </leafNode>
                       <leafNode name="step">
                         <properties>
-                          <help>Step value for TOTP in seconds (default: 30)</help>
+                          <help>Step value for totp in seconds (default: 30)</help>
                           <valueHelp>
                             <format>1-65535</format>
                             <description>Seconds</description>
@@ -680,10 +682,11 @@
                             <validator name="numeric" argument="--range 1-65535"/>
                           </constraint>
                         </properties>
+                        <defaultValue>30</defaultValue>
                       </leafNode>
                       <leafNode name="digits">
                         <properties>
-                          <help>Number of digits to use from TOTP hash (default: 6)</help>
+                          <help>Number of digits to use for totp hash (default: 6)</help>
                           <valueHelp>
                             <format>1-65535</format>
                             <description>Seconds</description>
@@ -692,25 +695,27 @@
                             <validator name="numeric" argument="--range 1-65535"/>
                           </constraint>
                         </properties>
+                        <defaultValue>6</defaultValue>
                       </leafNode>
                       <leafNode name="challenge">
                         <properties>
-                          <help>expect password as result of a challenge response protocol (default: enabled)</help>
+                          <help>Expect password as result of a challenge response protocol (default: enabled)</help>
                           <completionHelp>
                             <list>disable enable</list>
                           </completionHelp>
                           <valueHelp>
                             <format>disable</format>
-                            <description>Disable challenge response (default)</description>
+                            <description>Disable challenge-response</description>
                           </valueHelp>
                           <valueHelp>
                             <format>enable</format>
-                            <description>Enable chalenge response (default)</description>
+                            <description>Enable chalenge-response (default)</description>
                           </valueHelp>
                           <constraint>
                             <regex>^(disable|enable)$</regex>
                           </constraint>
                         </properties>
+                        <defaultValue>enable</defaultValue>
                       </leafNode>
                    </children>
                   </node>
-- 
cgit v1.2.3