From 6ffda0ee36db8f23d022119b5a532863fad4fbf2 Mon Sep 17 00:00:00 2001
From: Christian Poessinger <christian@poessinger.com>
Date: Mon, 20 Jun 2022 21:09:57 +0200
Subject: xml: T1748: cleanup <help> and </help> nodes not closing on the same
 line

Commit a6f82bb484 ("T1748: vbash: beautify tab completion output/line breaks")
added a method to split the help string and insert newlines and leading tabs
in a deterministic way.

This commit cleans up the legacy implementations where leading whitespaces got
counted and added by humans in a try/error method.
---
 interface-definitions/dhcp-server.xml.in         | 21 ++++-----------------
 interface-definitions/interfaces-openvpn.xml.in  | 10 ++--------
 interface-definitions/interfaces-wireless.xml.in |  4 +---
 3 files changed, 7 insertions(+), 28 deletions(-)

(limited to 'interface-definitions')

diff --git a/interface-definitions/dhcp-server.xml.in b/interface-definitions/dhcp-server.xml.in
index 0747d649a..6e1592200 100644
--- a/interface-definitions/dhcp-server.xml.in
+++ b/interface-definitions/dhcp-server.xml.in
@@ -67,10 +67,7 @@
           </node>
           <leafNode name="global-parameters">
             <properties>
-              <help>Additional global parameters for DHCP server. You must
-                use the syntax of dhcpd.conf in this text-field. Using this
-                without proper knowledge may result in a crashed DHCP server.
-                Check system log to look for errors.</help>
+              <help>Additional global parameters for DHCP server. You must use the syntax of dhcpd.conf in this text-field. Using this without proper knowledge may result in a crashed DHCP server. Check system log to look for errors.</help>
               <multi/>
             </properties>
           </leafNode>
@@ -111,10 +108,7 @@
               #include <include/name-server-ipv4.xml.i>
               <leafNode name="shared-network-parameters">
                 <properties>
-                  <help>Additional shared-network parameters for DHCP server.
-                You must use the syntax of dhcpd.conf in this text-field.
-                Using this without proper knowledge may result in a crashed
-                DHCP server. Check system log to look for errors.</help>
+                  <help>Additional shared-network parameters for DHCP server. You must use the syntax of dhcpd.conf in this text-field. Using this without proper knowledge may result in a crashed DHCP server. Check system log to look for errors.</help>
                   <multi/>
                 </properties>
               </leafNode>
@@ -347,11 +341,7 @@
                       </leafNode>
                       <leafNode name="static-mapping-parameters">
                         <properties>
-                          <help>Additional static-mapping parameters for DHCP server.
-                Will be placed inside the "host" block of the mapping.
-                You must use the syntax of dhcpd.conf in this text-field.
-                Using this without proper knowledge may result in a crashed
-                DHCP server. Check system log to look for errors.</help>
+                          <help>Additional static-mapping parameters for DHCP server. Will be placed inside the "host" block of the mapping. You must use the syntax of dhcpd.conf in this text-field. Using this without proper knowledge may result in a crashed DHCP server. Check system log to look for errors.</help>
                           <multi/>
                         </properties>
                       </leafNode>
@@ -385,10 +375,7 @@
                   </tagNode >
                   <leafNode name="subnet-parameters">
                     <properties>
-                      <help>Additional subnet parameters for DHCP server. You must
-                use the syntax of dhcpd.conf in this text-field. Using this
-                without proper knowledge may result in a crashed DHCP server.
-                Check system log to look for errors.</help>
+                      <help>Additional subnet parameters for DHCP server. You must use the syntax of dhcpd.conf in this text-field. Using this without proper knowledge may result in a crashed DHCP server. Check system log to look for errors.</help>
                       <multi/>
                     </properties>
                   </leafNode>
diff --git a/interface-definitions/interfaces-openvpn.xml.in b/interface-definitions/interfaces-openvpn.xml.in
index bfad6d70f..f1cbf8468 100644
--- a/interface-definitions/interfaces-openvpn.xml.in
+++ b/interface-definitions/interfaces-openvpn.xml.in
@@ -305,10 +305,7 @@
           </leafNode>
           <leafNode name="openvpn-option">
             <properties>
-              <help>Additional OpenVPN options. You must
-                use the syntax of openvpn.conf in this text-field. Using this
-                without proper knowledge may result in a crashed OpenVPN server.
-                Check system log to look for errors.</help>
+              <help>Additional OpenVPN options. You must use the syntax of openvpn.conf in this text-field. Using this without proper knowledge may result in a crashed OpenVPN server. Check system log to look for errors.</help>
               <multi/>
             </properties>
           </leafNode>
@@ -502,10 +499,7 @@
                   </leafNode>
                   <leafNode name="subnet-mask">
                     <properties>
-                      <help>Subnet mask pushed to dynamic clients.
-                If not set the server subnet mask will be used.
-                Only used with topology subnet or device type tap.
-                Not used with bridged interfaces.</help>
+                      <help>Subnet mask pushed to dynamic clients. If not set the server subnet mask will be used. Only used with topology subnet or device type tap. Not used with bridged interfaces.</help>
                       <constraint>
                         <validator name="ipv4-address"/>
                       </constraint>
diff --git a/interface-definitions/interfaces-wireless.xml.in b/interface-definitions/interfaces-wireless.xml.in
index eb6107303..daee770a9 100644
--- a/interface-definitions/interfaces-wireless.xml.in
+++ b/interface-definitions/interfaces-wireless.xml.in
@@ -716,9 +716,7 @@
                   </leafNode>
                   <leafNode name="passphrase">
                     <properties>
-                      <help>WPA personal shared pass phrase. If you are
-                using special characters in the WPA passphrase then single
-                quotes are required.</help>
+                      <help>WPA personal shared pass phrase. If you are using special characters in the WPA passphrase then single quotes are required.</help>
                       <valueHelp>
                         <format>txt</format>
                         <description>Passphrase of at least 8 but not more than 63 printable characters</description>
-- 
cgit v1.2.3