From 707641f4dc947bce84eeff5499665e1cf76d7806 Mon Sep 17 00:00:00 2001
From: Viacheslav Hletenko <v.gletenko@vyos.io>
Date: Tue, 14 Mar 2023 18:45:04 +0000
Subject: T5086: Add sFlow feature based on hsflowd

Add sFlow feature based on hsflowd
According to user reviews, it works more stable and more productive
than pmacct
I haven't deleted 'pmacct' 'system flow-accounting sflow' yet
It could be migrated or deprecated later

  set system sflow agent-address '192.0.2.14'
  set system sflow interface 'eth0'
  set system sflow interface 'eth1'
  set system sflow polling '30'
  set system sflow sampling-rate '100'
  set system sflow server 192.0.2.1 port '6343'
  set system sflow server 192.0.2.11 port '6343'
---
 smoketest/scripts/cli/test_system_sflow.py | 93 ++++++++++++++++++++++++++++++
 1 file changed, 93 insertions(+)
 create mode 100755 smoketest/scripts/cli/test_system_sflow.py

(limited to 'smoketest/scripts/cli/test_system_sflow.py')

diff --git a/smoketest/scripts/cli/test_system_sflow.py b/smoketest/scripts/cli/test_system_sflow.py
new file mode 100755
index 000000000..b593c21e6
--- /dev/null
+++ b/smoketest/scripts/cli/test_system_sflow.py
@@ -0,0 +1,93 @@
+#!/usr/bin/env python3
+#
+# Copyright (C) 2023 VyOS maintainers and contributors
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License version 2 or later as
+# published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+import unittest
+
+from base_vyostest_shim import VyOSUnitTestSHIM
+
+from vyos.configsession import ConfigSessionError
+from vyos.ifconfig import Section
+from vyos.util import cmd
+from vyos.util import process_named_running
+from vyos.util import read_file
+
+PROCESS_NAME = 'hsflowd'
+base_path = ['system', 'sflow']
+
+hsflowd_conf = '/run/sflow/hsflowd.conf'
+
+
+class TestSystemFlowAccounting(VyOSUnitTestSHIM.TestCase):
+
+    @classmethod
+    def setUpClass(cls):
+        super(TestSystemFlowAccounting, cls).setUpClass()
+
+        # ensure we can also run this test on a live system - so lets clean
+        # out the current configuration :)
+        cls.cli_delete(cls, base_path)
+
+    def tearDown(self):
+        # after service removal process must no longer run
+        self.assertTrue(process_named_running(PROCESS_NAME))
+
+        self.cli_delete(base_path)
+        self.cli_commit()
+
+        # after service removal process must no longer run
+        self.assertFalse(process_named_running(PROCESS_NAME))
+
+    def test_sflow(self):
+        agent_address = '192.0.2.5'
+        agent_interface = 'eth0'
+        polling = '24'
+        sampling_rate = '128'
+        server = '192.0.2.254'
+        port = '8192'
+
+        self.cli_set(
+            ['interfaces', 'dummy', 'dum0', 'address', f'{agent_address}/24'])
+        self.cli_set(base_path + ['agent-address', agent_address])
+        self.cli_set(base_path + ['agent-interface', agent_interface])
+
+        # You need to configure at least one interface for sflow
+        with self.assertRaises(ConfigSessionError):
+            self.cli_commit()
+        for interface in Section.interfaces('ethernet'):
+            self.cli_set(base_path + ['interface', interface])
+
+        self.cli_set(base_path + ['polling', polling])
+        self.cli_set(base_path + ['sampling-rate', sampling_rate])
+        self.cli_set(base_path + ['server', server, 'port', port])
+
+        # commit changes
+        self.cli_commit()
+
+        # verify configuration
+        hsflowd = read_file(hsflowd_conf)
+
+        self.assertIn(f'polling={polling}', hsflowd)
+        self.assertIn(f'sampling={sampling_rate}', hsflowd)
+        self.assertIn(f'agentIP={agent_address}', hsflowd)
+        self.assertIn(f'agent={agent_interface}', hsflowd)
+        self.assertIn(f'collector {{ ip = {server} udpport = {port} }}', hsflowd)
+
+        for interface in Section.interfaces('ethernet'):
+            self.assertIn(f'pcap {{ dev={interface} }}', hsflowd)
+
+
+if __name__ == '__main__':
+    unittest.main(verbosity=2)
-- 
cgit v1.2.3