From 85e0b4b8a72f7f911f5ab8faaf16757e122b59e8 Mon Sep 17 00:00:00 2001 From: John Estabrook Date: Wed, 30 Sep 2020 17:01:03 -0500 Subject: configd: T2582: remove unused variables --- src/services/vyos-configd | 3 --- 1 file changed, 3 deletions(-) (limited to 'src/services/vyos-configd') diff --git a/src/services/vyos-configd b/src/services/vyos-configd index 642952936..fcd119df9 100755 --- a/src/services/vyos-configd +++ b/src/services/vyos-configd @@ -59,9 +59,6 @@ configd_env_unset_file = os.path.join(directories['data'], 'vyos-configd-env-uns # sourced on entering config session configd_env_file = '/etc/default/vyos-configd-env' -active_string = '' -session_string = '' - session_tty = None def key_name_from_file_name(f): -- cgit v1.2.3 From e58a5831c1c0ca2d9e4954007f4adbd660c20f1c Mon Sep 17 00:00:00 2001 From: John Estabrook Date: Wed, 30 Sep 2020 17:13:36 -0500 Subject: configd: T2582: catch config initialization errors --- src/services/vyos-configd | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) (limited to 'src/services/vyos-configd') diff --git a/src/services/vyos-configd b/src/services/vyos-configd index fcd119df9..d838bd064 100755 --- a/src/services/vyos-configd +++ b/src/services/vyos-configd @@ -27,7 +27,7 @@ import importlib.util import zmq from vyos.defaults import directories -from vyos.configsource import ConfigSourceString +from vyos.configsource import ConfigSourceString, ConfigSourceError from vyos.config import Config from vyos import ConfigError @@ -151,8 +151,12 @@ def initialization(socket): except FileNotFoundError: session_tty = None - configsource = ConfigSourceString(running_config_text=active_string, - session_config_text=session_string) + try: + configsource = ConfigSourceString(running_config_text=active_string, + session_config_text=session_string) + except ConfigSourceError as e: + logger.debug(e) + return None config = Config(config_source=configsource) -- cgit v1.2.3 From 858143739cece6eee0cf13a6a3e1fcffa70928bb Mon Sep 17 00:00:00 2001 From: John Estabrook Date: Fri, 2 Oct 2020 11:01:17 -0500 Subject: configd: T2952: synchronize received messages in case of client timeout --- src/services/vyos-configd | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) (limited to 'src/services/vyos-configd') diff --git a/src/services/vyos-configd b/src/services/vyos-configd index d838bd064..671a89036 100755 --- a/src/services/vyos-configd +++ b/src/services/vyos-configd @@ -134,8 +134,19 @@ def initialization(socket): # Reset config strings: active_string = '' session_string = '' + # check first for resent init msg, in case of client timeout + while True: + msg = socket.recv().decode() + try: + message = json.loads(msg) + if message["type"] == "init": + resp = "init" + socket.send(resp.encode()) + except: + break + # zmq synchronous for ipc from single client: - active_string = socket.recv().decode() + active_string = msg resp = "active" socket.send(resp.encode()) session_string = socket.recv().decode() -- cgit v1.2.3