(mirror of https://github.com/marekm72/vyos-cloud-init.git) https://git.amelek.net/marekm72/vyos-cloud-init.git/atom?h=20.4 2020-11-13T16:56:53+00:00 2020-11-13T16:56:53+00:00 Daniel Watkins oddbloke@ubuntu.com 2020-11-13T16:56:53+00:00 urn:sha1:38ba6b3087829a30c9888e60f5f6c6812ae5cfc7 2020-10-30T20:12:38+00:00 dermotbradley dermot_bradley@yahoo.com 2020-10-30T20:12:38+00:00 urn:sha1:f8c84aeead77b7e508644d94889ee701f20e8d31 For cc_users_groups the user setting "expiredate" must be quoted in order for the relevant flag and value to be then passed to the useradd command. It its vaiue is not quoted then it is treated as Python type datetime.date and in `cloudinit/distros/__init__.py` the below "is it a string" condition fails and so no "--expiredate" parameter is passed to useradd and therefore it has no effect: ``` if key in useradd_opts and val and isinstance(val, str): useradd_cmd.extend([useradd_opts[key], val]) ``` For cc_users_groups, the user setting "inactive" does not actually disable accounts, the useradd "--inactive" option actually defines the number of days after password expiry that users can still login. So I have changed the docs to show it taking a quoted value of days (which works with the current code) rather than a boolean value. The quotes are necessary, like expiredate above, so that the value is also passed to the useradd command. For cc_power_state_change.py the "delay" setting value needs to have quotes around it as otherwise its leading plus sign will be stripped off. 2020-08-25T15:21:18+00:00 Paride Legovini paride.legovini@canonical.com 2020-08-25T15:21:18+00:00 urn:sha1:07104504ab5b30efd2d1f7a8c36effe18b8e5fe0 Changes: tox: bump the pylint version to 2.6.0 in the default run Fix pylint 2.6.0 W0707 warnings (raise-missing-from) 2020-07-15T14:26:12+00:00 Daniel Watkins oddbloke@ubuntu.com 2020-07-15T14:26:12+00:00 urn:sha1:4fe576516d65feda17ba78e9265a8e494a195e7b * cloudinit: remove global disable of pylint W0107 and fix errors This includes removing a test class which contained no tests but wasn't detected as empty because of an errant pass statement. * .pylintrc: update disable comment to match arguments 2020-07-09T15:21:34+00:00 Paride Legovini paride.legovini@canonical.com 2020-07-09T15:21:34+00:00 urn:sha1:e753141fc7844e68b1f380d26fb3d250eb464ff7 Update lxd_export method to detect and handle different image formats cloud_tests will only support the "split" type images which exports a compressed (xz) tarball of metadata and a rootfs (of different formats). For non-split image formats (single tarball with metadata + rootfs) we now raise an exception indicating that the requested image is not supported at this time. 2020-06-30T20:04:47+00:00 Daniel Watkins oddbloke@ubuntu.com 2020-06-30T20:04:47+00:00 urn:sha1:e88f15a3bca93c82eb02c13e87f2b6839385639b We dropped that parameter in 4d26848 2020-06-10T14:39:29+00:00 Joshua Powers josh.powers@canonical.com 2020-06-10T14:39:29+00:00 urn:sha1:f3bd42659efeed4b092ffcdfd5df7f24813f2d3e 2020-06-08T16:49:12+00:00 Scott Moser smoser@brickies.net 2020-06-08T16:49:12+00:00 urn:sha1:3c551f6ebc12f7729a2755c89b19b9000e27cc88 This was painful, but it finishes a TODO from cloudinit/subp.py. It moves the following from util to subp: ProcessExecutionError subp which target_path I moved subp_blob_in_tempfile into cc_chef, which is its only caller. That saved us from having to deal with it using write_file and temp_utils from subp (which does not import any cloudinit things now). It is arguable that 'target_path' could be moved to a 'path_utils' or something, but in order to use it from subp and also from utils, we had to get it out of utils. 2020-06-01T21:20:39+00:00 Joshua Powers josh.powers@canonical.com 2020-06-01T21:20:39+00:00 urn:sha1:4ab3303ec4bb49f029b7821d6dba53a6b02b6dc1 This removes the use of variables named ‘l’, ‘O’, or ‘I’. Generally these are used in list comprehension to read the line of lines. 2020-05-28T19:55:35+00:00 Chad Smith chad.smith@canonical.com 2020-05-28T19:55:35+00:00 urn:sha1:1211ab449bdfa34b8883c7386772155e6a516ebb