(mirror of https://github.com/marekm72/vyos-cloud-init.git) https://git.amelek.net/marekm72/vyos-cloud-init.git/atom?h=current 2021-12-03T20:11:46+00:00 2021-12-03T20:11:46+00:00 Brett Holman bholman.devel@gmail.com 2021-12-03T20:11:46+00:00 urn:sha1:039c40f9b3d88ee8158604bb18ca4bf2fb5d5e51 This attempts to standardize unit test file location under test/unittests/ such that any source file located at cloudinit/path/to/file.py may have a corresponding unit test file at test/unittests/path/to/test_file.py. Noteworthy Comments: ==================== Four different duplicate test files existed: test_{gpg,util,cc_mounts,cc_resolv_conf}.py Each of these duplicate file pairs has been merged together. This is a break in git history for these files. The test suite appears to have a dependency on test order. Changing test order causes some tests to fail. This should be rectified, but for now some tests have been modified in tests/unittests/config/test_set_passwords.py. A helper class name starts with "Test" which causes pytest to try executing it as a test case, which then throws warnings "due to Class having __init__()". Silence by changing the name of the class. # helpers.py is imported in many test files, import paths change cloudinit/tests/helpers.py -> tests/unittests/helpers.py # Move directories: cloudinit/distros/tests -> tests/unittests/distros cloudinit/cmd/devel/tests -> tests/unittests/cmd/devel cloudinit/cmd/tests -> tests/unittests/cmd/ cloudinit/sources/helpers/tests -> tests/unittests/sources/helpers cloudinit/sources/tests -> tests/unittests/sources cloudinit/net/tests -> tests/unittests/net cloudinit/config/tests -> tests/unittests/config cloudinit/analyze/tests/ -> tests/unittests/analyze/ # Standardize tests already in tests/unittests/ test_datasource -> sources test_distros -> distros test_vmware -> sources/vmware test_handler -> config # this contains cloudconfig module tests test_runs -> runs 2021-11-22T22:56:41+00:00 James Falcon james.falcon@canonical.com 2021-11-22T22:56:41+00:00 urn:sha1:31daf6670aeeba1d452c70bc0d4d04139652be36 testing: monkeypatch system_info call in unit tests system_info can make calls that read or write from the filesystem, which should require special mocking. It is also decorated with 'lru_cache', which means test authors often don't realize they need to be mocking. Also, we don't actually want the results from the user's local machine, so monkeypatching it across all tests should be reasonable. Additionally, moved some of 'system_info` into a helper function to reduce the surface area of the monkeypatch, added tests for the new function (and fixed a bug as a result), and removed related mocks that should be no longer needed. 2021-11-17T18:35:00+00:00 Brett Holman brett.holman@canonical.com 2021-11-17T18:35:00+00:00 urn:sha1:7f03da357e4e72f7fe09e9b35b23ba1d83477f6c Add growpart integration test and associated unit tests Additionally, a small runcmd check for a commented line. 2021-11-09T15:28:19+00:00 James Falcon james.falcon@canonical.com 2021-11-09T15:28:19+00:00 urn:sha1:3d150688617e2b8a16d715c7fb819c759f91915a Currently any attempt to run an apt command while another process holds an apt lock will fail. We should instead wait to acquire the apt lock. LP: #1944611 2021-10-29T20:39:29+00:00 James Falcon james.falcon@canonical.com 2021-10-29T20:39:29+00:00 urn:sha1:a90d8338f07b30a46887f7c133baade63129a53a When we added the install hotplug module, we forgot to update the redhet/cloud-init.spec.in file and allow for execution on /usr/libexec. This PR adds that functionality. 2021-10-29T19:33:33+00:00 Brett Holman brett.holman@canonical.com 2021-10-29T19:33:33+00:00 urn:sha1:28581988da4b37e3d2423075c64dc1f3bc5da5cc Also, add the "signed by" option to source definitions. This enables users to limit the scope of trust for individual keys. LP: #1836336 2021-10-27T14:43:34+00:00 James Falcon james.falcon@canonical.com 2021-10-27T14:43:34+00:00 urn:sha1:1d01da5d9916d97ef463ba61a36b3f98f8911419 This commit removes automatically installing udev rules for hotplug and adds a module to install them instead. Automatically including the udev rules and checking if hotplug was enabled consumed too many resources in certain circumstances. Moving the rules to a module ensures we don't spend extra extra cycles on hotplug if hotplug functionality isn't desired. LP: #1946003 2021-10-25T19:31:07+00:00 Lucendio github+dev@lucendio.com 2021-10-25T19:31:07+00:00 urn:sha1:a4236c375ddf78258a8f9252c1d79c665aa4f88b The main idea is to introduce a second module that takes care of writing files, but in the 'final' stage. While the introduction of a second module would allow for choosing the appropriate place withing the order of modules (and stages), there is no addition top-level directive being added to the cloud configuration schema. Instead, 'write-files' schema is being extended to include a 'defer' attribute used only by the 'write-deffered-files' modules. The new module 'write-deferred-files' reuses as much as possible of the 'write-files' functionality. 2021-10-23T03:06:51+00:00 James Falcon james.falcon@canonical.com 2021-10-23T03:06:51+00:00 urn:sha1:2db713346d656c3486228678ad020b56440c1e34 In jsonschema 4, hostname validation was changed to have an optional dependency on the fqdn package. Since we don't have this dependency in cloud-init, attempting this validation will no longer fail for a string that isn't a valid hostname. 2021-10-20T20:58:27+00:00 Andy Fiddaman omnios@citrus-it.co.uk 2021-10-20T20:58:27+00:00 urn:sha1:8c89009e75c7cf6c2f87635b82656f07f58095e1 Various modules restart services and they all have logic to try and detect if they are running on a system that needs 'systemctl' or 'service', and then have code to decide which order the arguments need to be etc. On top of that, not all modules do this in the same way. The duplication and different approaches are not ideal but this also makes it hard to add support for a new distribution that does not use either 'systemctl' or 'service'. This change adds a new manage_service() method to the distro class and updates several modules to use it.