summaryrefslogtreecommitdiff
path: root/tests/cloud_tests
diff options
context:
space:
mode:
authorJoshua Powers <josh.powers@canonical.com>2017-04-06 11:14:29 -0700
committerScott Moser <smoser@ubuntu.com>2017-04-21 10:14:47 -0400
commit5afe4cd0797a12d07ea19b9715b720d47bdea401 (patch)
tree8be9e7b623002b1fd60fb21b95696ab6b67ca497 /tests/cloud_tests
parent33816e96d8981918f734dab3ee1a967bce85451a (diff)
downloadvyos-cloud-init-5afe4cd0797a12d07ea19b9715b720d47bdea401.tar.gz
vyos-cloud-init-5afe4cd0797a12d07ea19b9715b720d47bdea401.zip
pylint: fix all logging warnings
This will change all instances of LOG.warn to LOG.warning as warn is now a deprecated method. It will also make sure any logging uses lazy logging by passing string format arguments as function parameters.
Diffstat (limited to 'tests/cloud_tests')
-rw-r--r--tests/cloud_tests/__main__.py2
-rw-r--r--tests/cloud_tests/args.py2
-rw-r--r--tests/cloud_tests/collect.py2
-rw-r--r--tests/cloud_tests/verify.py9
4 files changed, 8 insertions, 7 deletions
diff --git a/tests/cloud_tests/__main__.py b/tests/cloud_tests/__main__.py
index ef7d1878..ed654ad3 100644
--- a/tests/cloud_tests/__main__.py
+++ b/tests/cloud_tests/__main__.py
@@ -38,7 +38,7 @@ def run(args):
finally:
# TODO: make this configurable via environ or cmdline
if failed:
- LOG.warn('some tests failed, leaving data in %s', args.data_dir)
+ LOG.warning('some tests failed, leaving data in %s', args.data_dir)
else:
shutil.rmtree(args.data_dir)
return failed
diff --git a/tests/cloud_tests/args.py b/tests/cloud_tests/args.py
index b68cc98e..371b0444 100644
--- a/tests/cloud_tests/args.py
+++ b/tests/cloud_tests/args.py
@@ -94,7 +94,7 @@ def normalize_create_args(args):
if os.path.exists(config.name_to_path(args.name)):
msg = 'test: {} already exists'.format(args.name)
if args.force:
- LOG.warn('%s but ignoring due to --force', msg)
+ LOG.warning('%s but ignoring due to --force', msg)
else:
LOG.error(msg)
return None
diff --git a/tests/cloud_tests/collect.py b/tests/cloud_tests/collect.py
index 68b47d7a..02fc0e52 100644
--- a/tests/cloud_tests/collect.py
+++ b/tests/cloud_tests/collect.py
@@ -45,7 +45,7 @@ def collect_test_data(args, snapshot, os_name, test_name):
# if test is not enabled, skip and return 0 failures
if not test_config.get('enabled', False):
- LOG.warn('test config %s is not enabled, skipping', test_name)
+ LOG.warning('test config %s is not enabled, skipping', test_name)
return ({}, 0)
# create test instance
diff --git a/tests/cloud_tests/verify.py b/tests/cloud_tests/verify.py
index ef7d4e21..2a63550e 100644
--- a/tests/cloud_tests/verify.py
+++ b/tests/cloud_tests/verify.py
@@ -45,9 +45,9 @@ def verify_data(base_dir, tests):
}
for failure in res[test_name]['failures']:
- LOG.warn('test case: %s failed %s.%s with: %s',
- test_name, failure['class'], failure['function'],
- failure['error'])
+ LOG.warning('test case: %s failed %s.%s with: %s',
+ test_name, failure['class'], failure['function'],
+ failure['error'])
return res
@@ -80,7 +80,8 @@ def verify(args):
if len(fail_list) == 0:
LOG.info('test: %s passed all tests', test_name)
else:
- LOG.warn('test: %s failed %s tests', test_name, len(fail_list))
+ LOG.warning('test: %s failed %s tests', test_name,
+ len(fail_list))
failed += len(fail_list)
# dump results