diff options
| author | Roberto Bertó <463349+robertoberto@users.noreply.github.com> | 2026-05-19 02:32:04 +0000 |
|---|---|---|
| committer | Roberto Bertó <463349+robertoberto@users.noreply.github.com> | 2026-05-19 02:32:04 +0000 |
| commit | 0f76bcc7179976e893b1d9f296b1b1e7988b0031 (patch) | |
| tree | 87fa89da92263bbe2af7303a0ab36433fdc6f5d3 /pyvyos/exceptions.py | |
| parent | ffd5ba16eb1ada42a582db4ac8bdaf29f66a868f (diff) | |
| download | pyvyos-0f76bcc7179976e893b1d9f296b1b1e7988b0031.tar.gz pyvyos-0f76bcc7179976e893b1d9f296b1b1e7988b0031.zip | |
refactor: remove unused specs, exceptions, and request_id
The pyvyos.specs Pydantic models were never imported by the runtime and
had 0% test coverage. The pyvyos.exceptions hierarchy was defined but
never raised anywhere. The request_id helper generated UUIDs that were
attached to log records but never propagated to callers — half-implemented
tracing is worse than none.
This commit does not alter request/response logic or HTTP payloads. It
only removes code that was never executed and tests for that code.
Removed:
- pyvyos/specs/ (Pydantic models package)
- pyvyos/exceptions.py (SDKError, HttpError, ApiError, ValidationError)
- pyvyos/utils/ids.py (request_id helper)
- tests/test_exceptions.py
- tests/utils/test_ids.py
Edited:
- pyvyos/core/rest_client.py: drop request_id import and log extras
- pyvyos/utils/__init__.py: drop request_id export
Tests: 66 -> 57 passing. Coverage: 54% -> 87%.
Public API unchanged.
Diffstat (limited to 'pyvyos/exceptions.py')
| -rw-r--r-- | pyvyos/exceptions.py | 33 |
1 files changed, 0 insertions, 33 deletions
diff --git a/pyvyos/exceptions.py b/pyvyos/exceptions.py deleted file mode 100644 index 5a79733..0000000 --- a/pyvyos/exceptions.py +++ /dev/null @@ -1,33 +0,0 @@ -"""PyVyOS exception hierarchy for typed error handling.""" - - -class SDKError(Exception): - """Base exception for all PyVyOS SDK errors.""" - pass - - -class HttpError(SDKError): - """HTTP-level errors (network, timeout, status codes).""" - - def __init__(self, status: int, message: str): - self.status = status - self.message = message - super().__init__(f"HTTP Error {status}: {message}") - - -class ApiError(SDKError): - """API-level errors (when VyOS API returns success=False).""" - - def __init__(self, message: str, details: dict = None): - self.message = message - self.details = details - super().__init__(message) - - -class ValidationError(SDKError): - """Client-side validation errors (invalid parameters).""" - - def __init__(self, message: str): - self.message = message - super().__init__(message) - |
