From bfcaffe9c55b687038eab337a718ea0a43f5e668 Mon Sep 17 00:00:00 2001
From: Roberto Bertó <463349+robertoberto@users.noreply.github.com>
Date: Tue, 19 May 2026 06:05:43 +0000
Subject: tests: add live VyOS e2e harness on Proxmox

Adds an opt-in end-to-end harness that runs pyvyos against a real
VyOS HTTPS API on a Proxmox VE host.

  tests/pve/      shell-based VM lifecycle on a remote PVE host:
                  preflight, ensure-template (state-machine over the
                  VMID with manual-install phase 1 and cloud-init
                  phase 2), create/start/stop/destroy, run-e2e.
                  Cloud-init seed ISO is generated on the PVE host
                  itself; nothing local-side beyond ssh is required.
                  .env is gitignored; .env.example documents the
                  full set of variables.

  tests/e2e/      pytest suite that exercises the public methods
                  most likely to regress on a payload change:
                  show, retrieve_show_config, configure_set /
                  retrieve_return_values / configure_delete round
                  trip, and configure_multiple_op batch. Auto-skipped
                  unless PYVYOS_E2E=1.

The cloud-init template now sets 'service https api rest' before
the API key. Without that flag VyOS only exposes /info; the other
HTTPS routes return 404. README and tests/pve/README document the
requirement, both for cloud-init and for the manual-fallback path.

Also fixes a pre-existing footgun in pyproject.toml: the pytest-env
defaults overwrote VYDEVICE_HOSTNAME from the shell, which made
the e2e tests silently aim at the stale 192.168.56.100 fixture
host. The entries now use the 'D:' (default) prefix so live runs
can override from the environment as expected.

Validated against VyOS rolling 2026.05.18-0045: 4 e2e + 57 unit
tests pass.

This commit does not change pyvyos HTTP payloads, request handling,
or response parsing.
---
 tests/pve/cloud-init/user-data.template | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
 create mode 100644 tests/pve/cloud-init/user-data.template

(limited to 'tests/pve/cloud-init/user-data.template')

diff --git a/tests/pve/cloud-init/user-data.template b/tests/pve/cloud-init/user-data.template
new file mode 100644
index 0000000..d1ac0ee
--- /dev/null
+++ b/tests/pve/cloud-init/user-data.template
@@ -0,0 +1,14 @@
+#cloud-config
+# VyOS NoCloud user-data baked into the template.
+#
+# Placeholders replaced at render time by ensure-template.sh:
+#   __APIKEY__   pyvyos HTTPS API key
+#   __HOSTNAME__ initial system hostname
+
+vyos_config_commands:
+  - set system host-name '__HOSTNAME__'
+  - set service https api rest
+  - set service https api keys id pyvyos key '__APIKEY__'
+  - set service https listen-address '0.0.0.0'
+  - set service https port '443'
+  - set service ssh port '22'
-- 
cgit v1.2.3