veeos-1x.git/src/services/vyos-configd, branch currentVyOS command definitions, scripts, and utilities (mirror of https://github.com/vyos-contrib/veeos-1x.git)
https://git.amelek.net/vyos-contrib/veeos-1x.git/atom?h=current2025-01-31T18:06:46+00:00configd: T7119: fix misleading debug messages2025-01-31T18:06:46+00:00John Estabrookjestabro@vyos.io2025-01-31T17:31:26+00:00urn:sha1:213440666e0d2379ed3e686e0e66ec535d0c4d45
An artifact of T6899 included a report of 'error_code 1' on success: for
consistency with shim error codes 1 == SUCCESS, however, the debug
message is misleading and is here corrected.
configd: T7119: normalize formatting2025-01-31T18:06:46+00:00John Estabrookjestabro@vyos.io2025-01-31T17:29:37+00:00urn:sha1:0f0fb0415227444d8465d502bbac030b1ab0be13configd: T6747: use one long-lived instance of FRRender (#4274)2025-01-06T17:05:06+00:00Christian Breunigchristian@breunig.cc2025-01-06T17:05:06+00:00urn:sha1:f9f4137d09564da90a18fec9c9d7ceb64cb6c736
* smoketest: T6747: call wait after commit() only for FRR related tests
Commit 702a60a8de28 ("smoketest: T6746: wait after commit() until frr-reload
is no longer running") added a guard timeout for every commit executed via CLI
smoketests. This commit changes the bahavior to only add the guard timeout
for FRR related testscases.
This improves the overall smoketest time.
* configd: T6747: use one long-lived instance of FRRender
Previously there was one FRRender() instance per config session. This resulted
in re-rendering the FRR configuration every time a new config session was
created.
Example:
vyos@vyos:~$ configure
vyos@vyos# set interfaces dummy dum0 description foo
vyos@vyos# commit
vyos@vyos# exit
vyos@vyos:~$ configure
vyos@vyos# set interfaces dummy dum0 description bar
vyos@vyos# commit
vyos@vyos# exit
In the past this caused a re-render of the FRR configuration as the delta check
added in commit ec80c75d6776 ("frrender: T6746: only re-render FRR config if
config_dict did change") evaluated to false, as it operated on a new instance
of the FRRender class.
With this change there is no FRR re-render, as there is nothing to update
in FRR.frr: T6746: additional improvements after 10.2 upgrade (#4259)2024-12-30T19:35:08+00:00Christian Breunigchristian@breunig.cc2024-12-30T19:35:08+00:00urn:sha1:ec80c75d677608da438a9360657d9729296afc73
* smoketest: T6746: add substring search in getFRRconfig()
Some daemons (e.g. bgpd) have several nested substrings/sections like
router bgp 100
address-family ipv4 unicast
..
exit-address-family
exit
We can now use getFRRconfig() with the substring option to extract only
address-family ipv4 unicast
..
exit-address-family
Making config validation more granular
* frrender: T6746: only re-render FRR config if config_dict did change
* frrender: T6746: fix naming glitch isis/eigrp
* frrender: T6746: add --stdout option when running with debug flags
* smoketest: T6746: remove unneeded commit_guard time
It was an invalid workarround as the underlaying issue seems to be a race
condition in CStore.
The commit process is not finished until all pending files from
VYATTA_CHANGES_ONLY_DIR are copied to VYATTA_ACTIVE_CONFIGURATION_DIR. This is
done inside libvyatta-cfg1 and the FUSE UnionFS part. On large non-interactive
commits FUSE UnionFS might not replicate the real state in time, leading to
errors when querying the working and effective configuration.
TO BE DELETED AFTER SWITCH TO IN MEMORY CONFIGfrrender: T6746: move get_frrender_dict from vyos.configdict to this module2024-12-18T21:40:05+00:00Christian Breunigchristian@breunig.cc2024-12-18T18:25:20+00:00urn:sha1:77628e49379066e07b4046a00007187263e7206b
Keep all FRRender stuff in one place.
vyos-configd: T6746: render resulting FRR configuration only once2024-12-18T18:17:33+00:00Christian Breunigchristian@breunig.cc2024-12-18T18:17:33+00:00urn:sha1:75de2fa91c7d727eef9d38d045e0e04fba218695
Previously the FRR configuration was rendered via Jinja2 on every call to
get_frrendet_dict() - but it was used/applied only once.
We save the CPU cycles and render the FRR configuration only once prior to
applying it in FRR.
configd: T6746: handle FRR config reload as last step in commit2024-12-16T21:24:50+00:00Christian Breunigchristian@breunig.cc2024-12-11T19:14:45+00:00urn:sha1:55683a8406e17408021437cb35b57c48bd8b2ab1frr: T6746: integrate FRRender class into vyos-configd2024-12-16T21:24:50+00:00Christian Breunigchristian@breunig.cc2024-12-08T15:33:45+00:00urn:sha1:779f311e7fe81e3c85de28f13e4e12e33b255483
When running under vyos-configd only a single apply() is done as last step in
the commit algorithm. FRRender class address is provided via an attribute from
vyos-configd process.
configd: T6899: use multipart message instead of extra exchange2024-11-19T12:46:09+00:00John Estabrookjestabro@vyos.io2024-11-18T21:37:05+00:00urn:sha1:f38a402f158dad178165e330f292393278705281configd: T6608: report uncaught config script exceptions as commit error2024-09-22T14:19:57+00:00John Estabrookjestabro@vyos.io2024-09-21T01:46:24+00:00urn:sha1:5034db86b8c43846475e9876116e55a189fe7d06
In the case of config mode script exceptions other than ConfigError,
vyos-configd would previously trigger the shim to re-run the script in
the CLI context. The use of config dependencies require this case to
return a commit error. A traceback is returned as output, consistent
with running without vyos-configd support.