From 0fe71baced34addf6fe4ec642f3e5f8cbfe75a3c Mon Sep 17 00:00:00 2001 From: Yuriy Andamasov Date: Tue, 12 May 2026 10:15:07 +0300 Subject: T8764: skip auto-review of mergify[bot] backport PRs MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Adds `mergify[bot]` to `reviews.auto_review.ignore_usernames` in the central `vyos`-org CodeRabbit baseline. Mergify-opened backport PRs are mechanical cherry-picks of an already-reviewed source PR; re-reviewing them adds no signal and burns CodeRabbit's rate-limit budget. Manual `@coderabbitai review` continues to work for the rare case where a maintainer wants a fresh review on a backport PR (e.g. to confirm a conflict resolution was handled correctly after a non-clean cherry-pick). Behavior change observed today (2026-05-12): - vyos/vyos-documentation#2006 (sagitta) and #2007 (circinus) were auto-opened by Mergify as backports of #2005. Both got CodeRabbit auto-reviews despite being byte-equivalent to the already-reviewed source PR. This change suppresses that. Scope: central `vyos`-org baseline only. Mirror change on `VyOS-Networks/coderabbit:.coderabbit.yaml`. Related: T8782 (Mergify central-config rollout) — Mergify is the generator of these PRs; this is housekeeping on the CodeRabbit side. 🤖 Generated by [robots](https://vyos.io) --- .coderabbit.yaml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/.coderabbit.yaml b/.coderabbit.yaml index 381046e..3fe3d8d 100644 --- a/.coderabbit.yaml +++ b/.coderabbit.yaml @@ -38,6 +38,14 @@ reviews: - WIP - DO NOT MERGE - Bump + # Skip auto-review for PRs authored by these accounts. Manual + # `@coderabbitai review` still works if a human asks for one. The list + # targets bots that open mechanical PRs whose content was already + # reviewed upstream (e.g. Mergify cherry-picks the merge commit of an + # already-reviewed source PR, so re-reviewing the backport adds no + # signal and burns rate limit). + ignore_usernames: + - "mergify[bot]" path_filters: - "!**/*.lock" -- cgit v1.2.3 From a2d59fd77e808b041b68c80aa4b545f8625e0f9c Mon Sep 17 00:00:00 2001 From: Yuriy Andamasov Date: Tue, 12 May 2026 11:00:00 +0300 Subject: T8764: lift Org-UI Web dashboard settings into central baseline MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Moves every CodeRabbit setting currently configured in the `vyos`-org Web UI dashboard ("Organization UI Settings", precedence #5) into the Central YAML (precedence #3) so the file is the single source of truth for review behavior in the `vyos` org. Once this lands, the Org-UI YAML editor can be cleared and behavior will be unchanged. Why this matters: precedence rules state that Central YAML overrides Organization UI per-field. Today they happen to agree, but any future edit to the Web UI silently drifts from the file. Consolidating into YAML makes drift a code-review-visible event. Lifted fields: * Top-level: - `early_access: false` -> `true` (matches Web UI explicit value) * `reviews:` - `high_level_summary_in_walkthrough: true` - `review_details: true` - `fail_commit_status: true` - `estimate_code_review_effort: false` - `in_progress_fortune: false` * `reviews.auto_review:` - `auto_pause_after_reviewed_commits: 0` * `reviews.finishing_touches:` - `unit_tests.enabled: true` -> `false` (matches Web UI intent; per- repo overrides re-enable where appropriate — testing stacks differ enough that fleet-wide unit-test generation is too noisy) - `simplify.enabled: true` * `reviews.tools:` disabled-linter list for stacks not in our fleet (swiftlint, detekt, rubocop, regal, pmd, circleci, shopifyThemeCheck, brakeman, blinter, smartyLint, emberTemplateLint) * `chat:` - `allow_non_org_members: false` - `integrations.{jira,linear}.usage: disabled` * `knowledge_base:` - `{jira,linear}.usage: disabled` - `mcp.usage: enabled` - `linked_repositories: ansible/ansible` — cross-repo context for the `vyos.vyos` Ansible Galaxy collection. vyos-org specific. After this PR merges: - Clear the Org-UI YAML editor in the CodeRabbit dashboard for the `vyos` org (paste back the empty schema-comment line). The Central YAML now expresses everything that was there. - Sibling change for VyOS-Networks org on its own coderabbit central repo (omits `linked_repositories` per org-specific scope; keeps `early_access: false` since VyOS-Networks Org-UI did not set it). 🤖 Generated by [robots](https://vyos.io) --- .coderabbit.yaml | 51 ++++++++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 50 insertions(+), 1 deletion(-) diff --git a/.coderabbit.yaml b/.coderabbit.yaml index 3fe3d8d..ca2bd1a 100644 --- a/.coderabbit.yaml +++ b/.coderabbit.yaml @@ -1,7 +1,9 @@ # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json inheritance: true language: en-US -early_access: false +# Lifted from the Org-UI Web dashboard (2026-05-12) so this YAML is the +# canonical source of truth. Org-UI editor should be cleared after this lands. +early_access: true tone_instructions: > Concise, technical, no filler. Focus on correctness, security, performance, maintainability. Cite file paths and line numbers. @@ -24,10 +26,19 @@ reviews: auto_apply_labels: false suggested_reviewers: false + # Lifted from Org-UI Web dashboard (2026-05-12). + high_level_summary_in_walkthrough: true + review_details: true + fail_commit_status: true + estimate_code_review_effort: false + in_progress_fortune: false + auto_review: enabled: true auto_incremental_review: true drafts: false + # Lifted from Org-UI (2026-05-12). 0 = never auto-pause after N reviewed commits. + auto_pause_after_reviewed_commits: 0 base_branches: - current - sagitta @@ -75,7 +86,13 @@ reviews: finishing_touches: docstrings: enabled: true + # Disabled at the org-wide level; per-repo `.coderabbit.yaml` files + # re-enable unit-test generation where the testing stack is a good fit. + # Lifted from Org-UI Web dashboard (2026-05-12) where it was explicitly + # disabled. unit_tests: + enabled: false + simplify: enabled: true tools: @@ -87,12 +104,44 @@ reviews: yamllint: { enabled: true } actionlint: { enabled: true } ast-grep: { essential_rules: true } + # Linters disabled fleet-wide because they don't match our stack + # (Swift/Ruby/Rails/Ember/Shopify/CircleCI/PMD). Lifted from Org-UI + # Web dashboard (2026-05-12). + swiftlint: { enabled: false } + detekt: { enabled: false } + rubocop: { enabled: false } + regal: { enabled: false } + pmd: { enabled: false } + circleci: { enabled: false } + shopifyThemeCheck: { enabled: false } + brakeman: { enabled: false } + blinter: { enabled: false } + smartyLint: { enabled: false } + emberTemplateLint: { enabled: false } chat: auto_reply: true + # Lifted from Org-UI Web dashboard (2026-05-12). Restricts CodeRabbit + # chat to org members; non-members receive a deny message. + allow_non_org_members: false + integrations: + jira: { usage: disabled } + linear: { usage: disabled } knowledge_base: opt_out: false learnings: { scope: auto } issues: { scope: auto } pull_requests: { scope: auto } + # Lifted from Org-UI Web dashboard (2026-05-12). + jira: { usage: disabled } + linear: { usage: disabled } + mcp: { usage: enabled } + # Linked repositories provide cross-repo context to CodeRabbit. Org-specific + # — vyos org consumes Ansible context because the `vyos.vyos` Ansible + # collection lives here and references upstream ansible/ansible patterns. + linked_repositories: + - repository: ansible/ansible + instructions: > + This is the main repo for Ansible; our current repo is a collection + for Ansible. -- cgit v1.2.3 From 37144948464285020d89e6b411d8bcd5d51b1c32 Mon Sep 17 00:00:00 2001 From: Yuriy Andamasov Date: Tue, 12 May 2026 11:01:34 +0300 Subject: T8764: disable docstring generation org-wide, mirror unit-tests pattern MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sets `reviews.finishing_touches.docstrings.enabled: false` to match the already-disabled `unit_tests.enabled: false`. Same rationale: documentation conventions vary too much across the fleet for org-wide auto-generation to be useful — Python repos use Sphinx-style, Go repos use godoc-style, web repos use TSDoc-style. Repos that want CodeRabbit to fill in docstrings opt in via their own `.coderabbit.yaml`. 🤖 Generated by [robots](https://vyos.io) --- .coderabbit.yaml | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/.coderabbit.yaml b/.coderabbit.yaml index ca2bd1a..84aa3b9 100644 --- a/.coderabbit.yaml +++ b/.coderabbit.yaml @@ -84,12 +84,13 @@ reviews: - "!**/.terragrunt-cache/**" finishing_touches: + # Both docstring and unit-test generation are disabled at the org-wide + # level; per-repo `.coderabbit.yaml` files re-enable either feature + # where the stack (language, testing framework, doc conventions) + # makes it a good fit. Fleet-wide generation is too noisy because + # the conventions differ across repos. docstrings: - enabled: true - # Disabled at the org-wide level; per-repo `.coderabbit.yaml` files - # re-enable unit-test generation where the testing stack is a good fit. - # Lifted from Org-UI Web dashboard (2026-05-12) where it was explicitly - # disabled. + enabled: false unit_tests: enabled: false simplify: -- cgit v1.2.3