summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPablo Neira Ayuso <pablo@netfilter.org>2012-09-08 21:39:21 +0200
committerGaurav Sinha <gaurav.sinha@vyatta.com>2012-09-12 14:05:08 -0700
commit15edbf1df499f97ff39d9d316ebb288abcf180cd (patch)
treed37575a045f55f0a0d239eb5a58b67a1d00b0c0a
parentfe17d8f3c6c08b08eb3971a0efcba1a0063733a3 (diff)
downloadconntrack-tools-15edbf1df499f97ff39d9d316ebb288abcf180cd.tar.gz
conntrack-tools-15edbf1df499f97ff39d9d316ebb288abcf180cd.zip
conntrackd: parse: fix wrong maximum length for ATTR_EXP_FN
It was set to NFCT_HELPER_NAME_MAX (16 bytes), but we have function names that are larger, eg. nf-nat-follow-master which is 18 bytes long. This leads to hitting malformed message while synchronizing expectations. I'll add some new constant to libnetfilter_conntrack instead of hardcoding this, later. Reported-by: Gaurav Sinha <gaurav.sinha@vyatta.com> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org> (cherry picked from commit 46faeab56cf4117f41cb6f1f1c40a9c18a81372f) (cherry picked from commit 0cf70ce9b1bcb63d54d9514558b74ae2bde39d9f)
-rw-r--r--src/parse.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/parse.c b/src/parse.c
index 732bc44..c3b7f7f 100644
--- a/src/parse.c
+++ b/src/parse.c
@@ -396,7 +396,7 @@ static struct exp_parser {
[NTA_EXP_FN] = {
.parse = exp_parse_str,
.exp_attr = ATTR_EXP_FN,
- .max_size = NFCT_HELPER_NAME_MAX,
+ .max_size = 32, /* XXX: artificial limit */
},
};