efi-boot-shim.git/fallback.c, branch Release_3.0.0

Improve our debuginfo path print

2015-06-30T18:19:57+00:00

Signed-off-by: Peter Jones

Add a conditional point for a debugger to attach.

2015-06-29T18:41:21+00:00

Signed-off-by: Peter Jones

Fix length of allocated buffer for boot option comparison.

2015-04-13T23:55:25+00:00

The following commit: commit 4aac8a1179e160397d7ef8f1e3232cfb4f3373d6 Author: Gary Ching-Pang Lin Date: Thu Mar 6 10:57:02 2014 +0800 [fallback] Fix the data size for boot option comparison corrected the data size used for comparison, but also reduced the allocation so it doesn't include the trailing UTF16LE '\0\0' at the end of the string, with the result that the trailer of the buffer containing the string is overwritten, which OVMF detects as memory corruption. Increase the size of the storage buffer in a few places to correct this problem. Signed-off-by: Richard W.M. Jones Cc: Laszlo Ersek Cc: Gary Ching-Pang Lin

fallback: Fix comparison between signed and unsigned in debugging code.

2015-04-13T23:55:25+00:00

fallback.c: In function ‘update_boot_order’: fallback.c:334:17: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] for (j = 0 ; j < size / sizeof (CHAR16); j++) ^ fallback.c: In function ‘add_to_boot_list’: fallback.c:402:16: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] for (i = 0; i < s; i++) { ^ Signed-off-by: Richard W.M. Jones

[fallback] Try to boot the first boot option anyway

2014-05-13T17:30:07+00:00

Some UEFI implementations never care the boot options, so the restored boot options could be just ignored and this results in endless reboot. To avoid this situation, this commit makes fallback.efi to load the first matched boot option even if there is no boot option to be restored. It may not be perfect, but at least the bootloader is loaded... Signed-off-by: Gary Ching-Pang Lin

[fallback] Fix the data size for boot option comparison

2014-05-13T17:24:12+00:00

Signed-off-by: Gary Ching-Pang Lin

[fallback] Avoid duplicate old BootOrder

2014-05-13T17:23:41+00:00

set_boot_order() already copies the old BootOrder to the variable, bootorder. Besides, we can adjust BootOrder when adding the newly generated boot option. So, we don't have to copy the old one again in update_boot_order(). This avoid the duplicate entries in BootOrder. Signed-off-by: Gary Ching-Pang Lin

additional bounds-checking on section sizes

2014-04-11T18:41:22+00:00

This adds additional bounds-checking on the section sizes. Also adds -Wsign-compare to the Makefile and replaces some signed variables with unsigned counteparts for robustness. Signed-off-by: Kees Cook

[fallback] Attempt to re-use existing entries when possible.

2014-01-31T15:31:10+00:00

Some firmwares seem to ignore our boot entries and put their fallback entries back on top. Right now that results in a lot of boot entries for our stuff, a la https://bugzilla.redhat.com/show_bug.cgi?id=995834 . Instead of that happening, if we simply find existing entries that match the entry we would create and move them to the top of the boot order, the machine will continue to operate in failure mode (which we can't avoid), but at least we won't create thousands of extra entries. Signed-off-by: Peter Jones

[fallback] For HD() device paths, use just the media node and later.

2014-01-31T15:30:36+00:00

UEFI 2.x section 3.1.2 provides for "short-form device path", where the first element specified is a "hard drive media device path", so that you can move a disk around on different buses without invalidating your device path. Fallback has not been using this option, though in most cases efibootmgr has. Note that we still keep the full device path, because LoadImage() isn't necessarily the layer where HD() works - one some systems BDS is responsible for resolving the full path and passes that to LoadImage() instead. So we have to do LoadImage() with the full path.