efi-boot-shim.git/fallback.c, branch Release_3.2.1

fallback: Avoid duplicates in BootOrder

2017-04-25T19:11:15+00:00

When fallback re-uses a duplicate entry, it is likely that it is already listed in BootOrder. In this case the re-used entry should not be copied from the old BootOrder, and the new BootOrder size needs to be adjusted accordingly. Signed-off-by: João Paulo Rechi Vita https://phabricator.endlessm.com/T16731

fallback: Consider all Boot* vars when checking for duplicates

2017-02-21T16:36:13+00:00

Some firmware implementations like the one on the Acer TravelMate P449-G2-MG completely ignore the contents of BootOrder on boot, and overwrite it with a value of its own. On this particular machine, the boot entry that was just created by fallback on the previous boot is not included by the firmware on this new BootOrder, so it is not considered when checking for duplicates. This problem is agravated by the fact that the aformentioned firmware does not give the user the possibility to boot from the entry created by fallback (or any other entry created by the OS). The only way to boot a distro that deploys the fallback setup (no grub inside \EFI\BOOT) with this firmware is to select the entry pointing to \EFI\BOOT\bootx64.efi, leading to a new boot entry being created by fallback on every boot. This commit makes fallback try every Boot* variable when checking for duplicates, working around this problem. Signed-off-by: João Paulo Rechi Vita https://phabricator.endlessm.com/T15481

fallback: replace any existing boot entry with the same name

2017-01-05T18:45:59+00:00

Tweak the dupliate boot entry detection code to consider any existing entries as duplicate if they have the same name (rather than requiring the existing entry to be completely identical to the one we would add). When a duplicate is detected, rewrite the whole variable (as the device details might have changed) in addition to making it the new default boot entry. This means that when partition UUIDs are changed, or when doing a fresh reflash, we will avoid creating duplicate entries with the same name. https://phabricator.endlessm.com/T14430

fallback: Reduce noise when BootOrder list is empty

2016-09-26T08:32:21+00:00

Signed-off-by: Carlo Caione

Improve our debuginfo path print

2015-06-30T18:19:57+00:00

Signed-off-by: Peter Jones

Add a conditional point for a debugger to attach.

2015-06-29T18:41:21+00:00

Signed-off-by: Peter Jones

Fix length of allocated buffer for boot option comparison.

2015-04-13T23:55:25+00:00

The following commit: commit 4aac8a1179e160397d7ef8f1e3232cfb4f3373d6 Author: Gary Ching-Pang Lin Date: Thu Mar 6 10:57:02 2014 +0800 [fallback] Fix the data size for boot option comparison corrected the data size used for comparison, but also reduced the allocation so it doesn't include the trailing UTF16LE '\0\0' at the end of the string, with the result that the trailer of the buffer containing the string is overwritten, which OVMF detects as memory corruption. Increase the size of the storage buffer in a few places to correct this problem. Signed-off-by: Richard W.M. Jones Cc: Laszlo Ersek Cc: Gary Ching-Pang Lin

fallback: Fix comparison between signed and unsigned in debugging code.

2015-04-13T23:55:25+00:00

fallback.c: In function ‘update_boot_order’: fallback.c:334:17: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] for (j = 0 ; j < size / sizeof (CHAR16); j++) ^ fallback.c: In function ‘add_to_boot_list’: fallback.c:402:16: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] for (i = 0; i < s; i++) { ^ Signed-off-by: Richard W.M. Jones

[fallback] Try to boot the first boot option anyway

2014-05-13T17:30:07+00:00

Some UEFI implementations never care the boot options, so the restored boot options could be just ignored and this results in endless reboot. To avoid this situation, this commit makes fallback.efi to load the first matched boot option even if there is no boot option to be restored. It may not be perfect, but at least the bootloader is loaded... Signed-off-by: Gary Ching-Pang Lin

[fallback] Fix the data size for boot option comparison

2014-05-13T17:24:12+00:00

Signed-off-by: Gary Ching-Pang Lin