(mirror of https://github.com/vyos/efi-boot-shim.git) https://git.amelek.net/vyos/efi-boot-shim.git/atom?h=rolling 2025-01-15T20:59:30+00:00 2025-01-15T20:59:30+00:00 Dan Nicholson dbn@endlessos.org 2024-10-02T22:51:18+00:00 urn:sha1:d8c86b740667544acccad92c06eddbc858808a74 When looking for load option optional data, the parser asserts that the byte after the end of device path node is the same as what the file path length says it should be. While unusual, it is valid if the end of device path node comes before the end of the file path list. That supports some unusual Dell load options where there are two device paths in the list but the first is terminated by an End Entire Device Path. Maybe they intended to use an End Device Path Instance node there? Who knows. Either way, treating it as invalid ends up trying to read paths from the beginning of the option with obviously poor results. Fixes: #649 Signed-off-by: Dan Nicholson <dbn@endlessos.org> 2021-07-20T13:44:25+00:00 Peter Jones pjones@redhat.com 2021-07-02T18:36:58+00:00 urn:sha1:3ea1f37c70c571537c92e2be0d78a1ad4629af8f This adds tests for all the cases we've documented in the set_second_stage() comments. Each test checks that all of second_stage, loader_str, and loader_str_size are set correctly. Note that this adds a dependency on libefivar to build device paths to test against. Signed-off-by: Peter Jones <pjones@redhat.com>