mok: Fix memory leak in mok mirroring

Currently valgrind shows a minor issue which is not introduced in this
patch series:

==2595397==
==2595397== HEAP SUMMARY:
==2595397==     in use at exit: 16,368 bytes in 48 blocks
==2595397==   total heap usage: 6,953 allocs, 6,905 frees, 9,146,749 bytes allocated
==2595397==
==2595397== 16,368 bytes in 48 blocks are definitely lost in loss record 1 of 1
==2595397==    at 0x4845464: calloc (vg_replace_malloc.c:1117)
==2595397==    by 0x4087F2: mock_efi_allocate_pool (test.c:72)
==2595397==    by 0x4098DE: UnknownInlinedFun (misc.c:33)
==2595397==    by 0x4098DE: AllocateZeroPool (misc.c:48)
==2595397==    by 0x403D40: get_variable_attr (variables.c:301)
==2595397==    by 0x4071C4: import_one_mok_state (mok.c:831)
==2595397==    by 0x4072F4: import_mok_state (mok.c:908)
==2595397==    by 0x407FA6: test_mok_mirror_0 (test-mok-mirror.c:205)
==2595397==    by 0x4035B2: main (test-mok-mirror.c:378)
==2595397==
==2595397== LEAK SUMMARY:
==2595397==    definitely lost: 16,368 bytes in 48 blocks
==2595397==    indirectly lost: 0 bytes in 0 blocks
==2595397==      possibly lost: 0 bytes in 0 blocks
==2595397==    still reachable: 0 bytes in 0 blocks
==2595397==         suppressed: 0 bytes in 0 blocks
==2595397==

This is because we're doing get_variable_attr() on the same variable
more than once and saving the value to our variables table.  Each
additional time we do so leaks the previous one.

This patch solves the issue by not getting the variable again if it's
already set in the table, and adds a test case to check if we're doing
get_variable() of any variety on the same variable more than once.

Signed-off-by: Peter Jones <pjones@redhat.com>

0 files changed, 0 insertions, 0 deletions