diff options
| author | Peter Jones <pjones@redhat.com> | 2017-09-27 13:25:31 -0400 |
|---|---|---|
| committer | Peter Jones <pmjones@gmail.com> | 2018-03-12 16:21:43 -0400 |
| commit | ea1d6905ba9aede0a09740a809ad7a1b89a08e98 (patch) | |
| tree | 0623b47c25c6cf15cde4006e63ee0f76ba886b98 /lib/variables.c | |
| parent | 809dc7a18bb475c8efcc2f07bd3e7b8ac6997559 (diff) | |
| download | efi-boot-shim-ea1d6905ba9aede0a09740a809ad7a1b89a08e98.tar.gz efi-boot-shim-ea1d6905ba9aede0a09740a809ad7a1b89a08e98.zip | |
fallback: find_boot_csv(): Print the error from try_boot_csv()
Covscan believes the following:
782 if ((EFI_ERROR(rc) || !bootarchcsv) && bootcsv) {
783 EFI_FILE_HANDLE fh2;
784 rc = uefi_call_wrapper(fh->Open, 5, fh, &fh2,
785 bootcsv, EFI_FILE_READ_ONLY, 0);
786 if (EFI_ERROR(rc) || fh2 == NULL) {
787 Print(L"Couldn't open \\EFI\\%s\\%s: %d\n",
788 dirname, bootcsv, rc);
789 } else {
CID 182829 (#1 of 1): Unused value (UNUSED_VALUE)returned_value:
Assigning value from try_boot_csv(fh2, dirname, bootcsv) to rc here,
but that stored value is overwritten before it can be used.
790 rc = try_boot_csv(fh2, dirname, bootcsv);
791 uefi_call_wrapper(fh2->Close, 1, fh2);
792 }
793 }
value_overwrite: Overwriting previous write to rc with value 0UL.
794 rc = EFI_SUCCESS;
795
796 return rc;
797}
Which isn't untrue, we just don't happen to be using the return code for
anything, before we intentionally return success to our caller.
So that's annoying, but whatever. Just print the error as well.
Signed-off-by: Peter Jones <pjones@redhat.com>
Diffstat (limited to 'lib/variables.c')
0 files changed, 0 insertions, 0 deletions