diff options
| author | Peter Jones <pjones@redhat.com> | 2017-09-28 09:44:46 -0400 |
|---|---|---|
| committer | Peter Jones <pmjones@gmail.com> | 2018-03-12 16:21:43 -0400 |
| commit | ee07a19d7ef3dc2e3fc0204aba4def95eeeadf95 (patch) | |
| tree | d8f499236584b1ed4accc9df88274b9b814571b9 /lib/variables.c | |
| parent | 66a7b53677e297ac5be83945dd12ac80c947c6b3 (diff) | |
| download | efi-boot-shim-ee07a19d7ef3dc2e3fc0204aba4def95eeeadf95.tar.gz efi-boot-shim-ee07a19d7ef3dc2e3fc0204aba4def95eeeadf95.zip | |
shim: relocate_coff(): get rid of "FixupData" stuff
"FixupData" in the edk2 tree is a log of the relocations that happened,
which is allocated by the "client" calling relocate, and written into
while it does relocations. Since we never allocate that log anywhere,
FixupData is always NULL, and so covscan says:
318 case EFI_IMAGE_REL_BASED_HIGH:
319 Fixup16 = (UINT16 *) Fixup;
320 *Fixup16 = (UINT16) (*Fixup16 + ((UINT16) ((UINT32) Adjust >> 16)));
null: At condition FixupData != NULL, the value of FixupData must be
NULL. dead_error_condition: The condition FixupData != NULL cannot
be true.
321 if (FixupData != NULL) {
CID 182859 (#1 of 4): Logically dead code (DEADCODE)dead_error_begin:
Execution cannot reach this statement: *((UINT16 *)FixupData) =
*F....
322 *(UINT16 *) FixupData = *Fixup16;
323 FixupData = FixupData + sizeof (UINT16);
324 }
325 break;
And it's right; all four occurrances are deadcode that never do anything
but confuse the reader.
Kill it with fire.
Signed-off-by: Peter Jones <pjones@redhat.com>
Diffstat (limited to 'lib/variables.c')
0 files changed, 0 insertions, 0 deletions