From 47a9d2c908078ff79c4a4043855ec499241c8977 Mon Sep 17 00:00:00 2001 From: Kees Cook Date: Fri, 11 Apr 2014 14:41:22 -0400 Subject: additional bounds-checking on section sizes This adds additional bounds-checking on the section sizes. Also adds -Wsign-compare to the Makefile and replaces some signed variables with unsigned counteparts for robustness. Signed-off-by: Kees Cook --- PasswordCrypt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'PasswordCrypt.c') diff --git a/PasswordCrypt.c b/PasswordCrypt.c index 8d72a821..e0a82cfd 100644 --- a/PasswordCrypt.c +++ b/PasswordCrypt.c @@ -154,7 +154,7 @@ static EFI_STATUS sha256_crypt (const char *key, UINT32 key_len, CopyMem(cp, tmp_result, cnt); SHA256_Init(&alt_ctx); - for (cnt = 0; cnt < 16 + alt_result[0]; ++cnt) + for (cnt = 0; cnt < 16ul + alt_result[0]; ++cnt) SHA256_Update(&alt_ctx, salt, salt_size); SHA256_Final(tmp_result, &alt_ctx); @@ -242,7 +242,7 @@ static EFI_STATUS sha512_crypt (const char *key, UINT32 key_len, CopyMem(cp, tmp_result, cnt); SHA512_Init(&alt_ctx); - for (cnt = 0; cnt < 16 + alt_result[0]; ++cnt) + for (cnt = 0; cnt < 16ul + alt_result[0]; ++cnt) SHA512_Update(&alt_ctx, salt, salt_size); SHA512_Final(tmp_result, &alt_ctx); -- cgit v1.2.3